Justin Maier aed40bc958 fix(reactions): show an unknown reaction count instead of a silent zero (#4962)
* fix(reactions): show an unknown reaction count instead of a silent zero

A reaction count the ClickHouse read could not resolve was indistinguishable
from a real zero by the time it reached the component, and on a card both
rendered as nothing at all: `ReactionButton` drops a zero-count badge when
`noEmpty` is set, which is the default. A metrics outage therefore read as
"nobody reacted".

Carry the distinction as one additive `statsUnknown` flag on `ImageV2Stats`
rather than nullable counts. `getImageMetricsObject` builds all seven fields of
an image from a single ClickHouse row, so a count can never be unresolved on its
own - a per-count shape would be able to represent states the read cannot
produce, and a null could reach `ReactionButton`'s `initialCount + 1` and
surface a fabricated number.

Seven call sites had each derived the stats block by hand as `match?.x ?? 0`.
They now share `toImageV2Stats`, so the absent-vs-zero decision has one
definition instead of seven.

On a card an unknown count renders a "Couldn't load" badge in place of the
empty row; expanded, the badges render an en dash and never a number, including
after the viewer reacts.

Not covered: /api/v1/images builds its stats from event-engine-common's
ImageStats, which has already collapsed an absent row to zero. That path is JSON
only and reached by no rendered feed, so it is pinned to false with a comment;
carrying the flag there needs the submodule shape changed first.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(reactions): cover the metric timeout, gate the unknown badge on a flag

Review of c443a291e4 found the first commit covered only one of
getImageMetricsObject's two failure exits. The outer catch returns {}, so
ids are absent and read as unknown. The soft timeout did not: the loop
after withTimeoutFallback wrote an all-null entry for every requested id,
so `match` was present and a timeout still rendered as a real zero. That
is the documented, instrumented path (the CH read runs ~4.6s p50 against a
3s budget), not an edge case. Both exits now leave ids absent.

The same review found three more gaps:

- The readonly feed card forces `hasReactions` so an unknown count survives
  the readonly early-return, and nothing tested it; deleting the line left
  every case green while restoring the original bug on that surface.
- BuzzTippingBadge renders outside the placeholder branch and read its
  count off the same unresolved row, so an unknown card showed "Couldn't
  load" beside a confident 0. It now renders a dash too.
- toImageV2Stats asserted four of nine fields, so a swapped mapping
  survived; it feeds seven call sites.

The unknown state is gated behind `reactionCountsUnknown` (Flipt key
`reaction-counts-unknown`). Off renders exactly the previous behaviour:
the server still marks the counts, the component ignores them. A missing
flag reads as off, so this ships dark until the flag is created.

Read through `useFeatureFlags` rather than `useOptionalFeatureFlags`: 51
suites mock the provider by hand and list only the former, so importing
the latter killed them at link time with zero tests collected.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(reactions): keep the unknown-count flag dark for moderators too

`reactionCountsUnknown` was declared `availability: ['mod']`. The client's
`isEnabledSync` swallows "flag not found" and falls through to that static
list, so every moderator would have seen the badge from deploy, before the
flag existed in Flipt. `[]` keeps it off for everyone until Flipt says
otherwise. A seam test now runs the real evaluator with only the Flipt edge
stubbed, since the browser tests mock the flag hook and cannot see this.

Also closes three gaps in the kill switch and the failure path:

- The flag-off cases never mounted the tip badge, so a tip that read the
  raw server mark instead of the gated one passed them all. They now pass
  `targetUserId`.
- No case combined flag-off with `readonly`.
- The outer catch's `{}` was claimed in a comment and pinned by nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* test(reactions): prove the unknown-count flag is dark for every audience

The seam test was named for "everyone" but built only free users, so any
paid-tier availability (`member`, `founder`, `bronze`, `silver`, `gold`)
or `granted` would have leaked the badge to that audience at deploy with
every case green. The static fallback matches `user.tier` exactly, so one
paid user does not stand in for another; each tier is its own case, each
also a moderator holding an explicit grant, plus an anonymous visitor.
All nine non-empty availability values the fallback understands now turn
at least one case red.

The file also now primes the lazily loaded Flipt module, as its peer seam
tests do, so the OFF cases exercise "Flipt says the key does not exist"
rather than "Flipt not loaded yet", and the moderator case pins that Flipt
was asked for this key.

The flag-off + readonly browser case now asserts the row has no children,
so it no longer depends on the tip badge being mounted to see a regression.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-18 20:05:06 -06:00
2026-07-30 13:19:05 -05:00

Contributors Forks Stargazers Issues Apache License 2.0 Discord


Table of Contents

About the Project

Our goal with this project is to create a platform where people can share their stable diffusion models (textual inversions, hypernetworks, aesthetic gradients, VAEs, and any other crazy stuff people do to customize their AI generations), collaborate with others to improve them, and learn from each other's work. The platform allows users to create an account, upload their models, and browse models that have been shared by others. Users can also leave comments and feedback on each other's models to facilitate collaboration and knowledge sharing.

Tech Stack

We've built this project using a combination of modern web technologies, including Next.js for the frontend, TRPC for the API, and Prisma + Postgres for the database. By leveraging these tools, we've been able to create a scalable and maintainable platform that is both user-friendly and powerful.

  • DB: Prisma + Postgres
  • API: tRPC
  • Front-end + Back-end: NextJS
  • UI Kit: Mantine
  • Storage: Cloudflare

Getting Started

To get a local copy up and running, follow these steps.

Prerequisites

  • Docker, with Compose v2 (docker compose, not the retired hyphenated docker-compose). The database, Redis, MinIO, Meilisearch, ClickHouse and the mail catcher all run as containers.
  • Node.js 24.19.0. Not "20 or later" — package.json declares engines.node: ">=24.0.0 <25". The exact version lives in .nvmrc; CI installs that file's version and the production image is built on the same one, so nvm use (or any tool that reads .nvmrc) is the right way to get it. Note that nothing stops you: pnpm install only prints WARN Unsupported engine and carries on, so the wrong major surfaces later as odd test failures rather than as a refusal at install time.
  • pnpm. This repo is pnpm-only, and this one is enforced — npm install exits 1 via the preinstall only-allow pnpm hook. corepack enable will pick up the packageManager field for you.
  • Make (optional).

Installation

Standard setup

git clone https://github.com/civitai/civitai.git
cd civitai
nvm use                                              # reads .nvmrc -> 24.19.0
corepack enable
git submodule update --init event-engine-common
cp .env-example .env.development
docker compose -f docker-compose.base.yml up -d
pnpm install
pnpm dev

Optional: Nix flake

Optional, and not the supported default. The standard setup above is what the project expects and what CI builds; nothing in the repo requires Nix, and you can ignore this section entirely. It exists because NixOS cannot use Prisma's published engines (there is no linux-nixos build), so a flake is the practical way to work on this repo there. If you are not on NixOS and not already a flakes user, skip it.

The flake owns the toolchain, so you do not install Node or pnpm yourself:

git clone https://github.com/civitai/civitai.git
cd civitai
nix run .#dev

That single command checks Docker is usable, checks out the event-engine-common submodule, creates .env.development from .env-example if you do not already have one, starts the container stack, waits for Postgres, runs pnpm install, and then starts the dev server on http://localhost:3000. Every step is idempotent — it is safe to re-run in a checkout that already works, and it will not overwrite your .env.development or touch your data.

Useful variants:

nix run .#dev -- --no-start   # bootstrap only, leave the services running
nix run .#dev -- --full       # also start the signals/buzz containers (see below)
nix run .#doctor              # check the flake's pins against the repo
nix flake check               # the same checks, plus their own self-test

For an interactive shell with the same toolchain, use nix develop, or copy .envrc.example to .envrc and run direnv allow to get it automatically on cd.

With devcontainers

⚠️ Known out of step: .devcontainer/public/docker-compose.yml pins mcr.microsoft.com/devcontainers/typescript-node:1-22, i.e. Node 22, which is outside this repo's engines.node range. pnpm install will warn rather than stop, so the container comes up and then misbehaves in ways that look like your branch. There is no 1-24 tag (the template major moved on); 3-24 is the closest equivalent. Not changed here because it could not be exercised.

⚠️ Important Warning for Windows Users: Either clone this repo onto a WSL volume, or use the "clone repository in named container volume" command. Otherwise, you will see performance issues.

  • Open the directory up in your IDE of choice
    • VS Code should prompt you to "Open in container"
      • If not, you may need to manually run Dev Containers: Open Folder in Container
    • For other IDEs, you may need to open the .devcontainer/devcontainer.json file, and click "Create devcontainer and mount sources"
    • Note: this may take some time to run initially
  • Run make run

The signals and buzz services

docker-compose.base.yml holds everything a contributor needs (and is also what nix run .#dev starts). The extra services in docker-compose.yml (signals, buzz) come from private ghcr.io images, so they only work for internal members:

  • create a GitHub personal access token with read:packages
  • set it as CR_PAT
  • echo $CR_PAT | docker login ghcr.io -u USERNAME --password-stdin
  • then docker compose up -d (or, with the flake, nix run .#dev -- --full)

After the first start

  1. Edit .env.development. Most defaults work out of the box; these do not:
    • S3 upload credentials. Open the MinIO console at http://localhost:9001 (username and password both minioadmin) — note it is port 9001, port 9000 is the S3 API itself — go to "Access Keys", click "Create Access Key", and copy the key and secret into S3_UPLOAD_KEY / S3_UPLOAD_SECRET and S3_IMAGE_UPLOAD_KEY / S3_IMAGE_UPLOAD_SECRET.
    • WEBHOOK_TOKEN — any random string; it authenticates requests to the webhook endpoint.
    • EMAIL_USER, EMAIL_PASS, and EMAIL_FROM (a valid email format) — any values, but they must be set for user registration to work.
  2. On an empty database, populate it. These are slow and destructive, which is why no bootstrap runs them for you:
    make run-migrations
    make reseed
    
  3. Visit http://localhost:3000.

Please report any issues with these commands to us on discord.

* Note that account creation will run emails through maildev, which can be accessed at http://localhost:1080.

Altering your user

  • First, create an account for yourself as you normally would through the UI.
  • You may wish to set yourself up as a moderator. To do so:
    • Use a database editor (like DataGrip) or connect directly to the DB (PGPASSWORD=postgres psql -h localhost -p 15432 -U postgres civitai)
    • Find your user (by email or username), and change isModerator to true

Known limitations

Services that require external input will currently not work locally. These include:

  • Orchestration (Generation, Training)
  • Signals (Chat, Notifications, other real-time updates)
  • Buzz

Contributing

Any contributions you make are greatly appreciated.

If you have a suggestion that would make this better, please fork the repo and create a pull request. You can also simply open an issue with the tag "enhancement". Don't forget to give the project a star! Thanks again!

  1. Fork the repository to your own GitHub account.
  2. Create a new branch for your changes.
  3. Make your changes to the code.
  4. Commit your changes and push the branch to your forked repository.
  5. Open a pull request on our repository.

If you would like to be more involved, consider joining the Community Development Team! For more information on the team as well as how to join, see Calling All Developers: Join Civitai's Community Development Team.

Data Migrations

Over the course of development, you may need to change the structure of the database. To do this:

  1. Make your changes to the packages/civitai-db-schema/prisma/schema.full.prisma file. Not schema.prisma — that one is gitignored and regenerated from schema.full.prisma by scripts/generate-slim-schema.js on every pnpm run db:generate, so edits to it are silently overwritten.
  2. Run pnpm run db:migrate:empty "brief description here". This creates packages/civitai-db-schema/prisma/migrations/YYYYMMDDHHmmss_brief_description_here/migration.sql for you, in the one directory Prisma reads. To create it by hand instead, use that same path — not the prisma/migrations directory at the repo root, which predates the monorepo layout and is no longer read.
  3. Put your sql changes in the generated migration.sql
    • These are usually simple sql commands like ALTER TABLE ...
  4. Run make run-migrations and make gen-prisma
  5. If you are adding/changing a column or table, please try to keep the gen_seed.ts file up to date with these changes.

Sponsors

Support this project by becoming a sponsor. Your logo will show up here with a link to your website.

License

Apache License 2.0 - Please have a look at the LICENSE for more details.

S
Description
clickup: Interact with ClickUp tasks and documents - get task details, view comments, create and manage tasks, create and edit docs. Use when working with ClickUp…; quick-mockups: Create multiple UI design mockups in parallel. Use when asked to create mockups, wireframes, or design variations for a feature. Creates HTML files using…
Readme 362 MiB
Languages
TypeScript 93.3%
JavaScript 2.6%
Svelte 2.5%
PLpgSQL 0.5%
SCSS 0.4%
Other 0.6%