Commit Graph

4143 Commits

Author SHA1 Message Date
mmalerba 4a9fe87f8a perf(virtual-scroll): improve scrolling performance (#12490)
Adds contain and translateZ to viewport and wrapper CSS and switches spacer to use transform instead of width/height
2018-08-03 07:02:38 -07:00
Kristiyan Kostadinov 674ebcd925 chore(select): fix flaky positioning test (#12496)
Fixes a flaky test that is failing on iOS.
2018-08-02 16:44:00 -07:00
Paul Gschwendtner 8cbe8122c0 build: add test cases for update schematics (#12473)
Adds a way to test that the update schematics properly update a developer's application.
2018-08-02 11:28:07 -07:00
mmalerba dcd2282295 feat(virtual-scroll): move from cdk-experimental to cdk (#12438) 2018-08-01 14:36:02 -07:00
Kristiyan Kostadinov d392a8dc0b build: material sources not being watched when developing locally (#12472)
Fixes the Material sources not being rebuilt on changes due to an incorrect pattern.
2018-08-01 07:31:20 -07:00
Paul Gschwendtner e273a7a415 fix(slide-toggle): prevent error when disabling while focused (#12325)
Fixes Angular throwing an `ExpressionChangedAfterItHasBeenCheckedError` when disabling the slide-toggle while the component has been focused.

Fixes #12323
2018-08-01 07:19:29 -07:00
Paul Gschwendtner c4cacceba9 fix(checkbox): prevent error when disabling while focused (#12327)
* Fixes that Angular throws an ExpressionChangedAfterItHasBeenCheckedError when disabling the checkbox while the component has been focused.
* Adds missing test for `NgModel` states after value change through view.

Related #12323
2018-08-01 07:18:52 -07:00
Kristiyan Kostadinov a10bfa4995 fix(live-announcer): duplicate live element when coming in from the server (#12378)
Fixes the case where the user might get multiple live announcer elements, if they're coming in from a server-side-rendered page. Along the same lines as #11940.
2018-08-01 07:18:15 -07:00
Kristiyan Kostadinov e6443508a1 fix(bidi): default invalid directionality values to ltr (#12396)
Fixes invalid directionality values being accepted as they are, rather than defaulting to ltr. Browsers fall back to ltr anyway, however having an invalid value can break some of our component that could be checking for one of the correct values explicitly.
2018-08-01 07:18:00 -07:00
Kristiyan Kostadinov 4884dacb58 fix(form-field): reset inputs not being reset on safari (#12413)
Fixes Safari's custom styling for `input[type='search']` not being reset inside of form fields.

Fixes #12408.
2018-08-01 07:17:20 -07:00
Kristiyan Kostadinov 71886f84ef perf(overlay): remove detached overlays from the DOM (#12414)
Removes the detached overlays from the DOM, rather than keeping their host element. Previously we kept the elements in the DOM, because they don't interfere with user interactions and it made it easier to handle animations, however doing so can cause scroll jank, because the host still has dimensions and is being rendered by the browser.

Fixes #12341.
2018-08-01 07:15:23 -07:00
Kristiyan Kostadinov e007c27bd5 fix(chips): dynamic chip input placeholder changes not being propagated to form field (#12422)
Fixes changes to the placeholder of a chip input not being propagated to its parent form field. Also un-deprecates the input for `placeholder`, because we need to know when it has changed.

Fixes #11861.
2018-08-01 07:15:00 -07:00
Kristiyan Kostadinov bcf4c9f26b fix(chips): focus indication not visible in high contrast mode (#12431)
Fixes not being able to tell which chip is focused in high contrast mode.
2018-08-01 07:14:14 -07:00
Kristiyan Kostadinov df2b371d66 fix(form-field): unable to distinguish disabled form field in high contrast mode (#12445)
Fixes the disabled form field being indistinguishable from enabled ones in high contrast mode, due to the dotted gradient not being rendered.
2018-08-01 07:14:00 -07:00
Kristiyan Kostadinov db8f83dfe2 fix(drag-drop): account for transition-delay when waiting for the animation to finish (#12466)
Currently we have some functionality that waits for the preview's animation to finish and falls back to a timeout, based on the computed `transition-duration`, however that fallback doesn't account for the case where the element has a `transition-delay`. These changes account for the delay.
2018-08-01 07:03:57 -07:00
Jeremy Elbourn 6a02b94ed2 chore: remove tinayuangao from codeowners (#12444) 2018-07-31 16:47:01 -07:00
Paul Gschwendtner 51af4718db refactor(schematics): remove type checker for identifier switch rule (#12454)
Removes type checking from the `switchIdentifiersRule` because we don't want to depend on types for older versions when running the schematics. The rule still maintains the explicit checks that ensure that only identifiers from Material or the CDK are being updated,
2018-07-31 15:19:25 -07:00
Paul Gschwendtner 73f3f940b0 build: remove deprecated node-github api (#12420)
Switches to the newer version of `node-github` that has been renamed to `@octokit/rest`.
2018-07-31 11:13:34 -07:00
Paul Gschwendtner f5f7f1c3d1 build: add version stamp to release output (#12418) 2018-07-31 09:23:20 -07:00
Paul Gschwendtner e4ac04d678 build: speed-up stylesheet building (#12426)
* Switches back from `dart-sass` to `node-sass` due to a pretty huge slow-down we noticed (can be revisited)
* No longer copies all SCSS files to the temporary `package` output just in favor of the demo-app (slows down unnecessarily). This now allows us to live-reload theme changes within a second.
* No longer rebuilds all package SCSS files twice for the ES5 output (rel: https://github.com/angular/material2/pull/7403)
2018-07-31 09:06:39 -07:00
Paul Gschwendtner 08e6653707 fix(schematics): properly detect tsconfig files (#12434)
* Currently the `tsconfig` files are not being detected properly with the latest Angular CLI version.
* Improves tslint config comment
2018-07-31 09:04:45 -07:00
mmalerba 37ba893ee0 chore: use regex to whitelist branches for CI (#12439) 2018-07-31 09:03:53 -07:00
mmalerba 2ffdae6c80 chore: 6.4.2 changelog (#12441)
* chore: 6.4.2 changelog

* address comments
2018-07-30 15:01:02 -07:00
Kristiyan Kostadinov 877de5691b build: rename @deletion-target to @breaking-change (#12421)
As discussed, renames the `@deletion-target` tag to `@breaking-change` to make the intentions of the tag clearer. Also adds an extra check to the tslint rule to catch any leftover `@deletion-target` tags.
2018-07-28 21:51:41 -07:00
Kristiyan Kostadinov 4e358c3739 feat(tooltip): align with 2018 material design spec (#12310)
Adjusts the tooltip to align it with the new Material design spec.
2018-07-28 21:49:44 -07:00
Paul Gschwendtner e07400354a build: switch to dart-sass (#12370)
* Switches to dart-sass in order to be consistent with the Bazel output. That way we can identify potential issues with the SASS output (e.g. demo-app) before we at some point make the full-switch.
* Also speeds-up the project installs because libsass bindings are no longer needed (trade-off with compilation time though; but pretty minimal due to our amount of Sass files)
2018-07-28 21:49:04 -07:00
Paul Gschwendtner 5963d14bdd build(schematics): test schematics properly (#12410)
* build(schematics): test schematics properly

* Previously, the spec files that have been pushed to the repository, didn't run at all, or were outdated. This PR updates the tests and also enables most of them (as much as possible).
* Sets up the Bazel test rules (with a few needed workarounds) in order to test the schematics
* Removed devkit utils that can be used from `@schematics/angular` which is **always present** (we can assume that)
* Moved data `.json` files into TypeScript files (in order to workaround a bazel typescript issue; and to allow separation for v6 and v7 data at some point)
* Updates and fixes schematics to properly work within the latest Angular CLI version

* Address feedback

* Remove unnecessary diff
2018-07-28 21:48:11 -07:00
Kristiyan Kostadinov 1f538416b5 fix(drag-drop): throwing off NgFor differ (#12393)
Reworks the drag&drop not to move the element around in the DOM anymore once it's dropped. Moving the element while it's inside an `NgFor` can be dangerous, because Angular may decide to move the element itself, rather than recreate it, in which case the DOM order will be wrong.

Fixes #12388.
2018-07-28 21:47:30 -07:00
Paul Gschwendtner 0958cbb2b1 fix(snack-bar): prevent content from overriding configured aria-live message (#12294)
* Currently the `announcementMessage` config option is always being overwritten when opening a simple snackbar.
2018-07-28 21:46:35 -07:00
Kristiyan Kostadinov fba4a9369c fix(card): incorrectly inverting inset divider in rtl (#12285)
Fixes the inset divider on a card in RTL being pushed outside the card.
2018-07-28 21:45:42 -07:00
Kristiyan Kostadinov 34a7e38214 perf(table): leaking reference through mostRecentCellOutlet (#12269)
Fixes the table leaking out a reference to a cell outlet via the `CdkCellOutlet.mostRecentCellOutlet` after all tables have been destroyed.

Fixes #12259.
2018-07-28 21:45:04 -07:00
Kristiyan Kostadinov 441c98e838 fix(sidenav): scrollable instance not exposed when explicitly specifying content element (#11706)
This is a resubmit of #11517 which got in by accident.

* Fixes the `MatSidenavContainer.scrollable` being undefined if the consumer has set the `mat-sidenav-content` themselves. The issue comes from the fact that we only query for scrollables inside the drawer's own view, but not inside the projected content.
* Fixes the example in the sidenav docs accessing the scrollable too early.

Fixes #10884.

BREAKING CHANGE: the constructor signature of the `MatDrawerContent` and `MatSidenavContent` has changed.
2018-07-28 21:44:48 -07:00
mmalerba e462f3d4bd virtual-scroll: emit the currently scrolled to index (#12381)
Note: `(scrolledIndexChange)` currently does not work with the `AutoSizeVirtualScrollStrategy`. Support for this will be added in a future PR.
2018-07-26 10:18:45 -07:00
Kristiyan Kostadinov c2190e409a refactor(table): remove redundant constructors (#12301)
Removes some redundant constructors that were added as a workaround for a compiler issue that's been fixed since 6.0.
2018-07-26 10:03:40 -07:00
Kristiyan Kostadinov b9c0d85497 fix(progress-bar): query animation not working inside routes with named outlets (#12350)
This is something that was introduced by #12014. Because we didn't have quotes around the URL in the `fill` value, the reference could become invalid if the user is on a route with a named outlet, which contains parentheses in its URL.

Fixes #12338.
2018-07-26 10:02:13 -07:00
Sergey Fetiskin e2a158ed59 docs: Getting started guide update about animations (#12377)
Closes #12365
2018-07-26 09:57:35 -07:00
Kristiyan Kostadinov 5502e6f5d6 feat(drag-drop): allow connecting containers via string ids, attaching data to drop instances and consolidate global event listeners (#12315)
* Adds the ability to pass in strings to `connectedTo` when connecting multiple containers together. Previously we only accepted `CdkDrop` instances which can be inconvenient to pass while inside an `ngFor`.
* Adds the ability to attach extra data to a `CdkDrag`, similarly to `CdkDrop`. This is mostly for consistency and convenience.
* Introduces the `CdkDragDropRegistry` which is used to keep track of the active `CdkDrag` and `CdkDrop` instances. It also manages all of the events on the `document` in order to ensure that we only have one of each event at a given time. This will allow us to handle dragging multiple items at the same time, eventually.
2018-07-25 13:57:57 -07:00
Paul Gschwendtner 6aa1a55ba7 refactor(live-announcer): add unique class to identify live element (#12309)
* Adds a unique class to the live announcer element that is automatically created by the `LiveAnnouncer`. Similarly to the overlay container, the live announcer should be also distinguishable (e.g. for testing)
2018-07-24 19:27:39 -07:00
mmalerba 6a0b8f79a4 virtual-scroll: add support for scrollToOffset and scrollToIndex (#12272)
Note: `scrollToIndex` currently does not work with the `AutoSizeVirtualScrollStrategy`. Support for this will be added in a future PR.

This PR is based off #11498 by @amcdnl. I removed the `lazy` option from #11498 to avoid bloating the API. I'm not sure how common the use case is, and its relatively simple to implement on top using the current APIs.
2018-07-24 19:22:40 -07:00
Kristiyan Kostadinov 60b9928f34 perf(tree): leaking reference through mostRecentTreeNode (#12334)
Along the same lines as #12269. Clears out the `mostRecentTreeNode` once the last tree node is destroyed, in order to avoid a memory leak.
2018-07-24 16:39:13 -07:00
Kristiyan Kostadinov bd76f1a345 refactor: remove internal usages of deprecated apis (#12316)
Removes a handful of internal usages of APIs that have been deprecated.
2018-07-24 13:29:39 -07:00
Kristiyan Kostadinov f0a0ab109e fix(autocomplete): remove aria-owns attribute while closed (#12333)
Removes the `aria-owns` attribute from the autocomplete trigger while the panel is closed.

Fixes #12332.
2018-07-24 13:29:00 -07:00
mmalerba e67fd7b84d virtual-scroll: switch back to markForCheck since detectChanges (#12329)
breaks viewports that are inside an `OnPush` component.

Fixes issue introduced by #12158
2018-07-24 10:24:40 -07:00
Paul Gschwendtner e23709f513 build: remove unused dependencies (#12346)
* Removes unused dependencies.
2018-07-24 10:10:07 -07:00
Kristiyan Kostadinov f4fcf7865b build: avoid manually-maintained example lists (#12335)
Reworks the demos that were using the docs examples to avoid having to hard-code the list of examples for each component.
2018-07-24 10:09:28 -07:00
Paul Gschwendtner ed4e082bef fix(schematics): properly indent inline files (#12317)
* Properly indents files that are being inlined through the `resolvedFiles` object that been recently introduced
2018-07-24 10:08:43 -07:00
Paul Gschwendtner c5b87da5c3 fix(update): support parenthesized directive metadata (#12314)
* Currently if the directive metadata is parenthesized, the upgrade tool will fail due to a runtime exception. We should properly handle that edge-case since the `ComponentWalker` is one of major parts for the upgrade tool and will persist in future releases.
* No longer fails if a `@Component` is being created without any metadata or a wrong number of arguments (rel: https://github.com/angular/angular/commit/9a6f27c34ce32af346e20f9cae8ebaacff89cd56)
2018-07-24 10:07:49 -07:00
Paul Gschwendtner 634163ef45 docs: properly show method overloads (#12308)
* Shows method overloads in the documentation instead of showing the overload-base method that has most likely no `JSDoc` nor good-explaining parameter names (parameters have multiple purposes and types)
2018-07-24 10:07:15 -07:00
Kristiyan Kostadinov 436981a3fe docs: fix up button-types and dialog-content examples (#12320)
* Fixes the scrollable dialog content demo not scrolling properly. Also fixes up some of typography and alignment.
* Fixes the spacing and alignment on the `button-types` demo.
2018-07-24 10:06:32 -07:00
Joey Perrott c3e3dcb3fc chore: update changelog for 6.4.1 (#12330) 2018-07-23 12:06:52 -07:00