mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
refactor(migrations): typos in signal migration incompatibility reasons (#58636)
A dot was appearing in the middle of the comment for `DerivedIsIncompatible`. While at it, a dot was missing in `ClassManuallyInstantiated`. PR Close #58636
This commit is contained in:
committed by
Jessica Janiuk
parent
d892b4aa2b
commit
715caea46b
+2
-2
@@ -50,7 +50,7 @@ export function getMessageForFieldIncompatibility(
|
||||
`This ${fieldName.single} is used in combination with \`@HostBinding\` and ` +
|
||||
`migrating would break.`,
|
||||
extra:
|
||||
`\`@HostBinding\` does not invoke the signal automatically and your code would. ` +
|
||||
`\`@HostBinding\` does not invoke the signal automatically and your code would ` +
|
||||
`break after migration. Use \`host\` of \`@Directive\`/\`@Component\`for host bindings.`,
|
||||
};
|
||||
case FieldIncompatibilityReason.PotentiallyNarrowedInTemplateButNoSupportYet:
|
||||
@@ -144,7 +144,7 @@ export function getMessageForClassIncompatibility(
|
||||
return {
|
||||
short:
|
||||
`Class of this ${fieldName.single} is manually instantiated. ` +
|
||||
'This is discouraged and prevents migration',
|
||||
'This is discouraged and prevents migration.',
|
||||
extra:
|
||||
`Signal ${fieldName.plural} require a DI injection context. Manually instantiating ` +
|
||||
'breaks this requirement in some cases, so the migration is skipped.',
|
||||
|
||||
@@ -827,7 +827,7 @@ import {Component, Input} from '@angular/core';
|
||||
export class ManualInstantiation {
|
||||
// TODO: Skipped for migration because:
|
||||
// Class of this input is manually instantiated. This is discouraged and prevents
|
||||
// migration
|
||||
// migration.
|
||||
@Input() bla: string = '';
|
||||
}
|
||||
@@@@@@ modifier_tests.ts @@@@@@
|
||||
|
||||
Reference in New Issue
Block a user