From 715caea46b4c8b3d3e786b801fb1992815e4ffe2 Mon Sep 17 00:00:00 2001 From: cexbrayat Date: Wed, 13 Nov 2024 17:48:27 +0100 Subject: [PATCH] refactor(migrations): typos in signal migration incompatibility reasons (#58636) A dot was appearing in the middle of the comment for `DerivedIsIncompatible`. While at it, a dot was missing in `ClassManuallyInstantiated`. PR Close #58636 --- .../src/passes/problematic_patterns/incompatibility_human.ts | 4 ++-- .../schematics/migrations/signal-migration/test/golden.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core/schematics/migrations/signal-migration/src/passes/problematic_patterns/incompatibility_human.ts b/packages/core/schematics/migrations/signal-migration/src/passes/problematic_patterns/incompatibility_human.ts index 325d0434bc0..2bf093b59d4 100644 --- a/packages/core/schematics/migrations/signal-migration/src/passes/problematic_patterns/incompatibility_human.ts +++ b/packages/core/schematics/migrations/signal-migration/src/passes/problematic_patterns/incompatibility_human.ts @@ -50,7 +50,7 @@ export function getMessageForFieldIncompatibility( `This ${fieldName.single} is used in combination with \`@HostBinding\` and ` + `migrating would break.`, extra: - `\`@HostBinding\` does not invoke the signal automatically and your code would. ` + + `\`@HostBinding\` does not invoke the signal automatically and your code would ` + `break after migration. Use \`host\` of \`@Directive\`/\`@Component\`for host bindings.`, }; case FieldIncompatibilityReason.PotentiallyNarrowedInTemplateButNoSupportYet: @@ -144,7 +144,7 @@ export function getMessageForClassIncompatibility( return { short: `Class of this ${fieldName.single} is manually instantiated. ` + - 'This is discouraged and prevents migration', + 'This is discouraged and prevents migration.', extra: `Signal ${fieldName.plural} require a DI injection context. Manually instantiating ` + 'breaks this requirement in some cases, so the migration is skipped.', diff --git a/packages/core/schematics/migrations/signal-migration/test/golden.txt b/packages/core/schematics/migrations/signal-migration/test/golden.txt index 732eec137e5..0f962269979 100644 --- a/packages/core/schematics/migrations/signal-migration/test/golden.txt +++ b/packages/core/schematics/migrations/signal-migration/test/golden.txt @@ -827,7 +827,7 @@ import {Component, Input} from '@angular/core'; export class ManualInstantiation { // TODO: Skipped for migration because: // Class of this input is manually instantiated. This is discouraged and prevents - // migration + // migration. @Input() bla: string = ''; } @@@@@@ modifier_tests.ts @@@@@@