fix(overlay): correct misspelled flexibleDiemsions property (#12927)

BREAKING CHANGE:
The `flexibleDiemsions` property on `CdkConnectedOverlay` has been renamed to `flexibleDimensions`

Fixes #12925
This commit is contained in:
CaerusKaru
2018-09-14 08:53:40 -05:00
committed by Jeremy Elbourn
parent b62343a237
commit 5d1643abce
3 changed files with 21 additions and 5 deletions
+2 -2
View File
@@ -382,12 +382,12 @@ describe('Overlay directives', () => {
});
it('should allow for flexible positioning to be enabled', () => {
expect(fixture.componentInstance.connectedOverlayDirective.flexibleDiemsions).not.toBe(true);
expect(fixture.componentInstance.connectedOverlayDirective.flexibleDimensions).not.toBe(true);
fixture.componentInstance.flexibleDimensions = true;
fixture.detectChanges();
expect(fixture.componentInstance.connectedOverlayDirective.flexibleDiemsions).toBe(true);
expect(fixture.componentInstance.connectedOverlayDirective.flexibleDimensions).toBe(true);
});
it('should allow for growing after open to be enabled', () => {
+5 -3
View File
@@ -183,8 +183,10 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
/** Whether the overlay's width and height can be constrained to fit within the viewport. */
@Input('cdkConnectedOverlayFlexibleDimensions')
get flexibleDiemsions() { return this._flexibleDimensions; }
set flexibleDiemsions(value: boolean) { this._flexibleDimensions = coerceBooleanProperty(value); }
get flexibleDimensions() { return this._flexibleDimensions; }
set flexibleDimensions(value: boolean) {
this._flexibleDimensions = coerceBooleanProperty(value);
}
/** Whether the overlay can grow after the initial open when flexible positioning is turned on. */
@Input('cdkConnectedOverlayGrowAfterOpen')
@@ -310,7 +312,7 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
private _createPositionStrategy(): FlexibleConnectedPositionStrategy {
const strategy = this._overlay.position()
.flexibleConnectedTo(this.origin.elementRef)
.withFlexibleDimensions(this.flexibleDiemsions)
.withFlexibleDimensions(this.flexibleDimensions)
.withPush(this.push)
.withGrowAfterOpen(this.growAfterOpen)
.withViewportMargin(this.viewportMargin)
@@ -352,6 +352,20 @@ export const propertyNames: VersionChanges<MaterialPropertyNameData> = {
}
}
]
},
// TODO(devversion): this should be part of the V6 to V7 upgrade
{
pr: 'https://github.com/angular/material2/pull/12927',
changes: [
{
replace: 'flexibleDiemsions',
replaceWith: 'flexibleDimensions',
whitelist: {
classes: ['CdkConnectedOverlay']
}
}
]
}
]
};