From 5d1643abced6b6c58074a4c8250ed09b1a384d19 Mon Sep 17 00:00:00 2001 From: CaerusKaru Date: Fri, 14 Sep 2018 08:53:40 -0500 Subject: [PATCH] fix(overlay): correct misspelled flexibleDiemsions property (#12927) BREAKING CHANGE: The `flexibleDiemsions` property on `CdkConnectedOverlay` has been renamed to `flexibleDimensions` Fixes #12925 --- src/cdk/overlay/overlay-directives.spec.ts | 4 ++-- src/cdk/overlay/overlay-directives.ts | 8 +++++--- .../update/material/data/property-names.ts | 14 ++++++++++++++ 3 files changed, 21 insertions(+), 5 deletions(-) diff --git a/src/cdk/overlay/overlay-directives.spec.ts b/src/cdk/overlay/overlay-directives.spec.ts index 1fc30824d35..88794b0810f 100644 --- a/src/cdk/overlay/overlay-directives.spec.ts +++ b/src/cdk/overlay/overlay-directives.spec.ts @@ -382,12 +382,12 @@ describe('Overlay directives', () => { }); it('should allow for flexible positioning to be enabled', () => { - expect(fixture.componentInstance.connectedOverlayDirective.flexibleDiemsions).not.toBe(true); + expect(fixture.componentInstance.connectedOverlayDirective.flexibleDimensions).not.toBe(true); fixture.componentInstance.flexibleDimensions = true; fixture.detectChanges(); - expect(fixture.componentInstance.connectedOverlayDirective.flexibleDiemsions).toBe(true); + expect(fixture.componentInstance.connectedOverlayDirective.flexibleDimensions).toBe(true); }); it('should allow for growing after open to be enabled', () => { diff --git a/src/cdk/overlay/overlay-directives.ts b/src/cdk/overlay/overlay-directives.ts index 364c2746551..901fa42b8ff 100644 --- a/src/cdk/overlay/overlay-directives.ts +++ b/src/cdk/overlay/overlay-directives.ts @@ -183,8 +183,10 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges { /** Whether the overlay's width and height can be constrained to fit within the viewport. */ @Input('cdkConnectedOverlayFlexibleDimensions') - get flexibleDiemsions() { return this._flexibleDimensions; } - set flexibleDiemsions(value: boolean) { this._flexibleDimensions = coerceBooleanProperty(value); } + get flexibleDimensions() { return this._flexibleDimensions; } + set flexibleDimensions(value: boolean) { + this._flexibleDimensions = coerceBooleanProperty(value); + } /** Whether the overlay can grow after the initial open when flexible positioning is turned on. */ @Input('cdkConnectedOverlayGrowAfterOpen') @@ -310,7 +312,7 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges { private _createPositionStrategy(): FlexibleConnectedPositionStrategy { const strategy = this._overlay.position() .flexibleConnectedTo(this.origin.elementRef) - .withFlexibleDimensions(this.flexibleDiemsions) + .withFlexibleDimensions(this.flexibleDimensions) .withPush(this.push) .withGrowAfterOpen(this.growAfterOpen) .withViewportMargin(this.viewportMargin) diff --git a/src/lib/schematics/update/material/data/property-names.ts b/src/lib/schematics/update/material/data/property-names.ts index 789beaa7313..05766d21798 100644 --- a/src/lib/schematics/update/material/data/property-names.ts +++ b/src/lib/schematics/update/material/data/property-names.ts @@ -352,6 +352,20 @@ export const propertyNames: VersionChanges = { } } ] + }, + + // TODO(devversion): this should be part of the V6 to V7 upgrade + { + pr: 'https://github.com/angular/material2/pull/12927', + changes: [ + { + replace: 'flexibleDiemsions', + replaceWith: 'flexibleDimensions', + whitelist: { + classes: ['CdkConnectedOverlay'] + } + } + ] } ] };