mirror of
https://github.com/trailofbits/skills.git
synced 2026-09-14 14:28:48 +08:00
kz-tob
4b1b74b181
* Give differential-review a trigger, and name every component in its README differential-review's description listed what it does and never named a situation, so it competed on capability wording alone. It now closes with the triggers its own README already documents — reviewing a PR, commit, or diff; checking whether a change re-introduces a fixed bug; asking what else a change could break; finding modified code with no test. The same plugin's README never mentioned adversarial-modeler, which is what Phase 5 dispatches for HIGH RISK changes. Checking whether that was isolated turned up more of it, and the sweep found three kinds of gap: zeroize-audit's agent table was missing three of its eleven agents — 0-preflight, which gates the entire run, plus 5b-poc-validator and 5c-poc-verifier. All three appear in the phase diagram directly above the table, which is why they read as present. constant-time-analysis documents the ct-analyzer CLI end to end and never says the plugin also ships a skill and a command. entry-point-analyzer lists phrases that trigger its skill but never names the skill or its command. Three more READMEs describe their skill without naming it. That matters most where the skill name is not the plugin name and a user cannot guess it: chrome-mcp-troubleshooting and interpreting-culture-index. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * Fix review findings and make the README sweep a gate The two PoC rows I added to zeroize-audit said Phase 4. The diagram three lines above them, SKILL.md, and workflows/phase-5-poc-validation.md all say Phase 5, steps 5a and 5b. "Wave 5a" is a label that exists nowhere. A debugger consulting the table — the artifact this branch designates as what runs when — would have opened phase-4-poc-generation.md and found no validation in it. Also corrected the sentence introducing that table, which still said 10 agents across 8 phases against 11 across 9, and the Phase 0 diagram line, which still credited the orchestrator for a gate the new row credits to 0-preflight. differential-review's README claimed the agent is "dispatched", and named it bare in a column whose other rows are namespaced. Nothing dispatches it: the only instruction is prose in SKILL.md, and a bare subagent_type fails at runtime. Namespaced both, and corrected the five stale line counts in the same file — reporting.md is 369 lines, not the ~120 the token-efficiency section budgets for. Drop the dead `name: trailofbits:<cmd>` key from five command files. The three newest command files carry no name: at all, #275 namespaced 22 bare invocations, and this branch documents the `/<plugin>:<cmd>` form — so the key contradicts the docs it sits next to. Then make the sweep repeatable. Doing this by hand three times found eight gaps and missed two more, both of the same shape: a workflow ships under meta.name, not its filename, so a README citing the filename never writes the name a reader types. The validator now checks that a README names every skill, agent, command, and workflow its plugin ships, reading meta.name for workflows. It refuses a run that inspected zero components, and six self-test assertions hold it to known-bad fixtures. It found git-cleanup on its first run: ships as /git-cleanup:git-cleanup-analysis, README cites workflows/analyze-branches.js four times and that name never. static-analysis had the same gap for codeql-build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * Fix both P2s: the gate was a substring test, and the dispatch was still bare The README gate ran `name not in text`. That reads as thorough and could not fail for a large share of what it counted: `draw` was satisfied by "(draw cards instead)", `semgrep-rule` by the plugin's own name in the install line, `burp-search` by a `scripts/burp-search.sh` path that is a different thing, and `audit` by the prose "shared-state struct audit". Match by kind instead. Commands and workflows are reachable only as `/<plugin>:<name>`, so require that literal — it is the only string a user can type. Agents are dispatched by identifier and never typed as prose, so require an identifier-shaped mention. Skills are genuinely referred to by bare name, so require only a delimited occurrence, which is what stops "draws" counting as `draw`. That surfaced seven real gaps, the four above plus insecure-defaults' audit-pipeline workflow, mutation-testing's skill, and trailmark's code-slice-worker. All seven fixed. adversarial-modeler was still bare at SKILL.md:96. Line 77 was the decision-tree mention; line 96 is the "Delegate to this agent" instruction a model actually acts on, so the runtime failure the last commit claimed to fix survived it. Namespaced, and it now says why. Also from the review: a per-kind floor, since a single total stays healthy while skill_files() — 63% of coverage — silently stops matching; workflow_names anchored to the meta block, because a bare search takes any earlier `name:` in a comment, and .mjs was invisible; and AGENTS.md documents the new hard failure. Self-test 88 -> 96, each new rule with a negative control. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
83 lines
3.4 KiB
Markdown
83 lines
3.4 KiB
Markdown
# Devcontainer Setup Plugin
|
|
|
|
Create pre-configured devcontainers with Claude Code and language-specific tooling.
|
|
|
|
## Features
|
|
|
|
- **Claude Code** pre-installed with `bypassPermissions` auto-configured and marketplace plugins
|
|
- **Multi-language support**: Python 3.13, Node 22, Rust, Go
|
|
- **Modern CLI tools**: ripgrep, fd, fzf, tmux, git-delta, ast-grep
|
|
- **Session persistence**: command history, GitHub CLI auth, Claude config survive rebuilds
|
|
- **Sandboxing**: bubblewrap and socat for Claude Code sandboxing support
|
|
- **Network isolation**: iptables/ipset with NET_ADMIN capability for restricting outbound traffic
|
|
- **Token forwarding**: `CLAUDE_CODE_OAUTH_TOKEN` and `ANTHROPIC_API_KEY` forwarded to container
|
|
|
|
## Usage
|
|
|
|
Tell Claude to "set up a devcontainer" or "add devcontainer support" in your project.
|
|
|
|
The plugin ships one skill, `devcontainer-setup`, which those phrases trigger. Invoke it
|
|
directly with `/devcontainer-setup:devcontainer-setup`.
|
|
|
|
The skill will:
|
|
1. Detect your project's language stack
|
|
2. Generate `.devcontainer/` configuration files
|
|
3. Provide instructions for starting the container
|
|
|
|
## Generated Files
|
|
|
|
| File | Purpose |
|
|
|------|---------|
|
|
| `Dockerfile` | Container build instructions with Claude Code and dev tools |
|
|
| `devcontainer.json` | VS Code/devcontainer configuration |
|
|
| `post_install.py` | Post-creation setup (permissions, tmux, git config) |
|
|
| `.zshrc` | Shell configuration with history persistence |
|
|
| `install.sh` | CLI helper (`devc` command) for managing containers |
|
|
|
|
## CLI Helper Commands
|
|
|
|
After generating, run `.devcontainer/install.sh self-install` to add the `devc` command:
|
|
|
|
```
|
|
devc . Install template + start container in current directory
|
|
devc up Start the devcontainer
|
|
devc rebuild Rebuild container (preserves persistent volumes)
|
|
devc down Stop the container
|
|
devc shell Open zsh shell in container
|
|
devc exec <cmd> Execute a command in the running container
|
|
devc upgrade Upgrade Claude Code to latest version
|
|
devc mount <h> <c> Add a bind mount to the container
|
|
devc sync Sync sessions from devcontainers to host
|
|
devc cp <c> <h> Copy files from container to host
|
|
devc destroy [-f] Remove container, volumes, and image
|
|
```
|
|
|
|
## Supported Languages
|
|
|
|
| Language | Detection | Configuration |
|
|
|----------|-----------|---------------|
|
|
| Python | `pyproject.toml`, `*.py` | Python 3.13 via uv (in Dockerfile) |
|
|
| Node/TypeScript | `package.json`, `tsconfig.json` | Node 22 via fnm (in Dockerfile) |
|
|
| Rust | `Cargo.toml` | Devcontainer feature |
|
|
| Go | `go.mod` | Devcontainer feature |
|
|
|
|
Multi-language projects automatically get all detected configurations merged.
|
|
|
|
## Security Model
|
|
|
|
The devcontainer provides **filesystem isolation** with **network isolation** capabilities:
|
|
|
|
- Container filesystem is isolated from host
|
|
- `.devcontainer/` mounted read-only inside the container to prevent escape
|
|
- Your `~/.gitconfig` is mounted read-only
|
|
- SYS_ADMIN capability blocked by `devc` CLI to protect read-only mounts
|
|
- Persistent volumes preserve auth across rebuilds
|
|
- iptables/ipset with NET_ADMIN/NET_RAW capabilities for restricting network access
|
|
- NPM security settings: scripts disabled, 24-hour package release delay
|
|
- SSH commit signing supported via `gpg.ssh.program` configuration
|
|
|
|
## Reference Material
|
|
|
|
- `references/dockerfile-best-practices.md` - Docker optimization tips
|
|
- `references/features-vs-dockerfile.md` - When to use features vs Dockerfile
|