217 Commits

Author SHA1 Message Date
Paymahn Moghadasian d560e32095 fix(provider): don't fail the user cache on the session-only edge API
fetchAndStoreUsers always enriched with Slack Connect users, which
rides client.userBoot — a webclient endpoint on the per-workspace
domain that only browser-session tokens can call. With an OAuth token
it always fails, and the error propagated, so the user cache was never
written: every display name stayed unresolved and behind an egress
allowlist the call also logged a 403 per run.

Enrichment now runs only for session tokens. OAuth tokens keep the
users.list result they already fetched.
2026-09-11 10:06:00 -05:00
Paymahn Moghadasian 9c72a44222 fix(provider): classify token kind by source, not prefix
An egress proxy can hand the CLI an opaque sentinel and swap the real
credential onto the wire, so the token value says nothing about the
credential kind. Sniffing `xoxb-`/`xoxp-` prefixes then misread a bot
token as a browser session, which:

  - rebased the standard API onto https://<team>.slack.com/api/
  - routed conversations/users through the edge client (same domain)
  - offered session-only tools (saved items, unreads)

Behind Sinatra's egress proxy every one of those calls was rejected
403 host_not_allowed, since the allowlist only knows slack.com.

tokenKind now derives the kind from which variable supplied the token
(config.Apply exports profile credentials into the same variables) and
only falls back to the prefix. The per-workspace domain is applied to
the standard client for session tokens only — it also silently
overrode GovSlack before.

Verified against a TLS-intercepted fake Slack whose auth.test returns
a team URL: with SLACK_MCP_XOXB_TOKEN=sin_… every request now stays on
slack.com; before the fix conversations.replies and users.info went to
sinatra-dev.slack.com.
2026-09-11 09:10:53 -05:00
Paymahn Moghadasian 272558acc5 fix: send Slack tokens as Authorization bearer headers
slack-go's postForm puts the token in an x-www-form-urlencoded `token`
field and sends no Authorization header. Slack accepts either, but a
body-carried credential is invisible to anything that inspects headers:
Sinatra's egress proxy swaps an opaque `sin_` sentinel for the real bot
token on the way out, saw no header to rewrite, passed the sentinel
through verbatim, and every sandbox call came back `invalid_auth`.

Promote the `token` form field to `Authorization: Bearer` in the shared
HTTP client, so every Web API call authenticates the way brokers, MITM
proxies, and audit tooling expect. Content-Length and GetBody are kept
honest so slack-go's retries replay the rewritten body.

Browser-session tokens (`xoxc-`, paired with the `d` cookie) stay in the
body — they are not bearer credentials and the edge API wants them there.
2026-09-11 08:33:19 -05:00
Paymahn Moghadasian be4d6af80a fix: honour unlisted 1/min history and replies quotas (#5)
Unlisted Slack apps get 1 req/min and 15 msgs/page on
conversations.history and conversations.replies. Wait Retry-After,
cap the page, and share that slot across CLI processes.
2026-09-08 19:54:18 -05:00
Paymahn Moghadasian d781728c6c feat: slack-cli — a no-daemon CLI over the slack-mcp-server engine (#1)
* feat: add slack-cli, a no-daemon CLI over the slack-mcp-server engine

Turn the forked slack-mcp-server into a CLI so running many agents no
longer means one resident MCP process each. Every command is a
short-lived process that reads the shared on-disk cache.

- rename module to github.com/paymog/slack-cli (go install/homebrew/ldflags)
- internal/toolcall: invoke the upstream tool handlers in-process; the only
  mcp-go coupling lives here, so pkg/handler and pkg/provider are reused
  byte-for-byte (clean upstream merges, fork-and-extend)
- internal/{cli,cmds,config,credstore,runtime,output}: cobra command tree,
  keyring-backed credential profiles, provider bootstrap, result printing
- 21 tools as subcommands (channels, conversations, users, usergroups,
  saved, reactions, attachments, cache); write tools keep their env gating
- goreleaser + homebrew release workflow; ships a skills/slack-cli skill
- unit tests for config/credstore/toolcall; MCP server still builds

The MCP server (cmd/slack-mcp-server) is kept intact.

* chore(napkin): record real-workspace verification

* docs: explain how the CLI works (in-process handler invocation, shared cache)
2026-06-26 12:45:38 -05:00
Dmitrii Korotovskii cf0ce0d8f5 Integration tests fix 2026-05-15 00:42:57 +02:00
Dmitrii Korotovskii c88ed62a61 fix: pass ctx to convertMessagesFromHistory calls in saved.go
PR #269 added a leading ctx parameter to convertMessagesFromHistory
but missed the three call sites in saved.go, breaking the build.
2026-05-14 23:09:33 +02:00
Dmitrii Korotovskii 342e3e3cd2 Merge pull request #269 from gkatz2/feature/targeted-user-cache-patch
Add targeted user cache patch on miss
2026-05-14 23:01:12 +02:00
Dmitrii Korotovskii 19e8a0c7b1 test: fix TestIntegrationChannelsListQueryFilter to assert on Name column
The integration test added in #252 was reading row[0], which is the channel
ID column in channels_list CSV output, not the channel name. The CI for
#252 never ran (status checks were empty at merge time), so this slipped
through. Now resolves to the Name column by header lookup, matching the
convention used elsewhere in this file.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-14 22:32:53 +02:00
derodero24 c298e5cf9c feat: extract email metadata from file-type messages
When emails are forwarded to Slack channels, message content is stored in
files[] with filetype "email" rather than in text or blocks. This adds
FilesToText() to extract From, CC, and Subject metadata as a fallback
when msg.Text is empty, so these messages no longer appear as blank rows
in conversations_history output.

Closes #191
2026-05-14 22:27:26 +02:00
George Bashi ae3c7b4f13 perf: remove sort param from channels_me, always use fast path
The sort=popularity option forced fetching every channel the user belongs
to before sorting client-side — hundreds of API calls on large workspaces.
The Slack API doesn't support server-side sorting, so this was inherently
expensive. Remove it and always stop fetching once we have enough results,
using the Slack API's native cursor for pagination.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-05-14 22:20:31 +02:00
George Bashi 6f0114928a perf: stop fetching all API pages in channels_me when not needed
When sort is not "popularity", stop paginating the Slack API as soon as
we have enough results for the requested limit, and pass through the
API's native cursor. On large workspaces this avoids hundreds of API
calls when only a small number of channels are requested.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-05-14 22:20:31 +02:00
George Bashi 55842fe2c8 feat: add channels_me tool
Add a new MCP tool to list channels the calling user is a member of,
using the users.conversations API. Follows the same pattern as
usergroups_me vs usergroups_list.

Unlike channels_list which returns all workspace channels, channels_me
returns only channels the user has joined — useful on large workspaces
where channels_list returns thousands of results.

Supports channel_types, sort (by popularity), limit, and cursor
parameters.
2026-05-14 22:20:31 +02:00
Dmitrii Korotovskii b32ab23eb9 test: update title_with_link expectation after bracket-substitution removal
The test was added by #272 (d3f7ca3) when AttachmentToText still applied
`(` → `[` and `)` → `]` substitutions, which produced `[text][url]` output.
#281 (5c095ac) removed those substitutions, so AttachmentToText now emits
proper markdown `[text](url)`. The test wasn't updated in #281's merge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-14 22:19:20 +02:00
Dmitrii Korotovskii 5c095ac935 Merge pull request #281 from byrmsh/fix/preserve-message-content
fix(text): stop deleting punctuation, emoji, and quotes from messages
2026-05-14 22:12:01 +02:00
Dmitrii Korotovskii c653429517 Merge pull request #272 from tim-watcha/feat/attachment-fields
fix: bot and integration messages silently lose structured content
2026-05-14 22:11:48 +02:00
Dmitrii Korotovskii e49db6aa24 Merge pull request #252 from unsafe9/feature/channels-list-query-filter
feat: add query and query_targets parameters to channels_list tool
2026-05-14 22:11:40 +02:00
Dmitrii Korotovskii 69cd994d9d Merge pull request #240 from jonzarecki/feat/saved-items
feat: add saved_list, saved_update, and saved_clear_completed tools
2026-05-14 22:11:31 +02:00
Dmitrii Korotovskii 60566a196f Merge pull request #225 from flacoste/feat/stale-while-revalidate-cache
feat: stale-while-revalidate cache for large Slack workspaces
2026-05-14 22:10:59 +02:00
Dmitrii Korotovskii 21775f640d Merge pull request #237 from vbichkovsky/feat/native-image-content
feat: return image attachments as native MCP image content
2026-05-14 22:10:26 +02:00
Francis J. Lacoste df22121447 fix: address code review findings from multi-agent analysis
- Fix infinite loop on cold start when API returns zero results: return
  error instead of nil when no existing cache is available, so the
  watcher calls Fatal rather than spinning IsReady() forever
- Secure temp file handling: use os.CreateTemp for unpredictable names
  (prevents symlink attacks) and clean up temp files on any failure
- Restrict cache file permissions from 0644 to 0600 and cache directory
  from 0755 to 0700 (cache contains user PII)
- Extract atomicWriteFile helper to deduplicate temp+rename pattern
- Fix stale docstring: getCacheTTL default is 24h not 1h

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-05-14 21:44:44 +02:00
Francis J. Lacoste 6e93a40174 fix: address PR #225 review feedback for SWR cache
- Restore IsReady() polling loop before ServeStdio() to fix cold-start
  regression where tool calls fail for 60-90s on first run (no cache)
- Add fetchUsersMu/fetchChannelsMu mutexes to serialize fetchAndStore*
  calls, preventing race between ForceRefresh and background refresh
- Use atomic file writes (temp + os.Rename) to prevent corrupt cache
  files on crash
- Guard against empty API results overwriting valid cache
- Guard against empty cache files being treated as valid data
- Fix typo: TestRefreshingFlagPreventsConucrrentRefreshes → Concurrent

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-05-14 21:44:44 +02:00
Francis J. Lacoste f16fb0fe2b feat: stale-while-revalidate cache for large Slack workspaces
On large workspaces (41K+ users), the server blocks for ~90 seconds
during startup while fetching all users/channels from the Slack API,
exceeding MCP client connection timeouts.

Changes:
- Load expired cache files immediately, mark server ready, then refresh
  in background via goroutine (stale-while-revalidate pattern)
- Convert usersReady/channelsReady to atomic.Bool for race-free reads
- Add refreshingUsers/refreshingChannels atomic.Bool to coalesce
  concurrent background refreshes via CompareAndSwap
- Remove stdio IsReady() polling loop (no longer needed)
- Increase default cache TTL from 1h to 24h
- Document SLACK_MCP_CACHE_TTL and SLACK_MCP_MIN_REFRESH_INTERVAL
  env vars in docs/03-configuration-and-usage.md

Fixes startup timeout on large workspaces. Server now starts in under
1 second regardless of workspace size when a cache file exists.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-05-14 21:44:44 +02:00
tim-watcha d3f7ca3a4a fix: include attachment TitleLink in message text output
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-05-14 21:34:18 +02:00
tim-watcha d9213df8f9 fix: include attachment Fields in message text output
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-05-14 21:34:17 +02:00
Greg Katz 2d19f8c752 Add targeted user cache patch on miss
When a user ID is not in the in-memory cache, message rendering
degrades to raw IDs and paramFormatUser fails the tool call
entirely. This is common on Enterprise Grid workspaces where the
user cache (50K+ users) can be hours stale.

On cache miss, fetch the single user via users.info and patch the
snapshot atomically. This costs one API call instead of rebuilding
the entire user cache. Disk persistence is skipped; the next full
refresh cycle handles it.

Fixes #268

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-05-14 12:03:17 -07:00
Dmitrii Korotovskii 29a73b191a Merge pull request #294 from arnstarn/feat/blocks-and-dep-bump
feat: add blocks parameter and bump slack-go-util to v0.4.0
2026-05-14 21:03:14 +02:00
Dmitrii Korotovskii 5cb7c2c12c Merge pull request #190 from derodero24/feat/extract-block-kit-text
feat: extract text content from message blocks in conversations_history
2026-05-14 21:02:19 +02:00
Dmitrii Korotovskii 9e9f84cfba Merge pull request #219 from georgebashi/feat/conversations-join-leave
feat: add conversations_join and conversations_leave tools
2026-05-14 20:47:36 +02:00
Dmitrii Korotovskii 5e72c6bb91 Merge pull request #263 from Christian-Sidak/feat/users-search-by-id
feat: support direct user ID lookup in users_search
2026-05-14 20:47:31 +02:00
Dmitrii Korotovskii 262f0bc78e Merge pull request #279 from bkbaheti/fix/include-file-names-in-attachment-ids
Include file names in AttachmentIDs for message responses
2026-05-14 20:47:26 +02:00
Dmitrii Korotovskii 78005d34da Merge pull request #284 from clwluvw/slack-add-msg
fix: return plain confirmation from conversations_add_message
2026-05-14 20:47:21 +02:00
Dmitrii Korotovskii 5690a6a3ab Merge pull request #297 from aharon-br/master
fix: handle Slack refresh token format (xoxe)
2026-05-14 20:47:17 +02:00
Dmitrii Korotovskii 8c4614ccda Merge pull request #262 from flacoste/fix/search-rate-limit-retry
fix: add rate limiting and retry to SearchContext
2026-05-14 20:46:32 +02:00
Dmitrii Korotovskii d753982209 Merge pull request #265 from tmastny/tim/add-permalink-and-channel-id
Include channel ID and permalink in search results
2026-05-14 20:46:27 +02:00
Harry Richman a851750aaa Update api.go
re https://github.com/korotovsky/slack-mcp-server/issues/115
2026-05-13 16:25:14 +01:00
Arnold Mendez 97b24505c9 feat: add blocks parameter and bump slack-go-util to v0.4.0
Add optional `blocks` parameter to conversations_add_message for raw
Slack Block Kit JSON support (rich_text lists, code blocks, etc.).

When blocks is provided it takes precedence over text/content_type for
message rendering. The text parameter serves as notification fallback.

The blocks argument accepts both a JSON string and a raw JSON array to
accommodate different MCP client serialization behaviors.

Also bumps takara2314/slack-go-util from v0.3.0 to v0.4.0 which adds
nested list support to the existing text/markdown conversion path.
2026-05-07 10:10:53 -04:00
Seena Fallah 2cfccba8ca fix: return plain confirmation from conversations_add_message
The handler was re-fetching the just-posted message via conversations.history
and returning it as CSV. Slack's history endpoint has propagation lag, so when
the message wasn't yet indexed the response was a header-only CSV with no data
rows, which confused LLM clients into thinking the post had failed.

Drop the follow-up history call and return a short success string with channel
and ts (matching ReactionsAddHandler). This removes the race entirely and
saves a tier3 API call per post.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
2026-04-26 22:01:25 +02:00
Bayram Şahin 2666c0f8e3 fix(text): preserve ZWJ/ZWNJ so emoji sequences and non-Latin scripts survive 2026-04-18 21:09:29 +03:00
Bayram Şahin 90905ebc33 test(text): exercise normalizeLinks in 12-link regression case 2026-04-18 00:29:28 +03:00
Bayram Şahin 6dd2feb887 fix(text): preserve message content; drop vestigial char allow-list 2026-04-18 00:18:10 +03:00
Braj Baheti cf81046419 Include file names alongside file IDs in AttachmentIDs field
Previously, the AttachmentIDs field only contained raw file IDs
(e.g. "F08ABC1234"), making it impossible to identify which file
an ID corresponds to without calling attachment_get_data first.

Now the field includes filenames: "F08ABC1234 (contract.pdf)".
This makes it practical to use AttachmentIDs to selectively
download relevant attachments.

Fixes #260
2026-04-15 20:46:05 +05:30
Mustafa Mujahid 8256b2f343 fix: non-blocking stdio startup and --no-cache flag
Remove the busy-wait loop that blocks the stdio transport from
responding to MCP initialize until users/channels caches are fully
loaded. On large workspaces this causes MCP clients with connection
timeouts (e.g. 30-60s) to drop the server.

Changes:
- stdio transport now starts the MCP server immediately, matching the
  existing SSE/HTTP behavior. Caches continue loading in a background
  goroutine. Tool calls made before caches are ready return a graceful
  "not ready" error (already handled by the error recovery middleware).
- Add --no-cache CLI flag to skip cache loading entirely for
  environments that only use channel/user IDs (never #name or @name
  lookups). This makes startup instant regardless of workspace size.
- Add SkipCache() method on ApiProvider that marks both caches as
  ready without loading data.

Fixes #271
2026-04-10 15:39:36 +02:00
Tim Mastny 6c90a87c29 Add channel ID and permalink to search results
The Slack search API returns both Channel.ID and Permalink on every
SearchMessage, but the MCP server was only using Channel.Name (formatted
as '#channel-name') and discarding the rest. This made it impossible for
LLM agents to construct valid Slack permalink URLs.

- Add Permalink field to Message struct
- Include msg.Channel.ID in the Channel column (format: 'C0515UGHR0R (#channel-name)')
- Pass through msg.Permalink from the Slack API response

Addresses korotovsky/slack-mcp-server#100.
2026-03-29 20:03:15 -05:00
32134178csa 869899c18e feat: support direct user ID lookup in users_search tool
When the query matches a Slack user ID pattern (e.g., U07VCEPP4N5),
use the users.info API for direct lookup instead of searching by
name/email/display name. This is useful when you already have a
user ID (from message metadata, mentions, etc.) and need to resolve
it to user details.

Falls back to existing search behavior for non-ID queries.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-27 20:42:23 -07:00
Francis J. Lacoste 68afbcc541 fix: add rate limiting and retry to SearchContext
SearchContext was the only Slack API call in conversations.go without
rate limiting or retry logic. Under concurrent load (e.g. parallel
searches across multiple workspaces), this caused immediate failures
when hitting Slack's Tier 2 rate limits.

Wrap the call with limiter.CallWithRetry using a Tier2 rate limiter,
matching the established pattern used by GetConversationHistoryContext
and GetConversationInfoContext in the same file.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-27 20:59:56 -04:00
unsafe9 4d7d872310 test: verify non-matching channels are excluded from query results 2026-03-25 10:31:13 +09:00
unsafe9 ab1cb7d1a1 refactor: align query_targets parsing with channel_types pattern
Use map[string]bool instead of struct, parse inline in handler with
warn logging for invalid values, matching filterChannelsByTypes style.
2026-03-25 01:05:16 +09:00
unsafe9 06fa3b1931 feat: add query and query_targets parameters to channels_list tool
Closes #251. Adds keyword filtering to channels_list so users can find
channels without paginating through the entire list. Matches are
case-insensitive substrings; query_targets controls which fields to
search (name by default, optionally topic and purpose).
2026-03-25 00:51:57 +09:00
Valentin eb4d63b944 feat: return image attachments as native MCP image content
Previously, attachment_get_data returned image files as base64-encoded
strings inside a JSON text response. For typical images (100-200KB),
the base64 expansion produces 130-270KB of text that exceeds MCP client
token limits, forcing clients to save overflow to temp files and manually
decode base64 — defeating the purpose of the tool.

Use the MCP SDK's NewToolResultImage to return images as native image
content, which MCP clients can render directly. File metadata (file_id,
filename, mimetype, size) is returned as the text component. Non-image
binary files retain the existing base64-in-text behavior.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 15:17:01 +01:00