skills/paymog__slack-cli
1
0
Fork 0
mirror of https://github.com/paymog/slack-cli.git synced 2026-09-18 23:43:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: fix TestIntegrationChannelsListQueryFilter to assert on Name column

Browse Source 
The integration test added in #252 was reading row[0], which is the channel
ID column in channels_list CSV output, not the channel name. The CI for
#252 never ran (status checks were empty at merge time), so this slipped
through. Now resolves to the Name column by header lookup, matching the
convention used elsewhere in this file.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Dmitrii Korotovskii
2026-05-14 22:32:53 +02:00
parent 2e2c4b5e92
commit 19e8a0c7b1
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/handler/channels_test.go
+16 -4
View File
@@ -163,13 +163,25 @@ func TestIntegrationChannelsListQueryFilter(t *testing.T) {
reader := csv.NewReader(strings.NewReader(toolOutput.String()))
rows, err := reader.ReadAll()
require.NoError(t, err, "Failed to parse CSV")
require.GreaterOrEqual(t, len(rows), 1, "CSV must have at least a header row")
nameIdx := -1
for i, col := range rows[0] {
if col == "Name" {
nameIdx = i
break
}
}
require.NotEqualf(t, -1, nameIdx, "CSV did not contain Name column; header: %v", rows[0])
dataRows := rows[1:]
for _, row := range dataRows {
assert.Containsf(t, strings.ToLower(row[0]), "testcase",
"Expected all results to match query 'testcase', got: %s", row[0])
assert.NotContainsf(t, strings.ToLower(row[0]), "general",
"Expected #general to be filtered out, but found: %s", row[0])
require.Less(t, nameIdx, len(row), "row shorter than Name column index")
name := strings.ToLower(row[nameIdx])
assert.Containsf(t, name, "testcase",
"Expected all results to match query 'testcase', got: %s", row[nameIdx])
assert.NotContainsf(t, name, "general",
"Expected #general to be filtered out, but found: %s", row[nameIdx])
}
assert.GreaterOrEqual(t, len(dataRows), 3, "Expected at least testcase-1, testcase-2, testcase-3")
}