mirror of
https://github.com/max-sixty/worktrunk.git
synced 2026-09-14 20:00:38 +08:00
fix(skill): enforce reproduction test gate in triage-issue Step 6 (#1477)
This commit is contained in:
@@ -87,15 +87,24 @@ Record what you found (or didn't find) for use in step 7.
|
||||
If the test passes (bug may already be fixed), note this for the comment.
|
||||
|
||||
If you cannot reproduce the bug (unclear steps, environment-specific, etc.),
|
||||
note what you tried and skip to step 7.
|
||||
note what you tried and skip to step 7. Do NOT proceed to Step 6 without a
|
||||
failing test — a fix without reproduction evidence is not a conservative fix.
|
||||
|
||||
## Step 6: Fix (conservative)
|
||||
|
||||
*Bug reports only.*
|
||||
|
||||
**CRITICAL — gate check before proceeding:**
|
||||
|
||||
You MUST have a failing test from Step 5 before writing any fix. If you skipped
|
||||
the test (couldn't write one, environment-specific bug, etc.), do NOT attempt a
|
||||
fix — go directly to Step 7 and use the "Reproduction test only" or "Could not
|
||||
reproduce" comment template. A fix without a reproduction test violates the AD
|
||||
FONTES principle established in Step 1.
|
||||
|
||||
**Only attempt a fix if ALL of these conditions are met:**
|
||||
|
||||
- Bug is clearly reproducible (test fails)
|
||||
- Bug is clearly reproducible (test written in Step 5 fails)
|
||||
- Root cause is understood
|
||||
- Fix is localized (1-3 files changed)
|
||||
- Confident the fix is correct
|
||||
|
||||
Reference in New Issue
Block a user