skills/langfuse__skills
1
0
Fork 0
mirror of https://github.com/langfuse/skills.git synced 2026-09-14 20:00:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com>
This commit is contained in:
Hassieb Pakzad
2026-08-20 18:40:07 +02:00
committed by GitHub
parent c527ffae3f
commit 2d4c20edf3
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
skills/langfuse/references/sdk-upgrade.md
-3
View File
@@ -28,10 +28,7 @@ Follow every intermediate guide when the installed version is more than one majo
2. Find every source of correlating attributes, including `session_id`/`sessionId`, `user_id`/`userId`, tags, metadata, version, environment, and trace name. Search for the values and surrounding application concepts, not only removed SDK method names.
3. Apply every relevant item from the exact version-specific guides. Preserve each correlating attribute by establishing its documented propagation scope before any observation-producing call that must inherit it.
4. For sessions, propagate the session ID early enough that the root and every applicable child observation—including cost-bearing generations—receive the same value. For work crossing service boundaries, follow the current distributed-tracing and baggage guidance rather than assuming in-process context crosses the boundary.
5. Run focused format, type, lint, and test checks, then exercise each changed ingestion path with representative application behavior.
6. Fetch the emitted trace and verify the expected correlating attributes on the root and every applicable child observation. For a session path, also confirm the observations are grouped into the intended session and its cost includes the cost-bearing children.
Do not mark the upgrade ready when only dependency or compile-time checks passed. If runtime execution or trace inspection is unavailable, report the exact verification as blocked.
## Completion report
skills/langfuse/references/v4-project-migration.md
+1 -1
View File
@@ -69,7 +69,7 @@ Discover unstable schemas before use.
- Test applicable hierarchy, root input/output, propagated attributes, public/release/environment behavior, API pagination and parsing, delivery semantics, and absence of deprecated calls.
- Before production cutover, send representative traces from the migrated instrumentation to a non-production Langfuse project and inspect the resulting observations there. Mocked tests do not verify backend ingestion or project behavior.
- On a session path, confirm the root and every applicable child observation carry the intended session ID and that session cost includes the cost-bearing children. Keep SDK/instrumentation readiness blocked when emitted-trace inspection is unavailable.
- On a session path, confirm the root and every applicable child observation carry the intended session ID and that session cost includes the cost-bearing children.
- Re-read rules and integrations after writes. Preserve disabled legacy rules for rollback; never claim completion without checking the Evaluators UI on the target host for legacy rows.
- The readiness report must contain exactly these seven rows, each marked `ready`, `changed`, `manual action`, or `blocked`: project access; SDK/instrumentation; trace evaluators; dataset evaluators; direct APIs; exports; verification/rollback.
- In evaluator rows, separate contracts verified against project data from targets suggested only by code inspection. For every row not marked `ready`, include the blocker, next action, and a direct UI link when applicable.