skills/dotnet__skills
1
0
Fork 0
mirror of https://github.com/dotnet/skills.git synced 2026-09-20 09:49:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove LangVersion=latest from skill examples and test fixtures (#608)

Browse Source 
* Initial plan

* Remove LangVersion=latest from skill docs and test fixtures

Per official C# docs, LangVersion should not be set to `latest` as
it causes builds to silently vary across machines with different SDKs.
Best practice is to omit LangVersion entirely and let the TFM determine
the correct C# version automatically.

- Update msbuild-modernization/SKILL.md: remove LangVersion=latest from
  example and add explicit guidance to omit LangVersion
- Update directory-build-organization/SKILL.md: remove from example
- Update directory-build-organization/references/multi-level-examples.md:
  remove from all 4 examples
- Update msbuild-antipatterns/SKILL.md: remove from AP-08 examples
- Remove LangVersion=latest from 11 test fixture project files

Agent-Logs-Url: https://github.com/dotnet/skills/sessions/7a3d2722-770b-4010-a6e8-70c92668ad4c

Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com>

* Fix LangVersion guidance and stale eval rubric reference

Agent-Logs-Url: https://github.com/dotnet/skills/sessions/e89afcd8-7227-424b-9c8c-9ec0ce7113c2

Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com>
This commit is contained in:
Copilot
2026-05-05 15:45:56 +02:00
committed by GitHub
parent 2633d3d482
commit 2f9922e073
18 changed files with 2 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/dotnet-msbuild/skills/directory-build-organization/SKILL.md
-1
View File
@@ -41,7 +41,6 @@ Good candidates: language settings, assembly/package metadata, build warnings, c
```xml
<Project>
<PropertyGroup>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
plugins/dotnet-msbuild/skills/directory-build-organization/references/multi-level-examples.md
-4
View File
@@ -8,7 +8,6 @@ Full file examples for a typical multi-level repo layout.
<Project>
<PropertyGroup>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
@@ -65,7 +64,6 @@ Full file examples for a typical multi-level repo layout.
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
@@ -85,7 +83,6 @@ Full file examples for a typical multi-level repo layout.
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
@@ -108,7 +105,6 @@ Full file examples for a typical multi-level repo layout.
<Project>
<PropertyGroup>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
plugins/dotnet-msbuild/skills/msbuild-antipatterns/SKILL.md
-2
View File
@@ -201,7 +201,6 @@ See [`references/private-assets.md`](references/private-assets.md) for BAD/GOOD
<!-- BAD: Repeated in every .csproj -->
<!-- ProjectA.csproj, ProjectB.csproj, ProjectC.csproj all have: -->
<PropertyGroup>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<ImplicitUsings>enable</ImplicitUsings>
@@ -211,7 +210,6 @@ See [`references/private-assets.md`](references/private-assets.md) for BAD/GOOD
<!-- Directory.Build.props -->
<Project>
<PropertyGroup>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<ImplicitUsings>enable</ImplicitUsings>
plugins/dotnet-msbuild/skills/msbuild-modernization/SKILL.md
+1 -2
View File
@@ -282,13 +282,12 @@ After migration, consider enabling modern C# features:
<TargetFramework>net8.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<LangVersion>latest</LangVersion>
</PropertyGroup>
```
- `<Nullable>enable</Nullable>` — enables nullable reference type analysis
- `<ImplicitUsings>enable</ImplicitUsings>` — auto-imports common namespaces (.NET 6+)
- `<LangVersion>latest</LangVersion>` — uses the latest C# language version (or specify e.g. `12.0`)
- **Avoid `<LangVersion>latest`** — the effective language version is determined by the SDK/compiler defaults, not just the TFM, so builds can silently vary across machines with different SDKs installed. Omit `<LangVersion>` unless you need to pin a specific version. For reproducible builds, pin the SDK version repo-wide with `global.json` (which indirectly fixes the default language version), or set an explicit numeric `<LangVersion>` (e.g. `<LangVersion>12</LangVersion>`) per project to directly control the language version.
## Complete Before/After Example
tests/dotnet-experimental/exp-test-tagging/fixtures/mstest-untagged/OrderService.Tests/OrderService.Tests.csproj
-1
View File
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<LangVersion>latest</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="MSTest" Version="3.8.0" />
tests/dotnet-experimental/exp-test-tagging/fixtures/mstest-untagged/OrderService/OrderService.csproj
-1
View File
@@ -1,6 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<LangVersion>latest</LangVersion>
</PropertyGroup>
</Project>
tests/dotnet-experimental/exp-test-tagging/fixtures/nunit-untagged/OrderService.Tests/OrderService.Tests.csproj
-1
View File
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<LangVersion>latest</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="NUnit" Version="4.3.2" />
tests/dotnet-experimental/exp-test-tagging/fixtures/nunit-untagged/OrderService/OrderService.csproj
-1
View File
@@ -1,6 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<LangVersion>latest</LangVersion>
</PropertyGroup>
</Project>
tests/dotnet-experimental/exp-test-tagging/fixtures/xunit-untagged/OrderService.Tests/OrderService.Tests.csproj
-1
View File
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<LangVersion>latest</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="xunit.v3" Version="2.0.0" />
tests/dotnet-experimental/exp-test-tagging/fixtures/xunit-untagged/OrderService/OrderService.csproj
-1
View File
@@ -1,6 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<LangVersion>latest</LangVersion>
</PropertyGroup>
</Project>
tests/dotnet-msbuild/directory-build-organization/src/ContosoApp.Api/ContosoApp.Api.csproj
-1
View File
@@ -2,7 +2,6 @@
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
tests/dotnet-msbuild/directory-build-organization/src/ContosoApp.Core/ContosoApp.Core.csproj
-1
View File
@@ -2,7 +2,6 @@
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
tests/dotnet-msbuild/directory-build-organization/src/ContosoApp.Services/ContosoApp.Services.csproj
-1
View File
@@ -2,7 +2,6 @@
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
tests/dotnet-msbuild/directory-build-organization/test/ContosoApp.Api.Tests/ContosoApp.Api.Tests.csproj
-1
View File
@@ -2,7 +2,6 @@
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
tests/dotnet-msbuild/directory-build-organization/test/ContosoApp.Core.Tests/ContosoApp.Core.Tests.csproj
-1
View File
@@ -2,7 +2,6 @@
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
tests/dotnet-msbuild/msbuild-antipatterns/Directory.Build.props
-1
View File
@@ -1,6 +1,5 @@
<Project>
<PropertyGroup>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>
tests/dotnet-nuget/convert-to-cpm/advanced-multi-complexity/Directory.Build.props
-1
View File
@@ -1,6 +1,5 @@
<Project>
<PropertyGroup>
<LangVersion>latest</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<BlobsVersion>12.24.0</BlobsVersion>
<HostingVersion>8.0.1</HostingVersion>
tests/dotnet-nuget/convert-to-cpm/eval.yaml
+1 -1
View File
@@ -185,7 +185,7 @@ scenarios:
- "Identified the PackageReference in Common.props that applies to all projects"
- "Presented the findings and applied the user's chosen strategy of using the highest version for conflicts and inlining MSBuild property values"
- "Created Directory.Packages.props reflecting the user's directed resolution strategy"
- "Preserved non-version properties (LangVersion, ImplicitUsings) in Directory.Build.props"
- "Preserved non-version properties (ImplicitUsings) in Directory.Build.props"
- "Ran dotnet restore and dotnet build to validate the conversion"
- "Produced a markdown report summarizing all package references, resolved versions, and decisions across projects, comparing baseline state against the CPM result"
- "Guided the user through reconciliation or explicit acceptance of each differing version, including version conflicts, property-based versions, and conditional references"