mirror of
https://github.com/CharlesWiltgen/Axiom.git
synced 2026-09-20 19:58:20 +08:00
fix(axiom-media): unblock a quoted Objective-C constant, and a search that could not match
Two defects found by reviewing the previous round's own output. `carplay-navigation-ref.md` quotes the guide's lane-guidance instructions, which are written against the Objective-C API: "return a symbol style of CPManeuverDisplayStyleSymbolOnly for the maneuver." The quote is faithful, but that constant has no Swift spelling — the Swift form is `.symbolOnly` — so a reader copying it out of a verbatim quote gets a compile error. The quote stays as the guide wrote it; the Swift spelling is now noted beside it. `camera-auditor`'s Pattern 2 search list included `UIDeviceOrientationDidChangeNotification`, which does not exist in Swift at all. As a text search it matched only legacy Objective-C-style code, so it could never fire on a modern app — the same dead-detection-pattern class as the interruption names corrected earlier, and missed by every previous round. The replacement is checked against a three-file fixture: the old pattern matched only the legacy file, the new one matches both spellings, and neither matches the control. Cursor, Codex, inlined-auditor and MCP distributions regenerated. Verified: npm test (static validation clean).
This commit is contained in:
@@ -161,7 +161,7 @@ Run all 11 detection patterns. For every grep match, use Read to verify the surr
|
||||
- `\.videoOrientation\s*=`
|
||||
- `connection\?\.videoOrientation`
|
||||
- `UIDevice\.current\.orientation` near capture code
|
||||
- `UIDeviceOrientationDidChangeNotification` paired with capture
|
||||
- `[Oo]rientationDidChangeNotification` paired with capture
|
||||
**Verify**: Read matching files; on iOS 17+ deployment, `RotationCoordinator` is the right answer.
|
||||
**Fix**: `let coordinator = AVCaptureDevice.RotationCoordinator(device: device, previewLayer: previewLayer)`; observe `videoRotationAngleForHorizonLevelCapture`/`...Preview` via KVO.
|
||||
|
||||
|
||||
@@ -133,7 +133,7 @@ Run all 11 detection patterns. For every grep match, use Read to verify the surr
|
||||
- `\.videoOrientation\s*=`
|
||||
- `connection\?\.videoOrientation`
|
||||
- `UIDevice\.current\.orientation` near capture code
|
||||
- `UIDeviceOrientationDidChangeNotification` paired with capture
|
||||
- `[Oo]rientationDidChangeNotification` paired with capture
|
||||
**Verify**: Read matching files; on iOS 17+ deployment, `RotationCoordinator` is the right answer.
|
||||
**Fix**: `let coordinator = AVCaptureDevice.RotationCoordinator(device: device, previewLayer: previewLayer)`; observe `videoRotationAngleForHorizonLevelCapture`/`...Preview` via KVO.
|
||||
|
||||
|
||||
@@ -265,7 +265,7 @@ Source: *Developer Guide* p.46.
|
||||
|
||||
"If your app provides lane guidance information, you must use the second maneuver to show lane guidance. Create a second maneuver containing `symbolSet` with dark and light images that occupy the full width of the guidance panel (**maximum size 120pt × 18pt**), provide an empty array for `instructionVariants`, and in the `CPMapTemplateDelegate`, return a symbol style of `CPManeuverDisplayStyleSymbolOnly` for the maneuver."
|
||||
|
||||
Source: *Developer Guide* p.47.
|
||||
Source: *Developer Guide* p.47. The guide is written against the Objective-C API; in Swift that constant is spelled `.symbolOnly`.
|
||||
|
||||
### Estimate updates
|
||||
|
||||
|
||||
+1
-1
@@ -132,7 +132,7 @@ Run all 11 detection patterns. For every grep match, use Read to verify the surr
|
||||
- `\.videoOrientation\s*=`
|
||||
- `connection\?\.videoOrientation`
|
||||
- `UIDevice\.current\.orientation` near capture code
|
||||
- `UIDeviceOrientationDidChangeNotification` paired with capture
|
||||
- `[Oo]rientationDidChangeNotification` paired with capture
|
||||
**Verify**: Read matching files; on iOS 17+ deployment, `RotationCoordinator` is the right answer.
|
||||
**Fix**: `let coordinator = AVCaptureDevice.RotationCoordinator(device: device, previewLayer: previewLayer)`; observe `videoRotationAngleForHorizonLevelCapture`/`...Preview` via KVO.
|
||||
|
||||
|
||||
@@ -265,7 +265,7 @@ Source: *Developer Guide* p.46.
|
||||
|
||||
"If your app provides lane guidance information, you must use the second maneuver to show lane guidance. Create a second maneuver containing `symbolSet` with dark and light images that occupy the full width of the guidance panel (**maximum size 120pt × 18pt**), provide an empty array for `instructionVariants`, and in the `CPMapTemplateDelegate`, return a symbol style of `CPManeuverDisplayStyleSymbolOnly` for the maneuver."
|
||||
|
||||
Source: *Developer Guide* p.47.
|
||||
Source: *Developer Guide* p.47. The guide is written against the Objective-C API; in Swift that constant is spelled `.symbolOnly`.
|
||||
|
||||
### Estimate updates
|
||||
|
||||
|
||||
Generated
+1
-1
@@ -140,7 +140,7 @@ Run all 11 detection patterns. For every grep match, use Read to verify the surr
|
||||
- `\.videoOrientation\s*=`
|
||||
- `connection\?\.videoOrientation`
|
||||
- `UIDevice\.current\.orientation` near capture code
|
||||
- `UIDeviceOrientationDidChangeNotification` paired with capture
|
||||
- `[Oo]rientationDidChangeNotification` paired with capture
|
||||
**Verify**: Read matching files; on iOS 17+ deployment, `RotationCoordinator` is the right answer.
|
||||
**Fix**: `let coordinator = AVCaptureDevice.RotationCoordinator(device: device, previewLayer: previewLayer)`; observe `videoRotationAngleForHorizonLevelCapture`/`...Preview` via KVO.
|
||||
|
||||
|
||||
+5
-5
@@ -28,8 +28,8 @@
|
||||
},
|
||||
{
|
||||
"path": "agents/camera-auditor.md",
|
||||
"sha256": "a79941cdb5048c97a1a7fa4428d23ede992101f723971ae7f1cfdbdd83e048dc",
|
||||
"bytes": 25887
|
||||
"sha256": "ee268654f12d90d124fa704f0a82898528692e93fd2ec4c3e59b7105e87f778e",
|
||||
"bytes": 25882
|
||||
},
|
||||
{
|
||||
"path": "agents/codable-auditor.md",
|
||||
@@ -1168,8 +1168,8 @@
|
||||
},
|
||||
{
|
||||
"path": "skills/axiom-media/skills/carplay-navigation-ref.md",
|
||||
"sha256": "579a93ad8621628d7bd57daddd0df0f70e2fbed0a9d50972581e98dd8aa0769f",
|
||||
"bytes": 34680
|
||||
"sha256": "194258873a6a3fe6c4bb20237c6123437a79baaf51b0d0e83de6e4efa3b4c984",
|
||||
"bytes": 34779
|
||||
},
|
||||
{
|
||||
"path": "skills/axiom-media/skills/carplay-templates-ref.md",
|
||||
@@ -1879,7 +1879,7 @@
|
||||
],
|
||||
"totals": {
|
||||
"files": 375,
|
||||
"bytes": 7514190
|
||||
"bytes": 7514284
|
||||
},
|
||||
"excludedMirrors": 30,
|
||||
"classes": {
|
||||
|
||||
@@ -265,7 +265,7 @@ Source: *Developer Guide* p.46.
|
||||
|
||||
"If your app provides lane guidance information, you must use the second maneuver to show lane guidance. Create a second maneuver containing `symbolSet` with dark and light images that occupy the full width of the guidance panel (**maximum size 120pt × 18pt**), provide an empty array for `instructionVariants`, and in the `CPMapTemplateDelegate`, return a symbol style of `CPManeuverDisplayStyleSymbolOnly` for the maneuver."
|
||||
|
||||
Source: *Developer Guide* p.47.
|
||||
Source: *Developer Guide* p.47. The guide is written against the Objective-C API; in Swift that constant is spelled `.symbolOnly`.
|
||||
|
||||
### Estimate updates
|
||||
|
||||
|
||||
Vendored
+5
-5
@@ -1,8 +1,8 @@
|
||||
{
|
||||
"totalBytes": 13664515,
|
||||
"totalBytes": 13664699,
|
||||
"skills": {
|
||||
"count": 303,
|
||||
"bytes": 7469068
|
||||
"bytes": 7469167
|
||||
},
|
||||
"commands": {
|
||||
"count": 17,
|
||||
@@ -10,10 +10,10 @@
|
||||
},
|
||||
"agents": {
|
||||
"count": 42,
|
||||
"bytes": 696391
|
||||
"bytes": 696386
|
||||
},
|
||||
"searchIndex": {
|
||||
"bytes": 5450747
|
||||
"bytes": 5450837
|
||||
},
|
||||
"generatedAt": "2026-09-17T17:08:55.521Z"
|
||||
"generatedAt": "2026-09-17T17:15:23.704Z"
|
||||
}
|
||||
Vendored
+23
-13
File diff suppressed because one or more lines are too long
Reference in New Issue
Block a user