skills/botpress__skills
1
0
Fork 0
mirror of https://github.com/botpress/skills.git synced 2026-09-19 05:20:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: address Greptile review feedback

Browse Source 
- Use mktemp instead of hardcoded tmp.json in sync-versions.sh
- Add push trigger for master/dev in validate-version.yml
- Replace npx semver with bash regex for semver validation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Augusto M.P
2026-05-27 18:27:39 -04:00
parent a1dd75ddb1
commit e74555ac46
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/validate-version.yml
+8 -1
View File
@@ -8,6 +8,13 @@ on:
- "commands/**"
- ".claude-plugin/**"
- "scripts/sync-versions.sh"
push:
branches:
- master
- dev
paths:
- "skills.json"
- ".claude-plugin/**"
jobs:
validate:
@@ -28,7 +35,7 @@ jobs:
exit 1
fi
if ! npx --yes semver "$VERSION" > /dev/null 2>&1; then
if ! [[ "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9.]+)?(\+[a-zA-Z0-9.]+)?$ ]]; then
echo "::error::adk-version '$VERSION' is not valid semver"
exit 1
fi
scripts/sync-versions.sh
+5 -2
View File
@@ -10,7 +10,10 @@ if [[ -z "$VERSION" || "$VERSION" == "null" ]]; then
exit 1
fi
jq --arg v "$VERSION" '.version = $v' .claude-plugin/plugin.json > tmp.json && mv tmp.json .claude-plugin/plugin.json
jq --arg v "$VERSION" '.plugins[0].version = $v' .claude-plugin/marketplace.json > tmp.json && mv tmp.json .claude-plugin/marketplace.json
TMPFILE=$(mktemp)
trap 'rm -f "$TMPFILE"' EXIT
jq --arg v "$VERSION" '.version = $v' .claude-plugin/plugin.json > "$TMPFILE" && mv "$TMPFILE" .claude-plugin/plugin.json
jq --arg v "$VERSION" '.plugins[0].version = $v' .claude-plugin/marketplace.json > "$TMPFILE" && mv "$TMPFILE" .claude-plugin/marketplace.json
echo "Synced version $VERSION to plugin.json and marketplace.json"