skills/backnotprop__plannotator
1
0
Fork 0
mirror of https://github.com/backnotprop/plannotator.git synced 2026-09-14 14:17:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): give the unknown-subcommand e2e spawn its dist placeholders on CI

Browse Source 
The e2e case from #1444 spawns the real CLI, whose module load imports
../dist/index.html and ../dist/review.html. Dev machines always have
those built, but CI's test job does not build the apps, so the spawn
died at import time with 'Cannot find module' before the guard ran and
the assertion on the unknown-command message failed, breaking main.

The test now drops empty placeholders for any missing artifact before
spawning and removes exactly what it created afterwards; a real dist is
never touched (verified with sentinel content). The guard under test
exits before either page is served, so placeholder content is
irrelevant.
This commit is contained in:
Michael Ramos
2026-09-01 10:22:33 -07:00
parent 58017a03c7
commit 9682a05556
1 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/hook/server/unknown-subcommand.test.ts
+25 -1
View File
@@ -1,5 +1,5 @@
import { describe, expect, test } from "bun:test";
import { readFileSync } from "node:fs";
import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
import { resolve } from "node:path";
import {
findClosestSubcommand,
@@ -49,6 +49,26 @@ describe("unknown subcommand", () => {
});
test("a typo'd subcommand exits instead of blocking on an open stdin", async () => {
// The spawned CLI imports ../dist/{index,review}.html at module load.
// Dev machines always have them built, but CI's test job does not build
// the apps, so drop empty placeholders for any missing artifact and
// remove exactly what this test created afterwards. The guard under test
// exits before either page is ever served, so content is irrelevant.
const distDir = resolve(import.meta.dir, "../dist");
const created: string[] = [];
let createdDir = false;
if (!existsSync(distDir)) {
mkdirSync(distDir, { recursive: true });
createdDir = true;
}
for (const name of ["index.html", "review.html"]) {
const file = resolve(distDir, name);
if (!existsSync(file)) {
writeFileSync(file, "<!doctype html>");
created.push(file);
}
}
try {
const proc = Bun.spawn(
[
"bun",
@@ -73,5 +93,9 @@ describe("unknown subcommand", () => {
expect(code).toBe(1);
expect(stderr).toContain("Unknown command: annotatte");
expect(stderr).toContain("plannotator annotate");
} finally {
for (const file of created) rmSync(file, { force: true });
if (createdDir) rmSync(distDir, { recursive: true, force: true });
}
}, 30_000);
});