JoostK
f35f4751b5
An inline type-check block is required when a reference to a component class cannot be emitted from an ngtypecheck shim file, but the logic to detect this situation did not consider the configured `rootDir`. When a `rootDir` is configured the reference emitter does not allow generating an import outside this directory, which meant that a shim file wouldn't be able to reference the component class. Consequently, type-check block generation would fail with a fatal error that is unaccounted for, as gathering diagnostics should be non-fallible. This commit fixes the problem by leveraging the existing `canReferenceType` logic of the type-checking `Environment`, instead of the rudimentary check whether the class is exported as top-level symbol (`checkIfClassIsExported`). Instead, `canReferenceType` pre-flights the generation of an import using the `ReferenceEmitter` to tell exactly whether it will succeed or not; thus taking into account the `rootDirs` constraint as well. Fixes #44999 PR Close #46096
Angular - The modern web developer's platform.
Angular is a development platform for building mobile and desktop web applications
using Typescript/JavaScript and other languages.
Contributing Guidelines
·
Submit an Issue
·
Blog
Documentation
Get started with Angular, learn the fundamentals and explore advanced topics on our documentation website.
Advanced
Development Setup
Prerequisites
- Install Node.js which includes Node Package Manager
Setting Up a Project
Install the Angular CLI globally:
npm install -g @angular/cli
Create workspace:
ng new [PROJECT NAME]
Run the application:
cd [PROJECT NAME]
ng serve
Angular is cross-platform, fast, scalable, has incredible tooling, and is loved by millions.
Quickstart
Ecosystem
Changelog
Learn about the latest improvements.
Upgrading
Check out our upgrade guide to find out the best way to upgrade your project.
Contributing
Contributing Guidelines
Read through our contributing guidelines to learn about our submission process, coding rules and more.
Want to Help?
Want to report a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues labeled as help wanted or good first issue.
Code of Conduct
Help us keep Angular open and inclusive. Please read and follow our Code of Conduct.
Community
Join the conversation and help the community.
Love Angular? Give our repo a star ⭐ ⬆️.