Andrew Scott
a268c4471f
The Router code currently has special-case handling around when and how the internal state is reset. Specifically, it only resets the internal tracking of the state when an error is thrown, which does not happen when guards reject or resolvers return `EMPTY`. Other than the navigation URL not matching a config, guards rejecting would be the main cause of a navigation being turned down. This change updates the router code to always reset the internal state in the same way, regardless of the reason for navigation cancellation. In the end, this will only affect _very_ specific use-cases with `UrlHandlingStrategy`. Because the internal state is not updated until the end of the transition pipe, the state reset generally doesn't do anything at all. However, because the `rawUrlTree` is reset by calling `urlHandlingStrategy.merge` with the _attempted_ `rawUrl` that failed, the resulting browser URL reset could be different than before (but will now be consistent with how the URL is reset in other scenarios, like a URL not matching a `Route` config). PR Close #43651
Angular - The modern web developer's platform.
Angular is a development platform for building mobile and desktop web applications
using Typescript/JavaScript and other languages.
Contributing Guidelines
·
Submit an Issue
·
Blog
Documentation
Get started with Angular, learn the fundamentals and explore advanced topics on our documentation website.
Advanced
Development Setup
Prerequisites
- Install Node.js which includes Node Package Manager
Setting Up a Project
Install the Angular CLI globally:
npm install -g @angular/cli
Create workspace:
ng new [PROJECT NAME]
Run the application:
cd [PROJECT NAME]
ng serve
Angular is cross-platform, fast, scalable, has incredible tooling, and is loved by millions.
Quickstart
Ecosystem
Changelog
Learn about the latest improvements.
Upgrading
Check out our upgrade guide to find out the best way to upgrade your project.
Contributing
Contributing Guidelines
Read through our contributing guidelines to learn about our submission process, coding rules and more.
Want to Help?
Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues labeled as help wanted or good first issue.
Code of Conduct
Help us keep Angular open and inclusive. Please read and follow our Code of Conduct.
Community
Join the conversation and help the community.
Love Angular? Give our repo a star ⭐ ⬆️.