release: cut the v7.2.4 release

revert: build: switch to typescript's es2015 typings (#28134 )
This reverts commit a6fd118f79.
2026-09-14 13:54:52 +08:00 · 2019-02-05 19:39:39 -08:00 · 2019-02-05 18:08:39 -05:00 · 2019-02-05 14:25:10 -05:00 · 2019-02-05 13:07:41 -05:00 · 2019-02-05 13:06:24 -05:00
114 changed files with 827 additions and 678 deletions
@@ -2,6 +2,10 @@
 # We do this by copying this file to /etc/bazel.bazelrc at the start of the build.
 # See documentation in /docs/BAZEL.md

+# Save downloaded repositories in a location that can be cached by CircleCI. This helps us
+# speeding up the analysis time significantly with Bazel managed node dependencies on the CI.
+build --repository_cache=/home/circleci/bazel_repository_cache
+
 # Don't be spammy in the logs
 # TODO(gmagolan): Hide progress again once build performance improves
 # Presently, CircleCI can timeout during bazel test ... with the following
@@ -11,10 +11,19 @@
 # needed for jobs that run tests without Bazel. Bazel runs tests with browsers that will be
 # fetched by the Webtesting rules. Therefore for jobs that run tests with Bazel, we don't need a
 # docker image with browsers pre-installed.
-# **NOTE**: If you change the version of the docker images, also change the `cache_key` suffix.
+# **NOTE 1**: If you change the version of the `*-browsers` docker image, make sure the
+#             `CI_CHROMEDRIVER_VERSION_ARG` env var (in `.circleci/env.sh`) points to a ChromeDriver
+#             version that is compatible with the Chrome version in the image.
+# **NOTE 2**: If you change the version of the docker images, also change the `cache_key` suffix.
 var_1: &default_docker_image circleci/node:10.12
 var_2: &browsers_docker_image circleci/node:10.12-browsers
-var_3: &cache_key v2-angular-{{ .Branch }}-{{ checksum "yarn.lock" }}-node-10.12
+# We don't want to include the current branch name in the cache key because that would prevent
+# PRs from being able to restore the cache since the branch names are always different for PRs.
+# The cache key should only consist of dynamic values that change whenever something in the
+# cache changes. For example:
+# 1) yarn lock file changes --> cached "node_modules" are different.
+# 2) bazel repository definitions change --> cached bazel repositories are different.
+var_3: &cache_key v2-angular-{{ checksum "yarn.lock" }}-{{ checksum "WORKSPACE" }}-{{ checksum "packages/bazel/package.bzl" }}-node-10.12

 # Define common ENV vars
 var_4: &define_env_vars
@@ -45,7 +54,13 @@ var_7: &post_checkout
 var_8: &yarn_install
  run:
    name: Running Yarn install
-    command: yarn install --frozen-lockfile --non-interactive
+    command: |
+      # Yarn's requests sometimes take more than 10mins to complete.
+      # Print something to stdout, to prevent CircleCI from failing due to not output.
+      while true; do sleep 60; echo "[`date`] Keeping alive..."; done &
+      KEEP_ALIVE_PID=$!
+      yarn install --frozen-lockfile --non-interactive
+      kill $KEEP_ALIVE_PID

 var_9: &setup_circleci_bazel_config
  run:
@@ -157,9 +172,9 @@ jobs:
        # (Run before unit and e2e tests, which destroy the `dist/` directory.)
      - run: yarn --cwd aio payload-size
        # Run unit tests
-      - run: yarn --cwd aio test --watch=false
+      - run: yarn --cwd aio test --progress=false --watch=false
        # Run e2e tests
-      - run: yarn --cwd aio e2e
+      - run: yarn --cwd aio e2e --configuration=ci
        # Run unit tests for Firebase redirects
      - run: yarn --cwd aio redirects-test

@@ -197,9 +212,22 @@ jobs:
        # (Run before unit and e2e tests, which destroy the `dist/` directory.)
      - run: yarn --cwd aio test-pwa-score-localhost $CI_AIO_MIN_PWA_SCORE
        # Run unit tests
-      - run: yarn --cwd aio test --watch=false
+      - run: yarn --cwd aio test --progress=false --watch=false
        # Run e2e tests
-      - run: yarn --cwd aio e2e
+      - run: yarn --cwd aio e2e --configuration=ci
+
+  test_aio_local_ivy:
+    <<: *job_defaults
+    steps:
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - attach_workspace:
+          at: dist
+      - *define_env_vars
+        # Build aio with Ivy (using local Angular packages)
+      - run: yarn --cwd aio build-with-ivy --progress=false

  test_aio_tools:
    <<: *job_defaults
@@ -278,14 +306,16 @@ jobs:
          name: Wait for preview and run tests
          command: node aio/scripts/test-preview.js $CI_PULL_REQUEST $CI_COMMIT $CI_AIO_MIN_PWA_SCORE

-  # This job exists only for backwards-compatibility with old scripts and tests
-  # that rely on the pre-Bazel dist/packages-dist layout.
-  # It duplicates some work with the job above: we build the bazel packages
-  # twice. Even though we have a remote cache, these jobs will typically run in
-  # parallel so up-to-date outputs will not be available at the time the build
+
+  # The `build-npm-packages` tasks exist for backwards-compatibility with old scripts and
+  # tests that rely on the pre-Bazel `dist/packages-dist` output structure (build.sh).
+  # Having multiple jobs that independently build in this manner duplicates some work; we build
+  # the bazel packages more than once. Even though we have a remote cache, these jobs will
+  # typically run in parallel so up-to-date outputs will not be available at the time the build
  # starts.
-  # No new jobs should depend on this one.
-  build-packages-dist:
+
+  # Build the view engine npm packages. No new jobs should depend on this.
+  build-npm-packages:
    <<: *job_defaults
    resource_class: xlarge
    steps:
@@ -306,6 +336,29 @@ jobs:
          root: dist
          paths:
            - packages-dist
+
+
+  # Build the ivy npm packages.
+  build-ivy-npm-packages:
+    <<: *job_defaults
+    resource_class: xlarge
+    steps:
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
+      - *setup_circleci_bazel_config
+      - *yarn_install
+      - *setup_bazel_remote_execution
+
+      - run: scripts/build-ivy-npm-packages.sh
+
+      # Save the npm packages from //packages/... for other workflow jobs to read
+      # https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs
+      - persist_to_workspace:
+          root: dist
+          paths:
            - packages-dist-ivy-aot

  # We run the integration tests outside of Bazel for now.
@@ -481,7 +534,7 @@ workflows:
      - lint
      - test
      - test_ivy_aot
-      - build-packages-dist
+      - build-npm-packages
      - test_aio
      - legacy-unit-tests-local
      - legacy-unit-tests-saucelabs
@@ -490,19 +543,19 @@ workflows:
            - test_aio
      - legacy-e2e-tests:
          requires:
-            - build-packages-dist
+            - build-npm-packages
      - legacy-misc-tests:
          requires:
-            - build-packages-dist
+            - build-npm-packages
      - test_aio_local:
          requires:
-            - build-packages-dist
+            - build-npm-packages
      - test_aio_tools:
          requires:
-            - build-packages-dist
+            - build-npm-packages
      - test_docs_examples:
          requires:
-            - build-packages-dist
+            - build-npm-packages
      - aio_preview:
          # Only run on PR builds. (There can be no previews for non-PR builds.)
          filters:
@@ -513,7 +566,7 @@ workflows:
            - aio_preview
      - integration_test:
          requires:
-            - build-packages-dist
+            - build-npm-packages
      - publish_snapshot:
          # Note: no filters on this job because we want it to run for all upstream branches
          # We'd really like to filter out pull requests here, but not yet available:
@@ -526,10 +579,11 @@ workflows:
            - integration_test
            # Only publish if `aio`/`docs` tests using the locally built Angular packages pass
            - test_aio_local
+            # - test_aio_local_ivy
            - test_docs_examples
-            # Get the artifacts to publish from the build-packages-dist job
+            # Get the artifacts to publish from the build-npm-packages job
            # since the publishing script expects the legacy outputs layout.
-            - build-packages-dist
+            - build-npm-packages
            - legacy-e2e-tests
            - legacy-misc-tests
            - legacy-unit-tests-local
@@ -15,7 +15,7 @@
 #
 # Usage: `setPublicVar <name> <value>`
 function setPublicVar() {
-  setSecretVar $1 $2;
+  setSecretVar $1 "$2";
  echo "$1=$2";
 }

@@ -18,6 +18,11 @@ setPublicVar PROJECT_ROOT "$(pwd)";
 setPublicVar CI_AIO_MIN_PWA_SCORE "95";
 # This is the branch being built; e.g. `pull/12345` for PR builds.
 setPublicVar CI_BRANCH "$CIRCLE_BRANCH";
+# ChromeDriver version compatible with the Chrome version included in the docker image used in
+# `.circleci/config.yml`. See http://chromedriver.chromium.org/downloads for a list of versions.
+# This variable is intended to be passed as an arg to the `webdriver-manager update` command (e.g.
+# `"postinstall": "webdriver-manager update $CI_CHROMEDRIVER_VERSION_ARG"`).
+setPublicVar CI_CHROMEDRIVER_VERSION_ARG "--versions.chrome 2.45";
 setPublicVar CI_COMMIT "$CIRCLE_SHA1";
 # `CI_COMMIT_RANGE` will only be available when `CIRCLE_COMPARE_URL` is also available (or can be
 # retrieved via `get-compare-url.js`), i.e. on push builds (a.k.a. non-PR, non-scheduled builds and
@@ -54,6 +54,7 @@
 #  kara - Kara Erickson
 #  kyliau - Keen Yee Liau
 #  matsko - Matias Niemelä
+#  mgechev - Minko Gechev
 #  mhevery - Misko Hevery
 #  ocombe - Olivier Combe
 #  petebacondarwin - Pete Bacon Darwin
@@ -113,6 +114,7 @@
 #   - alexeagle
 #   - kyliau
 #   - IgorMinar
+#   - mgechev


 # ===========================================================
@@ -122,6 +124,7 @@
 #   - alexeagle
 #   - filipesilva
 #   - hansl
+#   - mgechev


 # ===========================================================
@@ -1,3 +1,19 @@
+<a name="7.2.4"></a>
+## [7.2.4](https://github.com/angular/angular/compare/7.2.3...7.2.4) (2019-02-06)
+
+
+### Bug Fixes
+
+* **bazel:** Bazel builder resolves with require.resolve() ([#28478](https://github.com/angular/angular/issues/28478)) ([d85d396](https://github.com/angular/angular/commit/d85d396))
+* **bazel:** fix integration test for bazel-schematics ([#28460](https://github.com/angular/angular/issues/28460)) ([449da8c](https://github.com/angular/angular/commit/449da8c))
+
+
+### Performance Improvements
+
+* pngcrush all pngs ([#28479](https://github.com/angular/angular/issues/28479)) ([1a25144](https://github.com/angular/angular/commit/1a25144)), closes [#18243](https://github.com/angular/angular/issues/18243)
+
+
+
 <a name="7.2.3"></a>
 ## [7.2.3](https://github.com/angular/angular/compare/7.2.2...7.2.3) (2019-01-30)

@@ -1,6 +1,6 @@
 The MIT License

-Copyright (c) 2014-2018 Google, Inc. http://angular.io
+Copyright (c) 2010-2019 Google LLC. http://angular.io/license

 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -104,6 +104,9 @@
            },
            "archive": {
              "browserTarget": "site:build:archive"
+            },
+            "ci": {
+              "progress": false
            }
          }
        },
@@ -166,6 +169,11 @@
          "options": {
            "protractorConfig": "tests/e2e/protractor.conf.js",
            "devServerTarget": "site:serve"
+          },
+          "configurations": {
+            "ci": {
+              "devServerTarget": "site:serve:ci"
+            }
          }
        },
        "lint": {
@@ -97,7 +97,7 @@ export class HeroService {
  /** POST: add a new hero to the server */
  addHero (hero: Hero): Observable<Hero> {
    return this.http.post<Hero>(this.heroesUrl, hero, httpOptions).pipe(
-      tap((hero: Hero) => this.log(`added hero w/ id=${hero.id}`)),
+      tap((newHero: Hero) => this.log(`added hero w/ id=${newHero.id}`)),
      catchError(this.handleError<Hero>('addHero'))
    );
  }
@@ -2,7 +2,7 @@
@description
 The MIT License

-Copyright (c) 2014-2018 Google, Inc.
+Copyright (c) 2010-2019 Google LLC. http://angular.io/license

 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -17,7 +17,9 @@
    "build": "yarn ~~build",
    "prebuild-local": "yarn setup-local",
    "build-local": "yarn ~~build",
-    "extract-cli-command-docs": "node tools/transforms/cli-docs-package/extract-cli-commands.js 699743282",
+    "prebuild-with-ivy": "yarn setup-local && yarn ivy-ngcc",
+    "build-with-ivy": "node scripts/build-with-ivy",
+    "extract-cli-command-docs": "node tools/transforms/cli-docs-package/extract-cli-commands.js b5e796a03",
    "lint": "yarn check-env && yarn docs-lint && ng lint && yarn example-lint && yarn tools-lint",
    "test": "yarn check-env && ng test",
    "pree2e": "yarn check-env && yarn update-webdriver",
@@ -60,7 +62,7 @@
    "generate-stackblitz": "node ./tools/stackblitz-builder/generateStackblitz",
    "generate-zips": "node ./tools/example-zipper/generateZips",
    "build-404-page": "node scripts/build-404-page",
-    "update-webdriver": "webdriver-manager update --standalone false --gecko false $CHROMEDRIVER_VERSION_ARG",
+    "update-webdriver": "webdriver-manager update --standalone false --gecko false $CI_CHROMEDRIVER_VERSION_ARG",
    "~~check-env": "node scripts/check-environment",
    "~~clean-generated": "node --eval \"require('shelljs').rm('-rf', 'src/generated')\"",
    "~~build": "ng build --configuration=stable",
@@ -91,12 +93,11 @@
    "core-js": "^2.4.1",
    "rxjs": "^6.3.0",
    "tslib": "^1.9.0",
-    "web-animations-js": "^2.2.5",
    "zone.js": "^0.8.26"
  },
  "devDependencies": {
-    "@angular-devkit/build-angular": "~0.10.0",
-    "@angular/cli": "7.2.0-beta.2",
+    "@angular-devkit/build-angular": "^0.12.1",
+    "@angular/cli": "7.2.1",
    "@angular/compiler": "^7.0.0",
    "@angular/compiler-cli": "^7.0.0",
    "@angular/language-service": "^7.0.0",
@@ -0,0 +1,46 @@
+#!/usr/bin/env node
+
+// Imports
+const {extend, parse} = require('cjson');
+const {readFileSync, writeFileSync} = require('fs');
+const {join, resolve} = require('path');
+const {exec, set} = require('shelljs');
+
+set('-e');
+
+// Constants
+const ROOT_DIR = resolve(__dirname, '..');
+const TS_CONFIG_PATH = join(ROOT_DIR, 'tsconfig.json');
+const NG_COMPILER_OPTS = {
+  angularCompilerOptions: {
+    // Related Jira issue: FW-737
+    allowEmptyCodegenFiles: true,
+    enableIvy: 'ngtsc',
+  },
+};
+
+// Run
+_main(process.argv.slice(2));
+
+// Functions - Definitions
+function _main(buildArgs) {
+  console.log('\nModifying `tsconfig.json`...');
+  const oldTsConfigStr = readFileSync(TS_CONFIG_PATH, 'utf8');
+  const oldTsConfigObj = parse(oldTsConfigStr);
+  const newTsConfigObj = extend(true, oldTsConfigObj, NG_COMPILER_OPTS);
+  const newTsConfigStr = JSON.stringify(newTsConfigObj, null, 2);
+  writeFileSync(TS_CONFIG_PATH, newTsConfigStr);
+  console.log(newTsConfigStr);
+
+  try {
+    const buildArgsStr = buildArgs.join(' ');
+
+    console.log(`\nBuilding${buildArgsStr && ` with args \`${buildArgsStr}\``}...`);
+    exec(`yarn ~~build ${buildArgsStr}`, {cwd: ROOT_DIR});
+  } finally {
+    console.log('\nRestoring `tsconfig.json`...');
+    writeFileSync(TS_CONFIG_PATH, oldTsConfigStr);
+  }
+
+  console.log('\nDone!');
+}
@@ -61,7 +61,7 @@
        (docInserted)="onDocInserted()"
        (docRendered)="onDocRendered()">
    </aio-doc-viewer>
-    <aio-dt [on]="dtOn" [(doc)]="currentDocument"></aio-dt>
+    <aio-dt *ngIf="dtOn" [(doc)]="currentDocument"></aio-dt>
  </main>

 </mat-sidenav-container>
@@ -4,17 +4,16 @@ import { DocumentContents } from 'app/documents/document.service';
@Component({
  selector: 'aio-dt',
  template: `
-  <div *ngIf="on">
-    <hr>
-    <textarea #dt [value]="text" rows="10" cols="80"></textarea>
-    <br/>
-    <button (click)="dtextSet()">Show change</button>
-  </div>
+    <div>
+      <hr>
+      <textarea #dt [value]="text" rows="10" cols="80"></textarea>
+      <br/>
+      <button (click)="dtextSet()">Show change</button>
+    </div>
  `
 })
 export class DtComponent {

-  @Input() on = false;
  @Input() doc: DocumentContents;
  @Output() docChange = new EventEmitter<DocumentContents>();

@@ -1,23 +1,20 @@
-
-  <div class="grid-fluid">
-    <div class="footer-block" *ngFor="let node of nodes">
-      <h3>{{node.title}}</h3>
-      <ul>
-        <li *ngFor="let item of node.children">
-          <a class="link" [href]="item.url"
-            [title]="item.tooltip || item.title">{{ item.title }}</a>
-        </li>
-      </ul>
-    </div>
+<div class="grid-fluid">
+  <div class="footer-block" *ngFor="let node of nodes">
+    <h3>{{node.title}}</h3>
+    <ul>
+      <li *ngFor="let item of node.children">
+        <a class="link" [href]="item.url" [title]="item.tooltip || item.title">{{ item.title }}</a>
+      </li>
+    </ul>
  </div>
+</div>

-  <p>
-    Powered by Google ©2010-2018.
-    Code licensed under an <a href="license" title="License text" >MIT-style License</a>.
-    Documentation licensed under
-    <a href="http://creativecommons.org/licenses/by/4.0/">CC BY 4.0</a>.
-  </p>
-  <p>
-    Version {{versionInfo?.full}}.
-  </p>
-  <!-- TODO: twitter widget (but only on pages that use twitter) -->
+<p>
+  Super-powered by Google ©2010-2019.
+  Code licensed under an <a href="license" title="License text">MIT-style License</a>.
+  Documentation licensed under
+  <a href="http://creativecommons.org/licenses/by/4.0/">CC BY 4.0</a>.
+</p>
+<p>
+  Version {{versionInfo?.full}}.
+</p>
@@ -1,9 +1,3 @@
-/*
-Copyright 2016 Google Inc. All Rights Reserved.
-Use of this source code is governed by an MIT-style license that
-can be found in the LICENSE file at http://angular.io/license
-*/
-
 import { NgZone, Injectable } from '@angular/core';
 import { ConnectableObservable, Observable, race, ReplaySubject, timer } from 'rxjs';
 import { concatMap, first, publishReplay } from 'rxjs/operators';
@@ -1,9 +1,3 @@
-/*
-Copyright 2016 Google Inc. All Rights Reserved.
-Use of this source code is governed by an MIT-style license that
-can be found in the LICENSE file at http://angular.io/license
-*/
-
 import {NgZone} from '@angular/core';
 import {Observable} from 'rxjs';

@@ -17,5 +17,5 @@ import 'core-js/es6/set';
 /** IE10 and IE11 requires the following for NgClass support on SVG elements */
 import 'classlist.js';

-/** IE10 and IE11 requires the following to support `@angular/animation`. */
-import 'web-animations-js';
+/** Only required if AnimationBuilder is used within the application and using IE/Edge or Safari. */
+// import 'web-animations-js';
@@ -1,3 +1,10 @@
+/*
+Copyright Google LLC. All Rights Reserved.
+Use of this source code is governed by an MIT-style license that
+can be found in the LICENSE file at http://angular.io/license
+*/
+
+
 /**
 * WEB VERSION FOR CURRENT ANGULAR BUILD
 * (based on systemjs.config.js in angular.io)
@@ -94,9 +101,3 @@
  });

 })(this);
-
-/*
-Copyright 2016 Google Inc. All Rights Reserved.
-Use of this source code is governed by an MIT-style license that
-can be found in the LICENSE file at http://angular.io/license
-*/
@@ -1,3 +1,9 @@
+/*
+Copyright Google LLC. All Rights Reserved.
+Use of this source code is governed by an MIT-style license that
+can be found in the LICENSE file at http://angular.io/license
+*/
+
 /**
 * WEB ANGULAR VERSION
 * (based on systemjs.config.js in angular.io)
@@ -80,9 +86,3 @@
  });

 })(this);
-
-/*
-Copyright 2016 Google Inc. All Rights Reserved.
-Use of this source code is governed by an MIT-style license that
-can be found in the LICENSE file at http://angular.io/license
-*/
@@ -6,7 +6,7 @@
  "scripts": {
    "http-server": "http-server",
    "protractor": "protractor",
-    "webdriver:update": "webdriver-manager update --standalone false --gecko false $CHROMEDRIVER_VERSION_ARG",
+    "webdriver:update": "webdriver-manager update --standalone false --gecko false $CI_CHROMEDRIVER_VERSION_ARG",
    "preinstall": "node ../../../../tools/yarn/check-yarn.js",
    "postinstall": "yarn webdriver:update"
  },
@@ -51,9 +51,9 @@ class StackblitzBuilder {
  }

  _buildCopyrightStrings() {
-    var copyright = 'Copyright 2017-2018 Google Inc. All Rights Reserved.\n'
-      + 'Use of this source code is governed by an MIT-style license that\n'
-      + 'can be found in the LICENSE file at http://angular.io/license';
+    var copyright = 'Copyright Google LLC. All Rights Reserved.\n' +
+        'Use of this source code is governed by an MIT-style license that\n' +
+        'can be found in the LICENSE file at http://angular.io/license';
    var pad = '\n\n';
    this.copyrights.jsCss = `${pad}/*\n${copyright}\n*/`;
    this.copyrights.html = `${pad}<!-- \n${copyright}\n-->`;
@@ -105,8 +105,8 @@ Angular uses [clang-format](http://clang.llvm.org/docs/ClangFormat.html) to form
 If the source code is not properly formatted, the CI will fail and the PR can not be merged.

 You can automatically format your code by running:
- `gulp format`: format all source code
- `gulp format:changed`: re-format only edited source code.
+- `gulp format`: re-format only edited source code.
+- `gulp format:all`: format _all_ source code

 A better way is to set up your IDE to format the changed file on each file save.

@@ -27,11 +27,25 @@ function loadTask(fileName, taskName) {
  return task(gulp);
 }

+// Check source code for formatting errors in all source files.
 gulp.task('format:enforce', loadTask('format', 'enforce'));
-gulp.task('format', loadTask('format', 'format'));
+
+// Format all source files.
+gulp.task('format:all', loadTask('format', 'format'));
+
+// Format only untracked source code files.
 gulp.task('format:untracked', loadTask('format', 'format-untracked'));
+
+// Format only the changed, tracked source code files.
 gulp.task('format:diff', loadTask('format', 'format-diff'));
+
+// Format only changed lines based on the diff from the provided --branch
+// argument (or `master` by default).
 gulp.task('format:changed', ['format:untracked', 'format:diff']);
+
+// Alias for `format:changed` that formerly formatted all files.
+gulp.task('format', ['format:changed']);
+
 gulp.task('lint', ['format:enforce', 'validate-commit-messages', 'tslint']);
 gulp.task('tslint', ['tools:build'], loadTask('lint'));
 gulp.task('validate-commit-messages', loadTask('validate-commit-message'));
@@ -10,6 +10,8 @@ function testBazel() {
  ng new demo --collection=@angular/bazel --defaults --skip-git --style=scss
  node replace_angular_repo.js "./demo/WORKSPACE"
  cd demo
+  yarn add @angular/bazel@file:../../../dist/packages-dist/bazel
+  yarn webdriver-manager update --gecko=false --standalone=false $CI_CHROMEDRIVER_VERSION_ARG
  cp ../package.json.replace ./package.json
  ng generate component widget --style=css
  ng build
@@ -23,7 +25,7 @@ function testNonBazel() {
  rm -rf dist src/main.dev.ts src/main.prod.ts
  ng build --progress=false
  ng test --progress=false --watch=false
-  ng e2e --configuration=ci
+  ng e2e --configuration=ci --webdriver-update=false
 }

 testBazel
@@ -51,7 +51,7 @@
    rxjs "6.3.3"
    source-map "0.7.3"

-"@angular-devkit/schematics@7.1.3", "@angular-devkit/schematics@^7.0.4":
+"@angular-devkit/schematics@7.1.3":
  version "7.1.3"
  resolved "https://registry.yarnpkg.com/@angular-devkit/schematics/-/schematics-7.1.3.tgz#30d03fde5bb27d6606d9a6e055188382408670d6"
  integrity sha512-Snmfog/n5k1PWdDaI+Top1F978vlXZFTvxHRPzlMCGhGsY+LMOpeRLVHADI+WP1q1LZ+2BjLELZVA2GP35AH8A==
@@ -59,7 +59,7 @@
    "@angular-devkit/core" "7.1.3"
    rxjs "6.3.3"

-"@angular-devkit/schematics@7.3.0-rc.0":
+"@angular-devkit/schematics@7.3.0-rc.0", "@angular-devkit/schematics@^7.3.0-rc.0":
  version "7.3.0-rc.0"
  resolved "https://registry.yarnpkg.com/@angular-devkit/schematics/-/schematics-7.3.0-rc.0.tgz#9f1e1f6942da36b12c81241398ed6ca8b2e65875"
  integrity sha512-noqcQIOvah2G126DTFKY5Kiga8UwI9cKzyhQdNlf+8hAZpnWwTURItQ5xuMJg/XfRQLUSg9gWS2h1cI9AD7mxQ==
@@ -68,11 +68,11 @@
    rxjs "6.3.3"

 "@angular/bazel@file:../../dist/packages-dist/bazel":
-  version "8.0.0-beta.0"
+  version "8.0.0-beta.1"
  dependencies:
    "@angular-devkit/architect" "^0.10.6"
    "@angular-devkit/core" "^7.0.4"
-    "@angular-devkit/schematics" "^7.0.4"
+    "@angular-devkit/schematics" "^7.3.0-rc.0"
    "@bazel/typescript" "^0.22.1"
    "@schematics/angular" "^7.0.4"
    "@types/node" "6.0.84"
@@ -97,27 +97,27 @@
    semver "5.6.0"
    symbol-observable "1.2.0"

-"@bazel/bazel-darwin_x64@0.21.0":
-  version "0.21.0"
-  resolved "https://registry.yarnpkg.com/@bazel/bazel-darwin_x64/-/bazel-darwin_x64-0.21.0.tgz#db033b6880294ed274489d3bce4a36c77dbf5a7a"
-  integrity sha512-9lI9SFHUm50ufJHD/5gOdJeuaI/hdGji5d0ezYWJdJK55tj4VhcatkJumjYD6yp1nPNnU038AZ7JvkPcTgt7OA==
+"@bazel/bazel-darwin_x64@0.22.0":
+  version "0.22.0"
+  resolved "https://registry.yarnpkg.com/@bazel/bazel-darwin_x64/-/bazel-darwin_x64-0.22.0.tgz#a2bea5922dba9a32554a218ba4849a200115b248"
+  integrity sha512-LFxkyQgPATeB64z/1IvOWZhK+lc3JVHejbmdo96qB4lsoD8zselvOlgHvVXxlAjRxVZ9mlmXDvDRDyaXyyRdwA==

-"@bazel/bazel-linux_x64@0.21.0":
-  version "0.21.0"
-  resolved "https://registry.yarnpkg.com/@bazel/bazel-linux_x64/-/bazel-linux_x64-0.21.0.tgz#d9ba05ff405c52d09878ecfb89872bda2fda418e"
-  integrity sha512-CyOblC7pMIMaXwkQazo/jz2ipmIkxngmVCTzjNKGO9GiZK71L4X/B8Simy3tFhDHZFxso2HkvJTiY1UJozFyZw==
+"@bazel/bazel-linux_x64@0.22.0":
+  version "0.22.0"
+  resolved "https://registry.yarnpkg.com/@bazel/bazel-linux_x64/-/bazel-linux_x64-0.22.0.tgz#12e5884f2a7b7f3b62afbef9f8da4de0976f3bc8"
+  integrity sha512-xDs8cb2bbGZ9uvzYZOzCVrMBywzRhLj0J/t+py+FYZj+VO5B3wVg9eUf6nWWR0oJ2mzvToI9h31t2tNdqwy2kQ==

-"@bazel/bazel-win32_x64@0.21.0":
-  version "0.21.0"
-  resolved "https://registry.yarnpkg.com/@bazel/bazel-win32_x64/-/bazel-win32_x64-0.21.0.tgz#f2f40f40b862f368d8596b4f69152640bd15e2ed"
-  integrity sha512-ELNF4ddUCnd1Qx9359tJ5DenlVK0e5Yoe7PVv+qWNQKSCjguh8jtRy9IlzGZHjn8tFMSnTQjYYY0DgW1W1sbSA==
+"@bazel/bazel-win32_x64@0.22.0":
+  version "0.22.0"
+  resolved "https://registry.yarnpkg.com/@bazel/bazel-win32_x64/-/bazel-win32_x64-0.22.0.tgz#a8a65986639583a8cc7b018e001aedfdafe41b50"
+  integrity sha512-FbJaXVDoCLnpIFLnPHFkQdfriYPXfnfQNuf9EXMliERdRuoeBVbwEZfwcuArxZWNFus7bD8QiTj0XzKVWO+Wbw==

 "@bazel/bazel@file:../../node_modules/@bazel/bazel":
-  version "0.21.0"
+  version "0.22.0"
  optionalDependencies:
-    "@bazel/bazel-darwin_x64" "0.21.0"
-    "@bazel/bazel-linux_x64" "0.21.0"
-    "@bazel/bazel-win32_x64" "0.21.0"
+    "@bazel/bazel-darwin_x64" "0.22.0"
+    "@bazel/bazel-linux_x64" "0.22.0"
+    "@bazel/bazel-win32_x64" "0.22.0"

 "@bazel/typescript@^0.22.1":
  version "0.22.1"
@@ -1,6 +1,6 @@
 import { AppPage } from './app.po';

-describe('cli-hello-world App', () => {
+describe('cli-hello-world-ivy App', () => {
  let page: AppPage;

  beforeEach(() => {
@@ -7,8 +7,9 @@
    "e2e": "ng e2e --webdriver-update=false",
    "lint": "ng lint",
    "ng": "ng",
-    "postinstall": "webdriver-manager update --gecko=false --standalone=false $CHROMEDRIVER_VERSION_ARG && yarn ivy-ngcc",
+    "postinstall": "webdriver-manager update --gecko=false --standalone=false $CI_CHROMEDRIVER_VERSION_ARG && yarn ivy-ngcc",
    "start": "ng serve",
+    "pretest": "ng version",
    "//test1": "TODO FW-813: Re-enable `ci-production`. Currently, it fails after a timeout as Protractor reports Angular cannot be found on the page",
    "//test2": "ng test --progress=false --watch=false && yarn e2e --configuration=ci && yarn e2e --configuration=ci-production",
    "test": "ng test --progress=false --watch=false && yarn e2e --configuration=ci"
@@ -7,8 +7,9 @@
    "e2e": "ng e2e --webdriver-update=false",
    "lint": "ng lint",
    "ng": "ng",
-    "postinstall": "webdriver-manager update --gecko=false --standalone=false $CHROMEDRIVER_VERSION_ARG",
+    "postinstall": "webdriver-manager update --gecko=false --standalone=false $CI_CHROMEDRIVER_VERSION_ARG",
    "start": "ng serve",
+    "pretest": "ng version",
    "test": "ng test --progress=false --watch=false && yarn e2e --configuration=ci && yarn e2e --configuration=ci-production"
  },
  "private": true,
@@ -10,7 +10,7 @@
    "ngc": "ngc -p tsconfig.json",
    "rollup": "rollup -f iife -c rollup.config.js -o dist/bundle.es2015.js",
    "rollup:lazy": "rollup -f cjs -c rollup.lazy.config.js -o dist/lazy.bundle.es2015.js",
-    "postinstall": "webdriver-manager update --gecko false --standalone false $CHROMEDRIVER_VERSION_ARG",
+    "postinstall": "webdriver-manager update --gecko false --standalone false $CI_CHROMEDRIVER_VERSION_ARG",
    "preprotractor": "tsc -p e2e",
    "protractor": "protractor e2e/protractor.config.js",
    "serve": "lite-server -c e2e/browser.config.json",
@@ -22,7 +22,7 @@
    "protractor": "file:../../node_modules/protractor"
  },
  "scripts": {
-    "postinstall": "webdriver-manager update --gecko false --standalone false $CHROMEDRIVER_VERSION_ARG",
+    "postinstall": "webdriver-manager update --gecko false --standalone false $CI_CHROMEDRIVER_VERSION_ARG",
    "closure": "java -jar node_modules/google-closure-compiler/compiler.jar --flagfile closure.conf",
    "test": "ngc && yarn run closure && concurrently \"yarn run serve\" \"yarn run protractor\" --kill-others --success first",
    "serve": "lite-server -c e2e/browser.config.json",
@@ -4,7 +4,7 @@
  "version": "0.0.0",
  "license": "MIT",
  "scripts": {
-    "postinstall": "webdriver-manager update --gecko false --standalone false $CHROMEDRIVER_VERSION_ARG",
+    "postinstall": "webdriver-manager update --gecko false --standalone false $CI_CHROMEDRIVER_VERSION_ARG",
    "test": "concurrently \"yarn serve\" \"yarn protractor\" --kill-others --success first",
    "serve": "lite-server -c bs-config.e2e.json",
    "preprotractor": "tsc -p e2e",
@@ -23,7 +23,7 @@
    "protractor": "file:../../node_modules/protractor"
  },
  "scripts": {
-    "postinstall": "webdriver-manager update --gecko false --standalone false $CHROMEDRIVER_VERSION_ARG",
+    "postinstall": "webdriver-manager update --gecko false --standalone false $CI_CHROMEDRIVER_VERSION_ARG",
    "closure": "java -jar node_modules/google-closure-compiler/compiler.jar --flagfile closure.conf",
    "test": "ngc && yarn run closure && concurrently \"yarn run serve\" \"yarn run protractor\" --kill-others --success first && npm run test-locale-folder",
    "test-locale-folder": "node test-locale-folder.js",
@@ -31,4 +31,4 @@
    "preprotractor": "tsc -p e2e",
    "protractor": "protractor e2e/protractor.config.js"
  }
-}
+}
@@ -23,7 +23,7 @@
    "protractor": "file:../../node_modules/protractor"
  },
  "scripts": {
-    "postinstall": "webdriver-manager update --gecko false --standalone false $CHROMEDRIVER_VERSION_ARG",
+    "postinstall": "webdriver-manager update --gecko false --standalone false $CI_CHROMEDRIVER_VERSION_ARG",
    "closure": "java -jar node_modules/google-closure-compiler/compiler.jar --flagfile closure.conf",
    "test": "ngc && yarn run closure && concurrently \"yarn run serve\" \"yarn run protractor\" --kill-others --success first",
    "serve": "lite-server -c e2e/browser.config.json",
@@ -34,7 +34,7 @@
    "webpack": "^2.2.1"
  },
  "scripts": {
-    "postinstall": "webdriver-manager update --gecko false --standalone false $CHROMEDRIVER_VERSION_ARG",
+    "postinstall": "webdriver-manager update --gecko false --standalone false $CI_CHROMEDRIVER_VERSION_ARG",
    "build": "./build.sh",
    "test": "npm run build && concurrently \"npm run serve\" \"npm run protractor\" --kill-others --success first",
    "serve": "node built/server-bundle.js",
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Matias Niemelä	74c202a5cd	release: cut the v7.2.4 release	2019-02-05 19:39:39 -08:00
Matias Niemelä	483e8d28ec	revert: build: switch to typescript's es2015 typings (#28134 ) This reverts commit `a6fd118f79`.	2019-02-05 18:08:39 -05:00
Alex Eagle	a6fd118f79	build: switch to typescript's es2015 typings (#28134 ) Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset. This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode. This is a subset of https://github.com/angular/angular/pull/27738 PR Close #28134	2019-02-05 14:25:10 -05:00
George Kalpakas	fe6e76c1e7	ci: keep job alive when yarn request takes more than 10 minutes (#28458 ) Occasionally, yarn's requests take more than 10 minutes to complete/fail, by which time CircleCI jobs due to no output. This commit works around the issue by periodically printing something to stdout. PR Close #28458	2019-02-05 13:07:41 -05:00
Paul Gschwendtner	de560019f2	build: fix bazel repositories not cached on circleci (#28515 ) Previously all Bazel repositories were cached on CircleCI because the `experimental_repository_cache` flag has been specified and the given repository cache directory has been included in the CircleCI cache storage. The directory is currently still included in the CircleCI cache storage, but the `--repository_cache` flag is no longer specified, and the cache directory is basically empty all the time. The flag seems to have been removed accidentally within SHA `c8b70ae8e4`. We should specifiy this flag on the CI again, so that Bazel doesn't need to install the Bazel managed node modules all the time. This would slow down analysis phase on CI; and also makes us dependent on the Yarn/NPM registry which often times out if we fetch a lot of dependencies. Also in order to make sure that cached Bazel repositories are also most of the time in sync with what's currently defined in the workspace, we need to update the cache key. PR Close #28515	2019-02-05 13:06:24 -05:00
George Kalpakas	52ed53d071	build(docs-infra): upgrade cli command docs sources to b5e796a03 (#28467 ) Updating [angular#7.2.x](https://github.com/angular/angular/tree/7.2.x) from [cli-builds#7.3.x](https://github.com/angular/cli-builds/tree/7.3.x). Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/699743282...b5e796a03): Modified - help/add.json - help/build.json - help/generate.json - help/new.json PR Close #28467	2019-02-05 13:05:39 -05:00
Jeremy Elbourn	5b72d4d676	ci: refactoring from adding material tests to master ci (#28496 ) This cherry-picks changes from #28197 to minimize the difference in the ci infrastructure between master the the current patch branch PR Close #28496	2019-02-05 01:52:59 -05:00
Jeremy Elbourn	c1aa1bf872	build: `gulp format` only changed lines by default (#28411 ) Changes `gulp format` to format only changed lines by default (`gulp format:changed`) and introduces a new task, `gulp format:all` to format all source files. Since formatting only changed lines should be the more common action, it makes more sense as the shorter default. PR Close #28411	2019-02-04 16:49:16 -05:00
Adam Plumer	dad1bc7ca3	build: bump year (#28220 ) PR Close #28220	2019-02-04 16:41:00 -05:00
LHearen	2109c30afe	docs: fix shadow variable in tutorial example (#28499 ) PR Close #28499	2019-02-04 14:54:53 -05:00
WilliamKoza	874919a25b	fix(docs-infra): remove polyfill web-animations since we use Angular > 6 and we don't use `AnimationBuilder` (#28514 ) PR Close #28514	2019-02-04 14:54:26 -05:00
George Kalpakas	c64e666755	test: log cli version in `cli-hello-world[-ivy]` integration projects (#28421 ) This helps debug issues on CI. PR Close #28421	2019-02-04 11:02:41 -05:00
George Kalpakas	1da403d8f3	refactor: correctly name `cli-hello-world-ivy` project to distinguish from `cli-hello-world` in logs (#28421 ) PR Close #28421	2019-02-04 11:02:40 -05:00
George Kalpakas	60c5ebd46a	ci(docs-infra): compile with Ivy (#28421 ) Jira: FW-552 PR Close #28421	2019-02-04 11:02:40 -05:00
George Kalpakas	b71d1987cd	build(docs-infra): upgrade @angular/cli to 7.2.1 (#28421 ) PR Close #28421	2019-02-04 11:02:40 -05:00
George Kalpakas	e6325eb9ef	refactor(docs-infra): get rid of `on` component input (#28421 ) PR Close #28421	2019-02-04 11:02:40 -05:00
George Kalpakas	114519ab6a	fix(ivy): add missing private render3 exports (#28421 ) PR Close #28421	2019-02-04 11:02:40 -05:00
George Kalpakas	a9a095d44a	refactor(core): remove duplicate check in `defaultStyleSanitizer` (#28421 ) PR Close #28421	2019-02-04 11:02:40 -05:00
Filipe Silva	5f9d574d4d	build(docs-infra): update terser version in lockfile (#28512 ) See https://github.com/angular/angular-cli/issues/13582#issuecomment-460261055. PR Close #28512	2019-02-04 10:52:07 -05:00
Minko Gechev	baeb446392	ci: add mgechev to tools & tools-bazel codeowners (#28384 ) PR Close #28384	2019-02-04 03:31:29 -08:00
Paul Gschwendtner	0d1bfdc505	build: fix circleci not restoring cache for PRs (#28480 ) Currently whenever someone creates a pull request, the NPM dependencies are downloaded and installed. This is problematic because we have a lot NPM dependencies with potentially large files that would need to be downloaded (e.g. the Bazel binaries). The caches are currently not being restored because we added the `{Branch}` variable to the CircleCI cache key. Since every PR has a different branch name (e.g. `devversion/refs/heads/my-banch`), the cache keys would never match an existing cache key, and the PR would start fresh by downloading everything. We can safely remove the `{Branch}` variable from the cache key because it does not provide any value since the cached files are based on the state of the `yarn.lock` file and not based on the current branch name. This reduces our dependency on the slow and sometimes flaky Yarn registry. We should try to depend as few as possible on external services (e.g. see how Saucelabs flakiness can cause trouble for the caretaker; same applies to flaky Yarn installs) PR Close #28480	2019-02-04 02:48:49 -08:00
George Kalpakas	fa130e9445	ci: pin ChromeDriver to a version compatible with docker image's Chrome (#28494 ) By default, `webdriver-manager update` will download the latest ChromeDriver version, which might not be compatible with the Chrome version included in the [docker image used on CI], causing CI failures. Previously, we used to pin the ChromeDriver version on CI in [ngcontainer's Dockerfile][2]. This was accidentally broken in #26691, while moving from ngcontainer to default CircleCI docker images. This commit fixes the issue by pinning ChromeDriver to a known compatible version. [1]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/.circleci/config.yml#L16 [2]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/tools/ngcontainer/Dockerfile#L63 PR Close #28494	2019-02-01 20:22:04 -05:00
George Kalpakas	194710fc1d	ci: fix setting env var with spaces in value (#28494 ) PR Close #28494	2019-02-01 20:22:04 -05:00
George Kalpakas	6ae5e2b32a	ci(docs-infra): reduce output verbosity to improve log readability (#28494 ) PR Close #28494	2019-02-01 20:22:04 -05:00
Keen Yee Liau	d85d396c26	fix(bazel): Bazel builder resolves with require.resolve() (#28478 ) This commit fixes a bug in the Bazel builder in which the path to Bazel executable is constructed using the project path. For non-default project, the node_modules directory is actually one level above the project path. This PR fixes the bug by resolving node_modules with require.resolve(). It requires @bazel/bazel v0.22.1 because previous versions do not have index.js or main field in package.json and would cause node module resolution to fail. This has been tested with both bazel and ibazel. PR Close #28478	2019-02-01 13:56:54 -05:00
Jeremy Elbourn	1a25144297	perf: pngcrush all pngs (#28479 ) This is the result of running ```sh find ./ -iname "*.png" -exec pngcrush -brute -ow -- {} \; ``` [Summary of size reductions](https://docs.google.com/spreadsheets/d/12Qgx7DfKabWw0PJza6ozC1kCHTofi6wyBLWGtwLW7G4/preview) Last done in July, 2017 in #18243 PR Close #28479	2019-02-01 13:56:02 -05:00
Keen Yee Liau	449da8c18e	fix(bazel): fix integration test for bazel-schematics (#28460 ) With the release of @angular/bazel v7.2.3, the npm install step right after `ng new` installs this version. However there is a bug in the builder which results in bazel executable not found. This bug was not discovered before because the dependencies of the project created by `ng new` are not pinned. The fix is to pin the version of @angular/bazel to 7.2.2 which relies on global installation of bazel. PR Close #28460	2019-01-30 19:05:12 -05:00