Commit Graph

80 Commits

Author SHA1 Message Date
Kristiyan Kostadinov 0c00e70542 refactor(overlay): convert fullscreen overlay container e2e tests into unit tests (#13657) 2018-10-18 09:17:33 -07:00
Kristiyan Kostadinov 411fce3901 chore: fix checkbox lint warning (#13209)
Fixes an unused import that got into master.

**Note:** targeting major, because I think that it got introduced in the PR for the checkbox design changes.
2018-09-20 09:19:08 -07:00
Kristiyan Kostadinov 95acccc65b feat(checkbox): align with 2018 material design spec (#12493)
Aligns the checkbox component with the latest Material design spec.
2018-09-19 14:23:09 -07:00
Kristiyan Kostadinov c812268ac3 feat(menu): align with 2018 material design spec (#12331)
Aligns the menu component with the latest version of the Material design spec. Includes making `overlapTrigger` false by default.
2018-08-30 17:28:20 -07:00
Kristiyan Kostadinov 6aa7727007 build: fix radio e2e tests timing out (#12857)
Fixes a timeout in the radio button e2e tests, after the new design changes got in. The tests expect there to be no ripples, but the new design introduced a permanent ripple in each button. This is along the same lines as #12699.
2018-08-27 12:40:59 -07:00
Kristiyan Kostadinov ac8339cc10 test: fix slide-toggle e2e failures (#12699)
Fixes some e2e failures in the slide toggle after the new design got in. The tests expect the ripples to go away at some point, however we introduced a permanent ripple.
2018-08-16 11:31:14 -07:00
Kristiyan Kostadinov 7f8fd9fc06 fix(tabs): enable keyboard wrapping and mark disabled tabs (#12218) 2018-07-18 09:45:36 -07:00
Kristiyan Kostadinov 8973971846 build: e2e and test init files not being linted (#12221) 2018-07-18 08:54:44 -07:00
Paul Gschwendtner afb0ee37eb chore: remove screenshot testing (#12155)
Removes the screenshot test tool since Angular Material is visually being tested inside of Google.
2018-07-11 08:24:21 -07:00
mmalerba f59658d848 virtual-scroll: merge into master under cdk-experimental (#11354)
* feat(virtual-scroll): fixed size virtual scroll (#9316)

* feat(virtual-scroll): fixed size virtual scroll

* address some comments

* change VirtualScrollStrategy interface a bit

* address some more comments

* fix lint & build

* chore: move virtual-scroll to cdk-experimental (#9974)

* virtual-scroll: simplify scroll listener logic (#10102)

* virtual-scroll: only move views that need to be moved (#10099)

* virtual-scroll: only move views that need to be moved

* address comments

* virtual-scroll: switch `throttleTime` to `sampleTime` (#10179)

* virtual-scroll: switch throttleTime to sampleTime

* add comment

* virtual-scroll: allow user to pass `Observable<T[]>` (#10158)

* virtual-scroll: rename `Range` to `ListRange` to avoid confusion with native `Range` (#10220)

* virtual-scroll: add autosize scroll strategy (#10219)

* rename fixed size virtual scroll directive

* add autosize virtual scroll strategy

* add item size estimator class

* add logic for jumping rendered content based on scroll position

* address comments

* virtual-scroll: add `onContentRendered` hook to `VirtualScrollStrategy` (#10290)

* virtual-scroll: add `onContentRendered` hook to `VirtualScrollStrategy`

* address comemnts

* virtual-scroll: add incremental scroll logic in `AutosizeVirtualScrollStrategy` (#10504)

* virtual-scroll: add incremental scroll logic in `AutosizeVirtualScrollStrategy`.

This still has a couple issues that need to be ironed out and it doesn't
have the code for correcting the error between the predicted and actual
scroll position. (See various TODOs for additional things that need
work).

* fix lint

* address comments

* address comments

* fix bazel

* fix devapp

* fix lint

* cleanup

* virtual-scroll: rewrite offset in terms of "to-top" and fix a bug where items were removed too soon (#10986)

* rewrite offsets to the end of the rendered content as offsets to the
start

* add some more autosize demos for testing

* make sure not to remove too many items

* address comments

* virtual-scroll: address amcdnl's feedback (#10988)

* rewrite offsets to the end of the rendered content as offsets to the
start

* add some more autosize demos for testing

* make sure not to remove too many items

* virtual-scroll: address amcdnl's feedback

* virtual-scroll: fix updating when data changes and add trackBy demos (#11085)

* virtual-scroll: add logic to correct the scroll position as user move… (#11137)

* virtual-scroll: add logic to correct the scroll position as user moves toward the top

* address comments

* fix(scrolling): adds right to fix pushed content (#11192)

* fix(scrolling): adds right to fix pushed content

* chore: address feedback

* chore: address pr feedback

* virtual-scroll: add tests for fixed size items (#11255)

* virtual-scroll: add tests for fixed size items

* address comments

* fix bug in fixed size strategy

* fix bazel build

* virtual-scroll: add tests for `cdkVirtualFor` logic (#11275)

* merge fixed size test components into one

* add tests for cdkVirtualFor logic

* allow undefined to be explicitly passed as trackBy

* fix bazel build

* address comments

* add some basic tests (#11295)

* fix lint

* virtual-scroll: add e2e tests for autosize scroll strategy (#11345)

* set up virtual scroll page in e2e app

* add gulp task for e2e:watch

* add e2e tests for autosize

* address comments

* address comments

* fix lint and tests

* fix bad rebase

* fix(scrolling): scrollbar jump when data change on scroll (#11193)

* fix(scrolling): data change not updating size

* chore: remove todo

* chore: more performant fix for jump
2018-05-22 09:19:56 -07:00
Kristiyan Kostadinov ef102aa0a1 chore: fix menu e2e test failure (#9549)
Fixes an e2e test that is failing after #9383.
2018-01-23 13:12:18 -08:00
Rafael Santana 379a305182 docs: ensure docs are being shown for '@Input's (#9471) 2018-01-23 07:30:03 -08:00
Kristiyan Kostadinov 33edff5f14 build: update jasmine for improved type safety (#8350)
* Bumps the version of Jasmine to allow for better type safety in the assertions.
* Fixes a few new compilation errors.
2017-11-13 18:55:53 -08:00
Joey Perrott 9b88aac155 fix(expansion) Add expansion panel outputs (#7309) 2017-11-07 09:55:54 -08:00
Kristiyan Kostadinov d822a3948e fix(menu): not handling keyboard events when opened by mouse (#4843)
Fixes the menu keyboard interactions not working when it is opened by a click.

Fixes #4991.
2017-10-10 16:37:07 -07:00
Kristiyan Kostadinov db3e248e6e chore: remove leftover md- prefixes (#7537)
Fixes a few places where we still had leftover `md-` prefixes. Also gets rid of all instances of the `md-24` class in icon examples since it doesn't do anything.
2017-10-06 11:28:29 -07:00
Andrew Seguin 20a23f16e8 fix: remove all md prefixes (#7241) 2017-09-28 13:45:03 -07:00
Ji Won Shin bef6271c61 feat(stepper): Add e2e test (#6776)
* add e2e test for stepper

* create material example to run e2e tests

* Modifiy example
2017-09-06 13:36:07 -07:00
Paul Gschwendtner 5d1ce9f7c1 chore: missing router link in e2e app (#6645)
* Recently more examples have been added to the e2e-app. Those examples haven't been added to the nav bar yet.
2017-08-28 16:29:32 -07:00
Paul Gschwendtner 6df814468c test(): screenshot diff for expansion (#6666)
* Adds the expansion overview example to the e2e app and captures a screenshot diff for it.
* Also adds a e2e test for the button-toggle
2017-08-28 16:28:10 -07:00
Kristiyan Kostadinov 66da5973db feat: update to Angular 4.3 (#6483)
* feat: update to Angular 4.3

* Bumps the Angular requirement to 4.3. This is also a prerequisite to the Angular 5 update since we encountered the same errors there.
* Refactors the sidenav not to use a `Promise.resolve` for toggling the initial animation, because it was making it impossible to flush the animations in unit tests. The new simplified approach uses a property to pass the animation state.
* Fixes the nested menu test failures.
* Fixes a "changed after checked" error in the autocomplete demo app.

Relates to #6454.

* fix: e2e failures
2017-08-16 13:14:12 -07:00
Paul Gschwendtner 2286ad5b98 test(): screenshot diff for button-toggle (#6374)
* Adds the button-toggle overview example to the e2e app and captures a screenshot diff for it.
2017-08-09 14:58:49 -07:00
Paul Gschwendtner 8d09961562 test(): screenshot diff for opened dialog (#6309)
* Creates a screenshot for a simple opened dialog
2017-08-07 10:22:53 -07:00
Paul Gschwendtner fbc0b95758 test(): screenshot diff for toolbar (#6308)
* Adds the toolbar demo to the e2e app and adds a screenshot diff for it.
2017-08-07 10:22:28 -07:00
Kristiyan Kostadinov a882546deb refactor(sidenav): switch to the angular animations API (#4959)
* refactor(sidenav): switch to the angular animations API

Switches the sidenav to use the `@angular/animations` API. This saves us a lot of code that was involved in orchestrating the various animations, in addition to making it easier to follow. It also makes it possible for the consumer to disable the animations by using the `NoopAnimationsModule`.

* chore: remove redundant annotations

* fix: focus restoration issue in IE

* chore: linting error

* chore: put back the toggle animation promises

* fix: avoid initial animation

* fix: sidenav not showing when animation starts

* chore: update e2e tests
2017-07-31 11:05:47 -07:00
mmalerba 0e95c89967 e2e: attempt to fix input screenshot flakes. (#6010) 2017-07-27 09:49:11 -07:00
Kristiyan Kostadinov 89e9621158 chore(sidenav): switch to OnPush change detection (#5731)
Switches the `MdSidenavContainer` to `OnPush` change detection and fixes some changes not being picked up when its sidenav is opened.

Relates to #5035.
2017-07-25 16:26:59 -07:00
mmalerba e0fc5266e8 fix(input): add overflow:hidden when calculating autosize height (#5773) 2017-07-20 10:57:50 -07:00
Jeremy Elbourn d70a669f79 chore: add material-examples to e2e-app (#5735) 2017-07-17 11:14:15 -07:00
Paul Gschwendtner bcf48261f4 fix(checkbox, radio): setting id to null causes invalid id for input (#5398)
* In some situations, developers will change the `id` of a component dynamically. At some point if they set the `[id]` to `null` the input id will look like the following: `null-input`.
* If developers are setting the `id` using a binding then the DOM Id for the host component won't be set at all (because the @Input is triggered instead of the DOM property)

Fixes #5394
2017-07-11 10:09:02 -07:00
robindijkhof 5e961cb221 test(sidenav): add e2e tests (#5463) 2017-07-10 15:24:26 -07:00
Paul Gschwendtner 589dc05149 build: enable no-unused-variable lint rule (#5184)
* Now TSLint starts reporting unused variables again (Rule has been un-deprecated and now uses the type checker
* In favor of linting the whole project the tsconfig file inside of `src/` needs to live in the project root.
2017-07-07 11:42:52 -07:00
robindijkhof 20e704b074 test(input): add textarea e2e test (#5517)
* e2e(input): add textarea e2e test

* test(input): remove fdescribe
2017-07-06 15:53:21 -07:00
Kristiyan Kostadinov 2bf7024527 feat: add support for strict null checks (#5094) 2017-06-21 10:13:52 -07:00
Kristiyan Kostadinov 8e6bee8116 chore: reorganize e2e test files (#5032)
* Renames the e2e test file to match the pattern of `{{component}}-e2e.spec.ts`.
* Flattens the directory structure in the `e2e` directory. Having a separate dir for each component was overkill since only have one file per component.
* Fixes some inconsistent code styles in the Protractor config.

Fixes #5030.
2017-06-09 16:09:08 -07:00
Jeremy Elbourn 657f0e829e fix(icon): remove automatic aria labelling and add a11y guidance (#4665)
The automatic application of aria-label for md-icon, in hindsight, was
not a great idea. Neither the ligature string nor the SVG filename are
likely to be meaningful descriptions. Even in cases where they *are*,
the icon may be used in such a way that the application of a label is
still the wrong thing. On top of that, adding `role="img"` is usually
not the right approach for an icon, as that role typically refers to
*content* images, rather than icons that are part of the UI.

Ultimately, it is up to the application developer to add the appropriate
meaning for icons based on how they're used. To this end, we add
guidance to the documentation for what to do in different situations.
2017-06-08 11:21:52 -07:00
Kristiyan Kostadinov 50f1c266ef refactor: switch e2e tests to async/await (#4705)
* refactor: switch e2e tests to async/await

Switches to using async/await in the e2e tests. This should make it a bit easier to deal with Protractor's async APIs.

* chore: remove the async wrapper
2017-06-01 08:49:20 -07:00
Kristiyan Kostadinov 6842046979 feat(overlay): add scroll blocking strategy (#4500)
Adds the `BlockScrollStrategy` which, when activated, will prevent the user from scrolling. For now it is only used in the dialog.

Relates to #4093.
2017-05-15 14:28:30 -07:00
mmalerba 2db3d61e55 add e2e test that would have caught regression in #3878 (#4207) 2017-04-25 16:41:03 -07:00
Paul Gschwendtner 0560eab12f test(): cleanup screenshot files in e2e-app (#3367) 2017-03-02 16:50:05 -08:00
tinayuangao 537ef17912 Make slide toggle e2e test take screenshots when ripple disappeared (#3171) 2017-02-21 11:37:30 -08:00
tinayuangao 3beccb9e70 feat(e2e): Take screenshots for grid-list, list, icon, menu, radio, tabs, slide-toggle (#3098)
* Update e2e tests, take screenshots when screen become stable

* fix lint

* Make id optional

* Remove screenshot for checkbox with keyboard event

* Fix radio test
2017-02-16 15:43:29 -08:00
Kristiyan Kostadinov a08dc55802 fix(dialog): escape key not working once element loses focus (#3082)
Fixes issue in the dialog that prevented the user from being able to close via the escape key, if any of the elements inside the dialog loses focus.

Fixes #3009.
2017-02-14 16:48:44 -08:00
mmalerba bf0f625ee3 feat(dialog): support open with TemplateRef (#2910)
* feat(dialog): support open with TemplateRef

* add e2e test
2017-02-10 02:32:07 +08:00
Andrew Seguin 210ff020d2 feat(compatibility): remove conflicts with material1 css styling (#2790)
* feat(compatibility): remove conflicts with material1 css styling

* fix tests

* fix input changes

* autocomplete changes

* merge changes

* change class assignment to evaluation

* add back in the line truncate for select

* fix button on simple snackbar

* fix tests
2017-02-09 03:24:31 +08:00
Paul Gschwendtner d9f57001cd build: run tslint against e2e directory (#2945)
* Now runs TSLint also against the e2e/ directory.
* Add comments for the different tasks in the lint file.
* Refactors the screenshot e2e file to pass TSLint and also to be less nested.
2017-02-06 15:00:26 -08:00
Kristiyan Kostadinov 899f190da7 test: add class with e2e test utilities (#2070)
* test: add class with e2e test utilities

* Adds a class that simplifies some common and hard to remember Protractor expressions.
* Refactors the existing tests to use the new utilities.

Fixes #2025.

* Add types to the e2e utils and fix the selector on the dialog tests.

* Remove unnecessary rounding.

* Remove `any` cast.

* Simplify the slide toggle tests.

* Split the E2E utils class into smaller files.

* Fix a leftover.
2017-01-18 14:13:48 -08:00
Paul Gschwendtner 4ab6f30f50 chore(e2e): update to latest protractor version (#2608)
* chore(e2e): update to latest protractor version

* Updates to the latest Protractor version, which now uses Selenium V3
* The new types for Protractor v5 include the fix for the missing `chord` function (See https://github.com/DefinitelyTyped/DefinitelyTyped/commit/123690bb2e0f9dac2371084369a8ecf8976cbb34)
* Methods like `innerHtml` have been removed in Protractor v5 (https://github.com/angular/protractor/blob/master/CHANGELOG.md)

* Test later chromedriver version
2017-01-13 14:59:01 -08:00
tinayuangao 8ba8debeb5 feat(screenshot): Add screenshot function to e2e test (button and checkbox) (#2532)
* Add screenshot function to e2e test (button and checkbox)

* Add reporter for jasmine

* Change directory to constant, and use variable to store name
2017-01-12 13:24:51 -08:00
quanterion 06403028a6 feat(overlay): add fullscreen-enabled overlay class (#1949)
* feat(overlay): add fullscreen overlay class

* fix lint error

* move fs container to a new file and rename it

* add e2e tests

* fix tests

* rebased and fix comments

* fix typings

* fix e2e tests

* address comments

* fix tests
2017-01-10 16:11:55 -08:00