Commit Graph

2144 Commits

Author SHA1 Message Date
Austin 4851dea42e chore(build): add examples to docs build and annotate table examples (#6311) 2017-08-07 10:23:47 -07:00
Paul Gschwendtner 8d09961562 test(): screenshot diff for opened dialog (#6309)
* Creates a screenshot for a simple opened dialog
2017-08-07 10:22:53 -07:00
Paul Gschwendtner fbc0b95758 test(): screenshot diff for toolbar (#6308)
* Adds the toolbar demo to the e2e app and adds a screenshot diff for it.
2017-08-07 10:22:28 -07:00
Kristiyan Kostadinov af67e7c273 build: toggle demo app dark theme for overlay components (#6305)
Fixes the dark theme not being added to overlay-based components.
2017-08-07 10:22:01 -07:00
Paul Gschwendtner 49d6080b09 chore: add cdk table to universal app (#6300)
* Adds the CDK table to the universal app. This ensures that CDK tables can be rendered inside of platform-server.
2017-08-07 10:20:47 -07:00
Paul Gschwendtner 3944d70435 build: deploy screenshot app for push builds (#6299)
* Currently only the screenshot functions are deployed, but not he screenshot application. With this change the application will be also deployed on Travis Push builds.
2017-08-07 10:20:30 -07:00
Paul Gschwendtner 5ecc509763 chore: fix missing types error for screenshot-tool functions (#6286)
The Google Cloud functions for the screenshot-test tool can't be deployed on the CI because there appear to be some errors that indicate that the types for the `jsonwebtoken` package are not installed.

This commit adds the types for the `jsonwebtoken` package to the dependencies (similar as for the dashboard)
2017-08-07 10:19:43 -07:00
Paul Gschwendtner 48d092093d build: fix docs generation highlight files task (#6285)
Recently with https://github.com/angular/material2/commit/edcbb24f11ae776b94d97634ae91e9175ffd6f8a the ambigious variable `path` has been renamed to `filePath`, but there is one remaining instance of `path` that didn't get updated.

This currently causes the docs-content CI job to fail.
2017-08-07 10:19:15 -07:00
Paul Gschwendtner 509e3e90f5 build: fix error when running devapp on windows (#6288)
Currently developers using Windows are not able to serve the devapp because the secondary entry-points can't be resolved. This can happen because of two things:

* `egrep`, which is an alias for `grep -E` is not part of the global `$PATH` variable on Windows
* The Regular Expression for the `grep` call is ambiguous and expects zero-width characters to be present.

This commit changes the `spawnSync` call to use `grep -E` and also changes the Regular Expression to be more explicit about what characters to match after the `from`.
2017-08-07 10:18:48 -07:00
Kristiyan Kostadinov 08509816b2 fix(input): required asterisk being read out by screen readers (#6277)
Fixes the asterisk that gets added after a required input being read out by screen readers.
2017-08-04 16:09:42 -07:00
Kristiyan Kostadinov 3df4d72c28 fix(input): set proper role on md-error (#6259)
Sets the `alert` role on `md-error` instances, causing the messages to be read out properly by screen readers. For reference: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_alert_role
2017-08-04 15:18:52 -07:00
mmalerba 9d3c4050f4 fix(slider): fix change & input emit logic. (#6234) 2017-08-04 15:17:55 -07:00
mmalerba 2af284cd3a fix(input): update aria-describedby to also include errors (#6239)
* fix(input): update aria-describedby to also include errors

* comments addressed

* check for null errorChildren
2017-08-04 15:15:48 -07:00
Will Howell 73c6d8d757 style(expansion): simplify vertical centering in header (#5950) 2017-08-04 15:03:19 -07:00
mmalerba 787a8f0008 demo(slider): add slider a11y demos (#6230)
* demo(slider): add slider a11y demos

* add description text to each example
2017-08-04 15:01:19 -07:00
Jeremy Elbourn f913cc992a chore: don't hard-code cdk build order (#6207)
* chore: don't hard-code cdk build order

* Use BuildPackage

* packagename grep

* fix rollup globals conflict
2017-08-04 14:05:07 -07:00
Paul Gschwendtner c6c7908c29 chore(): fix package dependencies for screenshot-tool app (#6276)
Recently some utilities have been moved from the Material package to the CDK package. At this point Material added the CDK as a peer dependency.

The screenshot-test application uses the most recent (released) Angular Material version (due to the caret in the semver expression) but doesn't have a dependency on the CDK yet.

This commit adds the CDK as a dependency and also switches Material and the CDK to the latest build artifcats on GitHub (as same as for the dashboard).
2017-08-04 14:03:26 -07:00
Paul Gschwendtner 298bc031da ci: incorrect path to screenshot-test tool (#6275)
The deploy script for the screenshot-test tool right now references a incorrect directory. This means that the screenshot-test tool can't be uploaded for push builds right now.
2017-08-04 14:03:08 -07:00
Jeremy Elbourn b0db9122c4 chore: block use of public access modifier outside constructors (#6261) 2017-08-04 14:01:30 -07:00
Kristiyan Kostadinov e86b9649c3 a11y: add autocomplete accessibility demo (#6254)
Adds a demo page for testing the autocomplete accessibility.
2017-08-04 14:01:14 -07:00
Paul Gschwendtner ea6e829239 build: retry attemps for tunnel connections (#6246)
On the CI it happens pretty often that the tunnel connection to the different providers like Browserstack or Saucelabs is timing out.

Instead of always restarting manually, the script should automatically retry to run the connection establishing script.
2017-08-04 14:00:47 -07:00
Paul Gschwendtner 991c1e0d90 chore(tslint): use globs for custom rule source file filtering (#6235)
A few custom TSLint rules already accept an option array that can be used to whitelist specific files. These whitelists are based on normal Regular Expressions which do not work very well for path matching.

This commit changes the existing whitelists to use minimatch, which is a package that allows matching strings/paths against globs. For rules like `requireLicenseBanner` where the whitelist is hardcoded right now, the whitelist has been introduced as well.
2017-08-04 14:00:29 -07:00
Cyrille Tuzi 1af2ce6e17 docs(getting-started): mention importing hammer in same file as bootstrap (#6225)
* docs(hammerjs): new import location for Universal

As mentioned in #308, if hammerjs is imported in AppModule, Universal server-side rendering will fail as hammerjs is a browser specific library using window, document... So it must be imported in browser entry point src/main.ts instead.

* docs(hammerjs): new import location for Universal

As mentioned in #308, if hammerjs is imported in AppModule, Universal server-side rendering will fail as hammerjs is a browser specific library using window, document... So it must be imported in browser entry point src/main.ts instead.
2017-08-04 14:00:09 -07:00
Kristiyan Kostadinov 5967f6e59c fix(dialog): better handling of custom ViewContainerRef with OnPush change detection (#6164)
* Adds a `markForCheck` call after starting the dialog animation, in order to ensure that it animates away if it was opened from a component with OnPush change detection.
* Since we can't know whether the animation will start right after the `markForCheck`, these changes switch to starting the backdrop animation together with the dialog animation. This avoids some slight timing issues where the backdrop can start its animation a little too early.
* Simplifies the dialog animation streams to avoid having to subscribe to the `completed` callback in the `MdDialogRef`.
* Fixes the demo app sidenav jumping to the bottom when it is opened from the homepage.
* Fixes some alignment in the dialog demo that got thrown off by the new input width.

The dialog changes should solve issues like #5118.
2017-08-02 16:17:42 -07:00
Kristiyan Kostadinov 916d1f3bb0 fix(autocomplete,datepicker,menu): closing parent dialog by pressing escape (#6226)
Prevents the autocomplete, datepicker and menu components from closing their parent dialog when the user presses escape.

Fixes #6223.
2017-08-02 16:17:12 -07:00
Andrew Seguin a043bec9da docs(table): simplify first basic example (#6177)
* docs(table): simplify first basic example

* update docs

* export Element
2017-08-02 16:16:09 -07:00
Kristiyan Kostadinov d6f1a8d9bf build: enforce line length in scss files (#6233)
Enforces a 100-character line length in the SCSS files for consistency with the TS.
2017-08-02 16:15:05 -07:00
Paul Gschwendtner 4e6e42ea2f fix(list): properly align contents in subheader (#6221)
* fix(list): properly align contents in subheader

* The line-height of the subheaders is currently based on the typography level. This is problematic because the subheader is set to a specific height and can't grow/shrink accordingly.

Fixes #6214

* Address feedback
2017-08-02 16:14:57 -07:00
Kristiyan Kostadinov 07954325a2 fix(icon): error when toggling icon with binding in IE11 (#6102)
* fix(icon): error when toggling icon with binding in IE11

* Fixes an error that was being logged by IE11 for icons that are toggled via `ngIf` and have a binding expression.
* Some minor readability improvements in the icon component.

Fixes #6093.

* fix: address feedback
2017-08-02 16:14:36 -07:00
Kristiyan Kostadinov 49a0d7b033 fix(expansion-panel): only highlight keyboard-focused panel headers (#6148)
Previously the expansion panel header would be focused if it was toggled by mouse, which makes it appear stuck. These changes switch to only highlighting it if focus came programmatically or through the keyboard.
2017-08-02 15:58:52 -07:00
Kristiyan Kostadinov e4e7ee90f8 fix(autocomplete): placeholder not resetting properly (#6141)
Fixes the following regressions that were introduced by the switch to OnPush change detection:
* The floating placeholder not resetting when the user closes the panel without selecting a value.
* The placeholder overlapping the input value when the autocomplete has a preselected value and `floatPlaceholder="never"`.
2017-08-02 15:57:32 -07:00
Kristiyan Kostadinov a780052090 fix(select): floating label overlapping elements above select (#6228)
Adds some padding to the top of a select, reserving enough space for the floating label.

Fixes #6171.
2017-08-02 15:53:31 -07:00
mmalerba 15b0b43793 demo(input): add input a11y examples (#6181)
* add input a11y examples

* address comments
2017-08-02 15:52:53 -07:00
Kristiyan Kostadinov ce311136ef fix(select): set aria-multiselectable for multi-select (#6110)
Sets the `aria-multiselectable` attribute to multi-select instances, as per https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox.
2017-08-02 15:50:40 -07:00
Andrew Seguin 1748397d83 fix(table): column class names should be css friendly (#6173)
* fix(table): column class names should be css friendly

* rename function

* add to docs, replace with -, make var

* fix test
2017-08-02 15:36:30 -07:00
Kristiyan Kostadinov 953b38e921 fix(paginator): remove dependency on @angular/forms (#6080)
Since it's now possible to use `md-select` without `ngModel`, we can remove the dependency on `@angular/forms` from the paginator.

Fixes #5717.
2017-08-02 15:20:16 -07:00
Kristiyan Kostadinov 57a2f290b1 perf(sidenav): avoid recalculating the inline styles while sidenav is open (#6189)
* Avoids recalculating the sidenav inline styles for every change detection cycle while the sidenav is open by doing it only when an animation starts.
* Removes a few one-liner methods that were being used in one place.
2017-08-02 15:16:07 -07:00
Sargo Darya fa3cf12aa8 docs(datepicker): Add example for setLocale method (#6224)
* docs(datepicker): Add example for setLocale method

Add a usage example to show how the formatting locale of the datepicker can be be changed as that wasn't documented before.

* docs(datepicker): Wording change for setLocale example
2017-08-02 14:34:04 -07:00
Paul Gschwendtner f19d2e52ee chore(tslint): custom rules invoke superclass methods (#6215)
A few rules are not implemented properly because their associated walker is overwriting hooks from the `SyntaxWalker` superclass. Those custom hooks need to invoke the method on the superclass as well.

See https://palantir.github.io/tslint/develop/custom-rules/
2017-08-02 14:33:56 -07:00
Andrew Seguin 2364cfe8ab docs(table): switch to md- prefix (#6175) 2017-08-02 14:32:06 -07:00
Paul Gschwendtner 4168fb39db build: stop hardcoding rollup globals for CDK entry points (#6150)
* Now the rollup globals for the CDK secondary entry-points are no longer hard-coded. There is already a method called `getSecondaryEntryPointsForPackage` which can be used.
2017-08-02 14:31:31 -07:00
tinayuangao 8a23157dc3 a11y(grid-list): Add grid list to accessibility demo page (#6091)
* real world example

* remove roles

* feat: expose version object in releases (#4962)

* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk)
* This is similar as for every @angular package like core, forms, compiler.

Add accessibility demo page for grid list

.

* change header and add roles
2017-08-01 15:12:52 -07:00
Paul Gschwendtner 3a766f148f fix(autosize): properly detect line-height in firefox (#6190)
* fix(autosize): properly detect line-height in firefox

In Firefox it happens that textarea elements are always bigger than the specified amount of rows. This is because Firefox tries to add extra space for the horizontal scrollbar.

As a workaround that removes the extra space for the scrollbar, we can just set overflow to hidden. This ensures that there is no invalid calculation of the line height.

See Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=33654

Fixes #6179

* Fix test name
2017-08-01 15:09:27 -07:00
mmalerba 8bb54ca456 fix(datepicker): validate that input actually parses (#5711)
* fix(datepicker): throw when value is set to invalid type

BREAKING CHANGE: You must now use an actual Date object rather than a
string when setting the value of the datepicker programmatically
(through value, ngModel, or formControl).

* addressed comments

* validate that datepicker input parses

* tweak handling of invalid dates.

* fix tests

* address feedback

* make sure datepicker selected date is valid

* rework validation again

* addressed comments

* fix lint
2017-08-01 15:08:22 -07:00
Kristiyan Kostadinov 0d80a7732c fix(sidenav): container not reacting to changes to sidenavs added after init (#6161)
Fixes the sidenav container not reacting to sidenavs that were added after initialization.

Fixes #6127.
2017-08-01 15:05:49 -07:00
Paul Gschwendtner 68e2f46bf7 fix(input): underline should only be thicker if focused (#6152)
* Currently the underline of the input container is always `2px` thick if the input is invalid. As per specifications the underline should be `1dp/px` if not focused.
2017-08-01 15:05:27 -07:00
Andrew Seguin a1855814d0 compat(sort): add mat-compat inputs (#6172) 2017-08-01 15:04:51 -07:00
Kristiyan Kostadinov 735ffb5f4a fix(checkbox): remove checkmark from tab order (#6137)
Prevents users from being able to tab into the underlying SVG checkmark on IE.

Fixes #6125.
2017-08-01 14:40:07 -07:00
tinayuangao a503e19898 Add more demos in button accessibility demo page (#6099) 2017-08-01 14:39:35 -07:00
mmalerba 7a7ec7a602 demo(datepicker): create demos for datepicker a11y use cases (#6096)
* create demos for datepicker a11y use cases

* address comments

* update datepicker toggle to new API
2017-08-01 14:38:34 -07:00