Commit Graph

4908 Commits

Author SHA1 Message Date
Paul Gschwendtner 0cacbd67d2 build: cronjob cannot install angular snapshot builds (#14332)
Apparently the script that also ran on TravisCI does not work on MacOS, nor on CircleCI because it's not guaranteed that the default awk supports storing match() results in an array that can print individual match groups.
2018-12-04 13:36:30 -08:00
Paul Gschwendtner e9a890a5f4 chore(schematics): use devkit SchematicException for schematic errors (#14355)
* Makes all error throwings in the `cdk/schematics` and `lib/schematics` consistent by using `SchematicsException`. This is recommended by the CLI team so that the CLI can show different error-codes in the future (still planned AFAIK; but we want this change for consistency anyway)
2018-12-04 13:36:04 -08:00
Kristiyan Kostadinov 3f2751f773 chore(datepicker): remove unused svg element (#14235)
Some of the Material design icons include a blank `path` element which doesn't really do anything. These changes remove it from our default datepicker icon.
2018-12-03 15:38:16 -08:00
Kristiyan Kostadinov 8432e804af feat(drag-drop): add the ability to constrain dragging to an element (#14242)
Adds the `cdkDragBoundary` input that allows for people to constrain the dragging of an element to another element.

Fixes #14211.
2018-12-03 15:38:00 -08:00
Kristiyan Kostadinov 7fac91554e fix(stepper): ignoring custom falsy value for hasError (#14337)
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.
These changes also fix one of the test fixtures where an error was being swallowed silently.

Fixes #14333.
2018-12-03 15:33:05 -08:00
Kristiyan Kostadinov b584888909 fix(cdk/stepper): exported injection token referring to Material (#14339)
Fixes the `cdk/stepper` package exporting a symbol that is referring to Material.
2018-12-03 15:32:38 -08:00
Kristiyan Kostadinov f1761191b7 fix(grid-list): allow more units for gutter width and row height (#14341)
Currently the function that normalizes the units only allows `px`, `em` and `rem`. These changes expand it to cover more units.
2018-12-03 15:32:27 -08:00
Kristiyan Kostadinov 166279b912 fix(form-field): long labels and option values going under select arrow (#14268)
Fixes very long form field labels and option value colliding with the arrow that is rendered next to a `select` inside a `mat-form-field`.
2018-12-03 15:31:53 -08:00
Klemen Oslaj dd6065cec4 fix(schematics): two consecutive commas generated (#14371)
When generating any Material schematic with OnPush changeDetection, we get two consecutive commas in component decorator.

Fixes: #14366
2018-12-03 15:31:25 -08:00
Paul Gschwendtner 1e96b01a67 build: create dev-app deploy output in separate directory (#14373)
* This fixes that `serve:devapp` does not work after building the deploy output of the `dev-app` (e.g. when deploying to firebase)
2018-12-03 15:31:05 -08:00
Jeremy Elbourn c28a91efec chore: bump version w/ changelog for master (#14372) 2018-12-03 13:46:40 -08:00
Jeremy Elbourn db155e455e chore: tweak wording for changelog message in stage-release script (#14374)
Also add a newline to the written package.json
2018-12-03 13:41:25 -08:00
Paul Gschwendtner 903a884e2d build: update to angular 7.1.1 (#14352)
Updates to Angular 7.1.1 so that we can take advantage of https://github.com/angular/angular/commit/b9c7da65038912af5df7f531267c14ea2e18c162
2018-12-03 10:49:57 -08:00
Paul Gschwendtner 3982e9edfd build: ensure ci is passing when staging release (#14340) 2018-11-30 17:33:40 -08:00
Kristiyan Kostadinov bb6c956378 build: bump stylelint version (#14343)
We were a few minor versions behind on `stylelint`. These changes update to the latest so we don't end up missing some new warnings.
2018-11-30 17:30:58 -08:00
Paul Gschwendtner 0b19b586d8 build: bazel repository cache not updated on ci (#14326) 2018-11-29 15:48:54 -08:00
Paul Gschwendtner 94ad518b09 build: fix cronjob tests not running against snapshots (#14327)
* Due to the fact that the `CIRCLE_WORKFLOW_ID` does not actually return the name of the workflow, but a unique id that is generated dynamically, the cronjob does not run against the Angular github builds.
2018-11-29 15:47:51 -08:00
Paul Gschwendtner bb19dfc685 build: highlight example sources files with bazel (#14325)
Part of #13454
2018-11-29 15:46:46 -08:00
Gabriel Caruana 6347ace05e docs(table): add toggling to expandable rows example (#13897) 2018-11-29 07:44:29 -08:00
Kristiyan Kostadinov 4a7cb2b8ca fix(checkbox): poor color contrast for disabled checkbox (#14044)
Fixes some poor color contrast on the text of a disabled checkbox. The issue comes from the fact that it was using a custom color rather than the one from theme.
2018-11-29 07:36:56 -08:00
Kristiyan Kostadinov 1c74b034c9 perf(drag-drop): remove expensive style recalculation (#14189)
Removes an expensive style recalculation of the entire body from `drag-drop`. The issue that the code was solving isn't very common (the user starts dragging and then they yank their cursor out of the edge of the screen on Safari) and when it happens, things will generally still work.
2018-11-29 07:34:43 -08:00
Kristiyan Kostadinov e5cd530bda fix(tabs): blurry text in scrolled header on some browsers (#14303)
Rounds the `transform` value when scrolling a paginated tab header, in order to avoid blurriness in some browsers.
2018-11-29 07:24:08 -08:00
Lars Gyrup Brink Nielsen 287f134f73 docs(tree): fix nested tree node example markup (#14305) 2018-11-29 07:23:57 -08:00
Kristiyan Kostadinov 2e7a03962e fix(list): don't handle events when modifier key is pressed (#14313)
Doesn't `preventDefault` and handle ENTER/SPACE/HOME/END keyboard events when a modifier is pressed, in order to avoid clashing with native OS shortcuts.
2018-11-29 07:22:59 -08:00
Paul Gschwendtner bd9645edae build: markdown-to-html rule should apply docs-specific transforms (#14315)
Currently when building the overview and guide files with Bazel, the following things are missing:

* Replacing `<!-- example` comments with the corresponding HTML elements
* Wrapping the HTML output with a `<div class="docs-markdown">` element
* Rewriting relative links to the proper public guide URL.
* Convert headings to "anchored" headings that can be referenced through URL fragments.

All of these points are handled with this commit.
2018-11-28 16:16:03 -08:00
Kristiyan Kostadinov 47e7aac6da fix(slide-toggle): label not being read out by JAWS (#14304)
Along the same lines as #4610. Adds an extra element to allow for JAWS to pick up the label.
2018-11-28 08:00:28 -08:00
Kristiyan Kostadinov 42de6a2c98 feat(drag-drop): indicate in dropped event whether item was dropped outside of container (#14140)
Adds an extra flag on the `CdkDragDrop` event that indicates whether the user's pointer was over the container when they dropped an item.

Fixes #14136.
2018-11-28 07:56:29 -08:00
Kristiyan Kostadinov acaed95b0d fix(tabs): avoid hitting change detection if text content hasn't changed (#14251)
Currently we trigger a change detection run when the content of the tab header changes. Since the `MutationObserver` callback can fire if the text node got swapped out, but the actual text didn't change, we could get into an infinite change detection loop if a poorly constructed data binding is used. These changes add a check that will only do extra work if the content has changed.

Fixes #14249.
2018-11-28 07:53:27 -08:00
Kristiyan Kostadinov 50b9da6a61 fix(drag-drop): dragged elements blurry in some browsers (#14299)
Rounds the `transform` value before they're assigned, in order to avoid blurriness in some browsers.

Fixes #14283.
2018-11-28 07:53:01 -08:00
Kristiyan Kostadinov 7accba5e46 fix(a11y): don't handle disallowed modifier keys in typeahead mode (#14301)
Recently we switched to skip handling keyboard events with modifiers, unless the consumer opted into them explicitly. The changes weren't applied when in typeahead mode.

Fixes #14274.
2018-11-28 07:52:50 -08:00
Paul Gschwendtner ee45aabb99 fix(ng-add): do not throw if custom builder is used for "test" (#14203)
* No longer throws an exception if someone runs `ng-add` but uses a custom builder for the `test` target. Since theme files are not necessarily mandatory for running tests, we should just show a warning instead of exiting the whole `ng-add` process.

Fixes #14176
2018-11-27 16:10:01 -08:00
Paul Gschwendtner 57fa085543 chore: move update-schematic.md to cdk schematics (#14252)
* Since the CDK now contains the code-foundation for `ng-update`, the explanation/description document should live there.
* Wraps the markdown lines, so that it's easier to make changes.
2018-11-27 15:49:14 -08:00
Paul Gschwendtner b6b72924ab build: transform overview markdown files with bazel (#14300) 2018-11-27 13:25:08 -08:00
Kristiyan Kostadinov 4cda0f3404 fix(cdk-experimental/dialog): not completing lifecycle observables (#14180)
Fixes the CDK dialog not completing the various one-time observables that are tied to its lifecycle.
2018-11-27 13:05:47 -08:00
Paul Gschwendtner 2540b82462 build: no longer load rxjs files individually (#14237)
* No longer loads all rxjs files individually when serving the dev-app. Now uses the UMD bundle which should speed up the initial loading of the dev-app with Gulp.
2018-11-27 13:05:33 -08:00
Paul Gschwendtner 9ccda9465b build: allow jumping to base class of api class (#14232)
References #14122
2018-11-27 13:04:43 -08:00
Paul Gschwendtner 6a6646bb2a docs: remove internal build fixes from changelog (#14224)
* docs: remove internal build fixes from changelog

* https://github.com/angular/material2/commit/d0d97c3 has been accidentally marked as `fix` while it should be `build`.
* https://github.com/angular/material2/commit/a22a9fa has been re-added because we removed it manually from the changelog version (see [deduping logic](https://github.com/angular/material2/blob/master/tools/gulp/tasks/changelog.ts#L90))
* https://github.com/angular/material2/commit/985774a Same as for the commit above
* https://github.com/angular/material2/commit/150c964 Is _not_ a fix, and actually still internal because we miss documentation etc.

* Remove unrelated whitespace change
2018-11-27 13:03:21 -08:00
Paul Gschwendtner 2633c7cffd build: setup cronjob to run tests against angular snapshots (#14217)
* Sets up a cronjob workflow that runs the local browser tests against the Angular Github snapshot builds at midnight everyday.
* No longer saves cache multiple times. This can cause unexpected behavior.
* Sorts jobs in `config.yml` to group all `tests_XX` jobs.

Closes #12516.
2018-11-27 13:02:22 -08:00
Paul Gschwendtner 50bf6f14a5 build: provide better defaults for browser-sync (#14296)
* No longer opens the browser by default
* No longer enables ghost mode by default
* No longer shows the `Connected to Browsersync` notification. This might throw off e2e test results.
2018-11-27 12:49:59 -08:00
Paul Gschwendtner 141afcfa6e build: switch to browser-sync (#14295)
Switches the gulp-connect dev-server to browser-sync
2018-11-27 09:17:13 -08:00
Paul Gschwendtner a08ae9a52e build: better sharing of material test utilities (#13885)
* The slide toggle tests no longer import the test gesture config from `../slider/`
* The datepicker month constants from `@angular/material/core` have been moved to `lib/testing`. The old export from `core` will be kept for backwards compatibility until V8
2018-11-27 07:49:59 -08:00
Joey Perrott 0e029edd14 chore(option): use the top level font-family value from config for mat-option font-family (#14072) 2018-11-27 07:48:47 -08:00
Kristiyan Kostadinov 09dec490ea fix(stepper): showing hover state after tap on touch devices (#14074)
Fixes the `:hover` state of the step header lingering on the element after a tap on a touch device.
2018-11-27 07:47:58 -08:00
Kristiyan Kostadinov d5352d3690 fix(form-field): error when native select has no options (#14102)
Fixes an error being thrown when there's a native `select` without any options inside a `mat-form-field`.

Fixes #14101.
2018-11-27 07:45:18 -08:00
Kristiyan Kostadinov db7491c8b0 fix(drag-drop): only add top-level drop lists to drop group (#14130)
Currently all drop lists will add themselves to the closest group that is resolved through DI. This can lead to some weird results where a parent list and a list inside it will be grouped automatically. These changes rework the way the group is provided in order to prevent it from bleeding into child lists.
2018-11-27 07:44:24 -08:00
Kristiyan Kostadinov d8cd6a788b fix(scrolling): default to vertical CSS class for invalid orientation (#14145)
Since there are some structural styles that depend on the `cdk-virtual-scroll-orientation-*` classes, it's important that at least one of them is on the element at any time. Currently the user can end up with none if they did something like `orientation="horizontal-with-a-typo"`. These changes default to vertical, unless the value is `horizontal` which mirrors all the internal logic.
2018-11-27 07:40:09 -08:00
Kristiyan Kostadinov 18ef94f342 fix(menu): allow alternate roles to be set on menu item (#14165)
Based on the a11y guidelines, the menu items can have the `menuitemradio` and `menuitemcheckbox` roles, instead of `menuitem`. These changes allow for the consumer to set an alternate role.

Fixes #14163.
2018-11-27 07:33:00 -08:00
Kristiyan Kostadinov f00c8a82d0 fix(scrolling): provide virtual scroll viewport as scrollable (#14168)
Since the `CdkVirtualScrollViewport` extends `CdkScrollable`, it should also provide itself as a `CdkScrollable` to DI.
2018-11-27 07:32:29 -08:00
Ricardo M b448bc8934 docs(ripple): fix typo in comments (#14286) 2018-11-27 07:32:05 -08:00
Kristiyan Kostadinov 5430e7cca5 refactor: clean up unsafe takeUntil usages (#14185)
Cleans up some usages of `takeUntil` which are unsafe, because they're not at the end of the operator chain.
2018-11-27 07:26:27 -08:00