skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(paginator): fix off-by-one error (#9604)

Browse Source 
Whilst there are 10 pages they are starting from index 0 and therefore the last page is in fact index 9.
This error was repeated both in the length calculation and in the assertion statements, therefore the
test passed when it should have failed.

Discovered in #9278
This commit is contained in:
Luke Harries
2018-01-25 20:18:29 +00:00
committed by Jeremy Elbourn
parent 2f579b33aa
commit fac08f3790
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/paginator/paginator.spec.ts
+4 -4
View File
@@ -125,17 +125,17 @@ describe('MatPaginator', () => {
expect(component.latestPageEvent ? component.latestPageEvent.pageIndex : null).toBe(0);
});
it('should disable navigating to the next page if at first page', () => {
it('should disable navigating to the next page if at last page', () => {
component.goToLastPage();
fixture.detectChanges();
expect(paginator.pageIndex).toBe(10);
expect(paginator.pageIndex).toBe(9);
expect(paginator.hasNextPage()).toBe(false);
component.latestPageEvent = null;
dispatchMouseEvent(getNextButton(fixture), 'click');
expect(component.latestPageEvent).toBe(null);
expect(paginator.pageIndex).toBe(10);
expect(paginator.pageIndex).toBe(9);
});
it('should disable navigating to the previous page if at first page', () => {
@@ -310,7 +310,7 @@ class MatPaginatorApp {
@ViewChild(MatPaginator) paginator: MatPaginator;
goToLastPage() {
this.pageIndex = Math.ceil(this.length / this.pageSize);
this.pageIndex = Math.ceil(this.length / this.pageSize) - 1;
}
}