skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(compiler-cli): extract error documentation base url into separate file (#43527)

Browse Source 
Prior refactorings caused unexpected g3 sync issues due to a patch that
changes the error documentation URL. This commit moves the base url into
a separate file to make this more apparent.

PR Close #43527
This commit is contained in:
JoostK
2021-10-02 22:09:17 +02:00
committed by Jessica Janiuk
parent 8e13c351ac
commit fa7693f784
5 changed files with 35 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/compiler-cli/src/ngtsc/diagnostics/index.ts
+2 -1
View File
@@ -6,7 +6,8 @@
* found in the LICENSE file at https://angular.io/license
*/
export {COMPILER_ERRORS_WITH_GUIDES, ERROR_DETAILS_PAGE_BASE_URL} from './src/docs';
export {COMPILER_ERRORS_WITH_GUIDES} from './src/docs';
export {FatalDiagnosticError, isFatalDiagnosticError, makeDiagnostic, makeRelatedInformation} from './src/error';
export {ErrorCode} from './src/error_code';
export {ERROR_DETAILS_PAGE_BASE_URL} from './src/error_details_base_url';
export {ngErrorCode, replaceTsWithNgInErrors} from './src/util';
packages/compiler-cli/src/ngtsc/diagnostics/src/docs.ts
-7
View File
@@ -8,13 +8,6 @@
import {ErrorCode} from './error_code';
/**
* Base URL for the error details page.
* Keep this value in sync with a similar const in
* `packages/core/src/render3/error_code.ts`.
*/
export const ERROR_DETAILS_PAGE_BASE_URL = 'https://angular.io/errors';
/**
* Contains a set of error messages that have detailed guides at angular.io.
* Full list of available error guides can be found at https://angular.io/errors
packages/compiler-cli/src/ngtsc/diagnostics/src/error_details_base_url.ts
+16
View File
@@ -0,0 +1,16 @@
/**
* @license
* Copyright Google LLC All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
/**
* Base URL for the error details page.
*
* Keep the files below in full sync:
* - packages/compiler-cli/src/ngtsc/diagnostics/src/error_details_base_url.ts
* - packages/core/src/render3/error_details_base_url.ts
*/
export const ERROR_DETAILS_PAGE_BASE_URL = 'https://angular.io/errors';
packages/core/src/render3/error_code.ts
+1 -4
View File
@@ -6,10 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
// Base URL for the error details page.
// Keep this value in sync with a similar const in
// `packages/compiler-cli/src/ngtsc/diagnostics/src/docs.ts`.
const ERROR_DETAILS_PAGE_BASE_URL = 'https://angular.io/errors';
import {ERROR_DETAILS_PAGE_BASE_URL} from './error_details_base_url';
export const enum RuntimeErrorCode {
// Internal Errors
packages/core/src/render3/error_details_base_url.ts
+16
View File
@@ -0,0 +1,16 @@
/**
* @license
* Copyright Google LLC All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
/**
* Base URL for the error details page.
*
* Keep the files below in full sync:
* - packages/compiler-cli/src/ngtsc/diagnostics/src/error_details_base_url.ts
* - packages/core/src/render3/error_details_base_url.ts
*/
export const ERROR_DETAILS_PAGE_BASE_URL = 'https://angular.io/errors';