skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(compiler): properly sanitize identifier names in template pipeline

Browse Source 
Currently, a listener on an element containing a dash, will result in
runtime errors because the function name will be generated using a dash.

e.g.

```
function MyApp_Template_some-comp_bla_0() {}
```

throwing with a syntax error due to the dash. We fix this by re-using
the sanitize identifier function from the current template definition
builder.
This commit is contained in:
Paul Gschwendtner
2023-07-05 13:11:39 +00:00
parent a4cb2e671c
commit f70d80c8c7
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/compiler/src/template/pipeline/src/phases/naming.ts
+5 -6
View File
@@ -6,8 +6,8 @@
* found in the LICENSE file at https://angular.io/license
*/
import {sanitizeIdentifier} from '../../../../parse_util';
import * as ir from '../../ir';
import type {ComponentCompilation, ViewCompilation} from '../compilation';
/**
@@ -22,7 +22,7 @@ export function phaseNaming(cpl: ComponentCompilation): void {
function addNamesToView(view: ViewCompilation, baseName: string, state: {index: number}): void {
if (view.fnName === null) {
view.fnName = `${baseName}_Template`;
view.fnName = sanitizeIdentifier(`${baseName}_Template`);
}
// Keep track of the names we assign to variables in the view. We'll need to propagate these
@@ -38,7 +38,8 @@ function addNamesToView(view: ViewCompilation, baseName: string, state: {index:
if (op.slot === null) {
throw new Error(`Expected a slot to be assigned`);
}
op.handlerFnName = `${view.fnName}_${op.tag}_${op.name}_${op.slot}_listener`;
op.handlerFnName =
sanitizeIdentifier(`${view.fnName}_${op.tag}_${op.name}_${op.slot}_listener`);
}
break;
case ir.OpKind.Variable:
@@ -49,9 +50,7 @@ function addNamesToView(view: ViewCompilation, baseName: string, state: {index:
if (op.slot === null) {
throw new Error(`Expected slot to be assigned`);
}
// TODO: properly escape the tag name.
const safeTagName = op.tag.replace('-', '_');
addNamesToView(childView, `${baseName}_${safeTagName}_${op.slot}`, state);
addNamesToView(childView, `${baseName}_${op.tag}_${op.slot}`, state);
break;
}
}