skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "refactor(compiler-cli): remove MethodIdentifier type (#49611)" (#52174)

Browse Source 
This reverts commit c2b1a242e8.

PR Close #52174
This commit is contained in:
Pawel Kozlowski
2023-10-12 12:16:07 +02:00
parent 5f2a33ac58
commit f52eee8eb2
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/compiler-cli/src/ngtsc/indexer/src/api.ts
+10 -1
View File
@@ -15,6 +15,7 @@ import {ClassDeclaration, DeclarationNode} from '../../reflection';
*/
export enum IdentifierKind {
Property,
Method, // TODO: No longer being used. To be removed together with `MethodIdentifier`.
Element,
Template,
Attribute,
@@ -46,6 +47,14 @@ export interface PropertyIdentifier extends ExpressionIdentifier {
kind: IdentifierKind.Property;
}
/**
* Describes a method accessed in a template.
* @deprecated No longer being used. To be removed.
*/
export interface MethodIdentifier extends ExpressionIdentifier {
kind: IdentifierKind.Method;
}
/** Describes an element attribute in a template. */
export interface AttributeIdentifier extends TemplateIdentifier {
kind: IdentifierKind.Attribute;
@@ -105,7 +114,7 @@ export interface VariableIdentifier extends TemplateIdentifier {
* they were discovered in.
*/
export type TopLevelIdentifier = PropertyIdentifier|ElementIdentifier|TemplateNodeIdentifier|
ReferenceIdentifier|VariableIdentifier;
ReferenceIdentifier|VariableIdentifier|MethodIdentifier;
/**
* Describes the absolute byte offsets of a text anchor in a source code.
packages/compiler-cli/src/ngtsc/indexer/src/template.ts
+2 -2
View File
@@ -9,7 +9,7 @@ import {AST, ASTWithSource, BoundTarget, ImplicitReceiver, ParseSourceSpan, Prop
import {ClassDeclaration, DeclarationNode} from '../../reflection';
import {AbsoluteSourceSpan, AttributeIdentifier, ElementIdentifier, IdentifierKind, PropertyIdentifier, ReferenceIdentifier, TemplateNodeIdentifier, TopLevelIdentifier, VariableIdentifier} from './api';
import {AbsoluteSourceSpan, AttributeIdentifier, ElementIdentifier, IdentifierKind, MethodIdentifier, PropertyIdentifier, ReferenceIdentifier, TemplateNodeIdentifier, TopLevelIdentifier, VariableIdentifier} from './api';
import {ComponentMeta} from './context';
/**
@@ -21,7 +21,7 @@ interface HTMLNode extends TmplAstNode {
name?: string;
}
type ExpressionIdentifier = PropertyIdentifier;
type ExpressionIdentifier = PropertyIdentifier|MethodIdentifier;
type TmplTarget = TmplAstReference|TmplAstVariable;
type TargetIdentifier = ReferenceIdentifier|VariableIdentifier;
type TargetIdentifierMap = Map<TmplTarget, TargetIdentifier>;