skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(devtools): make sure we dont access position of an undefined parent

Browse Source
This commit is contained in:
mgechev
2020-03-17 16:04:29 -07:00
committed by Sumit Arora
parent 56fbbd5ebd
commit e74dc9e70d
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/directive-forest.component.ts
+11 -4
View File
@@ -119,12 +119,19 @@ export class DirectiveForestComponent {
populateParents(position: ElementPosition): void {
this.parents = position.reduce((nodes: FlatNode[], index: number) => {
let nodeId = [index];
let nodePosition = [index];
if (nodes.length > 0) {
nodeId = nodes[nodes.length - 1].position.concat(index);
nodePosition = nodes[nodes.length - 1].position.concat(index);
}
// It's possible selectedNode to be undefined
// In this case, we don't want to push it to the list
// of parent nodes. Instead, we want to report a warning.
const selectedNode = this.dataSource.data.find(item => item.position.toString() === nodePosition.toString());
if (selectedNode) {
nodes.push(selectedNode);
} else {
console.warn('Cant find node for position', nodePosition);
}
const selectedNode = this.dataSource.data.find(item => item.position.toString() === nodeId.toString());
nodes.push(selectedNode);
return nodes;
}, []);
}