skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix closure compiler warning in ripple (#1904)

Browse Source
This commit is contained in:
Jeremy Elbourn
2016-11-17 09:50:30 -08:00
committed by Kara
parent c54617c453
commit e3830b4fd6
1 changed files with 10 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/core/ripple/ripple-renderer.ts
+10 -22
View File
@@ -42,6 +42,7 @@ export class RippleRenderer {
private _backgroundDiv: HTMLElement;
private _rippleElement: HTMLElement;
private _triggerElement: HTMLElement;
_opacity: string;
constructor(_elementRef: ElementRef, private _eventHandlers: Map<string, (e: Event) => void>) {
this._rippleElement = _elementRef.nativeElement;
@@ -50,9 +51,7 @@ export class RippleRenderer {
this._backgroundDiv = null;
}
/**
* Creates the div for the ripple background, if it doesn't already exist.
*/
/** Creates the div for the ripple background, if it doesn't already exist. */
createBackgroundIfNeeded() {
if (!this._backgroundDiv) {
this._backgroundDiv = document.createElement('div');
@@ -81,16 +80,12 @@ export class RippleRenderer {
}
}
/**
* Installs event handlers on the host element of the md-ripple directive.
*/
/** Installs event handlers on the host element of the md-ripple directive. */
setTriggerElementToHost() {
this.setTriggerElement(this._rippleElement);
}
/**
* Removes event handlers from the current trigger element if needed.
*/
/** Removes event handlers from the current trigger element if needed. */
clearTriggerElement() {
this.setTriggerElement(null);
}
@@ -137,7 +132,8 @@ export class RippleRenderer {
rippleDiv.style.transitionDuration = `${fadeInSeconds}s`;
// https://timtaubert.de/blog/2012/09/css-transitions-for-dynamically-created-dom-elements/
window.getComputedStyle(rippleDiv).opacity;
// Store the opacity to prevent this line as being seen as a no-op by optimizers.
this._opacity = window.getComputedStyle(rippleDiv).opacity;
rippleDiv.classList.add('md-ripple-fade-in');
// Clearing the transform property causes the ripple to animate to its full size.
@@ -149,33 +145,25 @@ export class RippleRenderer {
(event: TransitionEvent) => transitionEndCallback(ripple, event));
}
/**
* Fades out a foreground ripple after it has fully expanded and faded in.
*/
/** Fades out a foreground ripple after it has fully expanded and faded in. */
fadeOutForegroundRipple(ripple: Element) {
ripple.classList.remove('md-ripple-fade-in');
ripple.classList.add('md-ripple-fade-out');
}
/**
* Removes a foreground ripple from the DOM after it has faded out.
*/
/** Removes a foreground ripple from the DOM after it has faded out. */
removeRippleFromDom(ripple: Element) {
ripple.parentElement.removeChild(ripple);
}
/**
* Fades in the ripple background.
*/
/** Fades in the ripple background. */
fadeInRippleBackground(color: string) {
this._backgroundDiv.classList.add('md-ripple-active');
// If color is not set, this will default to the background color defined in CSS.
this._backgroundDiv.style.backgroundColor = color;
}
/**
* Fades out the ripple background.
*/
/** Fades out the ripple background. */
fadeOutRippleBackground() {
if (this._backgroundDiv) {
this._backgroundDiv.classList.remove('md-ripple-active');