skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(e2e): fix consistent timeouts (#6574)

Browse Source
This commit is contained in:
Jeremy Elbourn
2017-08-22 10:53:15 -07:00
committed by Kara
parent 9904e5605c
commit e0b1094d62
1 changed files with 39 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/gulp/tasks/screenshots.ts
+39 -7
View File
@@ -45,14 +45,46 @@ task('screenshots', () => {
const firebaseApp = connectFirebaseScreenshots();
const database = firebaseApp.database();
// If this task hasn't completed in 8 minutes, close the firebase connection.
const timeoutId = setTimeout(() => {
console.error('Screenshot tests did not finish in 8 minutes, closing Firebase connection.');
return firebaseApp.delete();
}, 60 * 1000 * 8);
let lastActionTime = Date.now();
return uploadTravisJobInfo(database, prNumber)
.then(() => downloadGoldScreenshotFiles(database))
.then(() => compareScreenshotFiles(database, prNumber))
.then(passedAll => setPullRequestResult(database, prNumber, passedAll))
.then(() => uploadScreenshotsData(database, 'diff', prNumber))
.then(() => uploadScreenshotsData(database, 'test', prNumber))
.catch((err: any) => console.error(err))
.then(() => firebaseApp.delete());
.then(() => {
console.log(` Downloading screenshot golds from Firebase...`);
lastActionTime = Date.now();
return downloadGoldScreenshotFiles(database);
})
.then(() => {
console.log(` Downloading golds done (took ${Date.now() - lastActionTime}ms)`);
console.log(` Comparing screenshots golds to test result screenshots...`);
lastActionTime = Date.now();
return compareScreenshotFiles(database, prNumber);
})
.then(passedAll => {
console.log(` Comparison done (took ${Date.now() - lastActionTime}ms)`);
console.log(` Uploading screenshot diff results to Firebase and GitHub...`);
lastActionTime = Date.now();
return Promise.all([
setPullRequestResult(database, prNumber, passedAll),
uploadScreenshotsData(database, 'diff', prNumber),
uploadScreenshotsData(database, 'test', prNumber),
]);
})
.then(() => {
console.log(` Uploading results done (took ${Date.now() - lastActionTime}ms)`);
firebaseApp.delete();
clearTimeout(timeoutId);
})
.catch((err: any) => {
console.error(` Screenshot tests encountered an error!`);
console.error(err);
firebaseApp.delete();
clearTimeout(timeoutId);
});
}
});