skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(connected-position-strategy): wrong logic when determining whether element is on screen (#2677)

Browse Source 
Fixes some faulty logic, introduced in #2102, that meant that the overlay considers the viewport's scroll offset when determining how much it overflows on either side.

Fixes #2658.
This commit is contained in:
Kristiyan Kostadinov
2017-01-18 06:23:38 +01:00
committed by mmalerba
parent 29f939ad3d
commit e055d05469
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/core/overlay/position/connected-position-strategy.ts
+4 -4
View File
@@ -255,10 +255,10 @@ export class ConnectedPositionStrategy implements PositionStrategy {
let y = originPoint.y + overlayStartY + this._offsetY;
// How much the overlay would overflow at this position, on each side.
let leftOverflow = viewportRect.left - x;
let rightOverflow = (x + overlayRect.width) - viewportRect.right;
let topOverflow = viewportRect.top - y;
let bottomOverflow = (y + overlayRect.height) - viewportRect.bottom;
let leftOverflow = 0 - x;
let rightOverflow = (x + overlayRect.width) - viewportRect.width;
let topOverflow = 0 - y;
let bottomOverflow = (y + overlayRect.height) - viewportRect.height;
// Visible parts of the element on each axis.
let visibleWidth = this._subtractOverflows(overlayRect.width, leftOverflow, rightOverflow);