skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix gulp-utils color issue (#8030)

Browse Source 
With (DefinitelyTyped #21004) the typings for @gulp-utils are declaring `chalk` as dependency of the types. This causes a conflict with the types from chalk and gulp fails everywhere in the CI. (https://github.com/DefinitelyTyped/DefinitelyTyped/issues/21004)

A possible solution would be locking the version of the gulp-util types to the working version `3.0.31`.

As `gulp-utils` is only used in one place right now, we are just remove the `gulp-utils` import and just use `console.log` as everywhere else.
This commit is contained in:
Paul Gschwendtner
2017-10-27 19:19:25 +02:00
committed by mmalerba
parent 473b1dfafd
commit dc1bf54e28
3 changed files with 731 additions and 316 deletions
Download Patch File Download Diff File Expand all files Collapse all files
package-lock.json
Generated
+720 -303
View File
File diff suppressed because it is too large Load Diff
package.json
+10 -11
View File
@@ -40,18 +40,17 @@
},
"devDependencies": {
"@angular/compiler-cli": "~4.4.4",
"@angular/http": "~4.4.4",
"@angular/platform-browser-dynamic": "~4.4.4",
"@angular/platform-server": "~4.4.4",
"@angular/router": "~4.4.4",
"@angular/tsc-wrapped": "~4.4.4",
"@angular/http": "~4.4.4",
"@google-cloud/storage": "^1.1.1",
"@types/chalk": "^0.4.31",
"@types/fs-extra": "^3.0.1",
"@types/glob": "^5.0.30",
"@types/fs-extra": "^4.0.3",
"@types/glob": "^5.0.33",
"@types/gulp": "3.8.32",
"@types/gulp-util": "^3.0.31",
"@types/hammerjs": "^2.0.34",
"@types/hammerjs": "^2.0.35",
"@types/jasmine": "2.5.45",
"@types/merge2": "^0.3.30",
"@types/minimist": "^1.2.0",
@@ -98,25 +97,25 @@
"karma-jasmine": "^1.1.0",
"karma-sauce-launcher": "^1.2.0",
"karma-sourcemap-loader": "^0.3.7",
"madge": "^1.6.0",
"magic-string": "^0.21.3",
"madge": "^2.2.0",
"magic-string": "^0.22.4",
"minimatch": "^3.0.4",
"minimist": "^1.2.0",
"moment": "^2.18.1",
"node-sass": "^4.5.3",
"protractor": "^5.1.2",
"request": "^2.81.0",
"protractor": "^5.2.0",
"request": "^2.83.0",
"resolve-bin": "^0.4.0",
"rollup": "^0.41.6",
"rollup-plugin-alias": "^1.3.1",
"rollup-plugin-node-resolve": "^3.0.0",
"run-sequence": "^1.2.2",
"scss-bundle": "^2.0.1-beta.7",
"selenium-webdriver": "^3.4.0",
"selenium-webdriver": "^3.6.0",
"sorcery": "^0.10.0",
"stylelint": "^7.12.0",
"ts-node": "^3.0.4",
"tsconfig-paths": "^2.2.0",
"tsconfig-paths": "^2.3.0",
"tslint": "^5.8.0",
"tsutils": "^2.6.0",
"typescript": "~2.4.2",
tools/gulp/tasks/lint.ts
+1 -2
View File
@@ -1,7 +1,6 @@
import {red} from 'chalk';
import {readdirSync, readFileSync, statSync} from 'fs';
import {task} from 'gulp';
import {colors, log} from 'gulp-util';
import {buildConfig} from 'material2-build-tools';
import {IMinimatch, Minimatch} from 'minimatch';
import {join} from 'path';
@@ -87,7 +86,7 @@ task('ownerslint', () => {
// Report an error for any files that didn't match any owned paths.
.filter(path => {
if (statSync(path).isFile()) {
log(colors.red(`No code owner found for "${path}".`));
console.log(red(`No code owner found for "${path}".`));
errors++;
return false;
}