skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(devtools): rename state to properties (rangle/angular-devtools#682)

Browse Source
This commit is contained in:
Emma Twersky
2021-04-14 11:52:26 -07:00
committed by GitHub
parent c5445440bf
commit da0ce975f8
4 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cypress/integration/node-search.e2e.js
+1 -1
View File
@@ -83,7 +83,7 @@ describe('Search items in component tree', () => {
checkComponentName('app-todos');
// should display correct title for properties panel
cy.get('ng-property-view-header').should('have.text', 'Properties of app-todos ');
cy.get('ng-property-view-header').should('have.text', 'app-todos');
// should show correct component properties
cy.get('ng-property-view').find('mat-tree-node');
cypress/integration/property-edit.e2e.js
+4 -6
View File
@@ -14,7 +14,7 @@ describe('edit properties of directive in the property view tab', () => {
getBody().find('app-todo input.edit').should('not.be.visible');
});
cy.get('.explorer-panel:contains("Properties of app-todo")')
cy.get('.explorer-panel:contains("app-todo")')
.find('ng-property-view mat-tree-node:contains("editMode")')
.find('ng-property-editor .editor')
.click({ force: true })
@@ -31,9 +31,7 @@ describe('edit properties of directive in the property view tab', () => {
describe('edit todo property', () => {
beforeEach(() => {
// expand todo state
cy.get('.explorer-panel:contains("Properties of app-todo")')
.find('ng-property-view mat-tree-node:contains("todo")')
.click();
cy.get('.explorer-panel:contains("app-todo")').find('ng-property-view mat-tree-node:contains("todo")').click();
});
it('should change todo label in app when edited', () => {
@@ -43,7 +41,7 @@ describe('edit properties of directive in the property view tab', () => {
});
// find label variable and run through edit logic
cy.get('.explorer-panel:contains("Properties of app-todo")')
cy.get('.explorer-panel:contains("app-todo")')
.find('ng-property-view mat-tree-node:contains("label")')
.find('ng-property-editor .editor')
.click()
@@ -65,7 +63,7 @@ describe('edit properties of directive in the property view tab', () => {
});
// find completed variable and run through edit logic
cy.get('.explorer-panel:contains("Properties of app-todo")')
cy.get('.explorer-panel:contains("app-todo")')
.find('ng-property-view mat-tree-node:contains("completed")')
.find('ng-property-editor .editor')
.click()
projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-tab-body/property-view/property-view-body/property-view-body.component.ts
+1 -1
View File
@@ -35,7 +35,7 @@ export class PropertyViewBodyComponent {
controls: this.directiveOutputControls,
},
{
title: 'State',
title: 'Properties',
hidden: this.directiveStateControls.dataSource.data.length === 0,
controls: this.directiveStateControls,
},
projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-tab-body/property-view/property-view-header/property-view-header.component.html
+1 -1
View File
@@ -1 +1 @@
<mat-toolbar>Properties of {{ directive }} </mat-toolbar>
<mat-toolbar>{{ directive }}</mat-toolbar>