build: better error reporting of bash scripts (#5397)

Currently whenever something fails in the deploy script it will likely not cause the CI to show the failure. This is because Bash by default doesn't exit the process with the proper error code.

scripts/ci/build-and-test.sh

@@ -1,5 +1,6 @@
 #!/bin/bash
 
+# The script should immediately exit if any command in the script fails.
 set -e
 
 echo ""

scripts/ci/publish-artifacts.sh

@@ -3,6 +3,9 @@
 # Script that runs after the testing stage of Travis passed.
 # Build artifacts and docs content will be published to different repositories.
 
+# The script should immediately exit if any command in the script fails.
+set -e
+
 # Go to the project root directory
 cd $(dirname $0)/../..
 

scripts/deploy/deploy-dashboard.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# The script should immediately exit if any command in the script fails.
+set -e
+
 # This script deploys the Dashboard App and their Cloud Functions to Firebase.
 # Before the script installs all dependencies and builds the dashboard app in production.
 

scripts/deploy/deploy-screenshot-functions.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# The script should immediately exit if any command in the script fails.
+set -e
+
 # Go to the project root directory
 cd $(dirname ${0})/../..
 

scripts/deploy/publish-build-artifacts.sh

@@ -3,7 +3,8 @@
 # Script to publish the build artifacts to a GitHub repository.
 # Builds will be automatically published once new changes are made to the repository.
 
-set -e -o pipefail
+# The script should immediately exit if any command in the script fails.
+set -e
 
 # Go to the project root directory
 cd $(dirname ${0})/../..

scripts/deploy/publish-docs-content.sh

@@ -3,6 +3,9 @@
 # Publish material2 docs assets to the material2-docs-content repo
 # material.angular.io will pull from this assets repo to get the latest docs
 
+# The script should immediately exit if any command in the script fails.
+set -e
+
 cd "$(dirname $0)/../../"
 
 docsPath="./dist/docs"