skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(test): fix menu and select for strict null check (#5316)

Browse Source
This commit is contained in:
Andrew Seguin
2017-06-22 16:37:42 -07:00
committed by Jeremy Elbourn
parent 8b6efb12e8
commit d75720b4a3
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/menu/menu.spec.ts
+3 -1
View File
@@ -141,7 +141,9 @@ describe('MdMenu', () => {
const menuPanel = overlayContainerElement.querySelector('.mat-menu-panel');
expect(menuPanel).toBeTruthy('Expected to find a menu panel.');
expect(menuPanel.getAttribute('role')).toBe('menu', 'Expected panel to have the "menu" role.');
const role = menuPanel ? menuPanel.getAttribute('role') : '';
expect(role).toBe('menu', 'Expected panel to have the "menu" role.');
});
describe('positions', () => {
src/lib/select/select.spec.ts
+3 -2
View File
@@ -1461,8 +1461,9 @@ describe('MdSelect', () => {
groupFixture.detectChanges();
const triggerTop = trigger.getBoundingClientRect().top;
const optionTop = overlayContainerElement.querySelector('.cdk-overlay-pane md-option')
.getBoundingClientRect().top;
const option = overlayContainerElement.querySelector('.cdk-overlay-pane md-option');
const optionTop = option ? option.getBoundingClientRect().top : 0;
// Since the option is 18px higher than the trigger, it needs to be adjusted by 9px.
expect(Math.floor(optionTop))