skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

docs: fix the visibleLines range on the ngFor tutorial step

Browse Source 
`visibleLines="26-131"` is not valid JSON, so `expandRangeStringValues` threw
and returned an empty list. The rendered attribute was empty, and the viewer
treats that as no range at all, so no ExampleViewer was created:
https://angular.dev/tutorials/first-app/08-ngFor showed all 128 lines of
`home.ts` with no collapse and no expand control, including the `@for` block
the reader has not written yet.

The file is 128 lines and the property this step adds ends at 127. The sibling
snippet on the same page already uses the `[start,end]` form.
This commit is contained in:
Kam
2026-09-07 16:53:34 +03:00
committed by Kristiyan Kostadinov
parent a959ceda76
commit d3ccf5ca82
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
adev/src/content/tutorials/first-app/steps/08-ngFor/README.md
+1 -1
View File
@@ -27,7 +27,7 @@ In the `Home` there is only a single housing location. In this step, you will ad
1. In `src/app/home/home.ts`, remove the `housingLocation` property from the `Home` class.
1. Update the `Home` class to have a property called `housingLocationList`. Update your code to match the following code:
<docs-code language="angular-ts" header="Add housingLocationList property in home.ts" path="adev/src/content/tutorials/first-app/steps/09-services/src/app/home/home.ts" visibleLines="26-131"/>
<docs-code language="angular-ts" header="Add housingLocationList property in home.ts" path="adev/src/content/tutorials/first-app/steps/09-services/src/app/home/home.ts" visibleLines="[26,127]"/>
IMPORTANT: Do not remove the `@Component` decorator, you will update that code in an upcoming step.