skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(form-field): superfluous whitespace when compiled with bazel (#13911)

Browse Source 
Fixes that the form-field does not render properly when being compiled through Bazel. This is because the whitespace is being preserved due to Bazel not minifying HTML files like we do with Gulp.
This commit is contained in:
Paul Gschwendtner
2019-07-16 16:05:10 +02:00
committed by Jeremy Elbourn
parent 8dffd8eef6
commit cf11ed2234
2 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/material/form-field/form-field.html
+1 -1
View File
@@ -43,7 +43,7 @@
<!-- @breaking-change 8.0.0 remove in favor of mat-label element an placeholder attr. -->
<ng-container *ngSwitchCase="false">
<ng-content select="mat-placeholder"></ng-content>
{{_control.placeholder}}
<span>{{_control.placeholder}}</span>
</ng-container>
<ng-content select="mat-label" *ngSwitchCase="true"></ng-content>
src/material/input/input.spec.ts
+7 -11
View File
@@ -367,8 +367,7 @@ describe('MatInput without forms', () => {
expect(inputEl.placeholder).toBe('Other placeholder');
expect(labelEl).not.toBeNull();
expect(labelEl.nativeElement.textContent).toMatch('Other placeholder');
expect(labelEl.nativeElement.textContent).not.toMatch(/\*/g);
expect(labelEl.nativeElement.textContent).toBe('Other placeholder');
}));
it('supports placeholder element', fakeAsync(() => {
@@ -384,8 +383,7 @@ describe('MatInput without forms', () => {
el = fixture.debugElement.query(By.css('label'));
expect(el).not.toBeNull();
expect(el.nativeElement.textContent).toMatch('Other placeholder');
expect(el.nativeElement.textContent).not.toMatch(/\*/g);
expect(el.nativeElement.textContent).toBe('Other placeholder');
}));
it('supports placeholder required star', fakeAsync(() => {
@@ -394,7 +392,7 @@ describe('MatInput without forms', () => {
let el = fixture.debugElement.query(By.css('label'));
expect(el).not.toBeNull();
expect(el.nativeElement.textContent).toMatch(/hello +\*/g);
expect(el.nativeElement.textContent).toBe('hello *');
}));
it('should hide the required star if input is disabled', () => {
@@ -406,8 +404,7 @@ describe('MatInput without forms', () => {
const el = fixture.debugElement.query(By.css('label'));
expect(el).not.toBeNull();
expect(el.nativeElement.textContent!.trim()).toMatch(/^hello$/);
expect(el.nativeElement.textContent).not.toMatch(/\*/g);
expect(el.nativeElement.textContent).toBe('hello');
});
it('should hide the required star from screen readers', fakeAsync(() => {
@@ -425,13 +422,12 @@ describe('MatInput without forms', () => {
let el = fixture.debugElement.query(By.css('label'));
expect(el).not.toBeNull();
expect(el.nativeElement.textContent).toMatch(/hello +\*/g);
expect(el.nativeElement.textContent).toBe('hello *');
fixture.componentInstance.hideRequiredMarker = true;
fixture.detectChanges();
expect(el.nativeElement.textContent).toMatch(/hello/g);
expect(el.nativeElement.textContent).not.toMatch(/\*/g);
expect(el.nativeElement.textContent).toBe('hello');
}));
it('supports the disabled attribute as binding', fakeAsync(() => {
@@ -894,7 +890,7 @@ describe('MatInput without forms', () => {
expect(container.classList).toContain('mat-form-field-hide-placeholder');
expect(container.classList).not.toContain('mat-form-field-should-float');
expect(label.textContent.trim()).toBe('Label');
expect(label.textContent).toBe('Label');
expect(input.getAttribute('placeholder')).toBe('Placeholder');
input.value = 'Value';