refactor(core): tree-shake away a DI error message string in prod bundles (#45994)

This commit adds the `ngDevMode` check to tree-shake away an error message string (which also retains a reference to an extra function).

PR Close #45994

goldens/size-tracking/integration-payloads.json

@@ -19,7 +19,7 @@
   "cli-hello-world-ivy-compat": {
     "uncompressed": {
       "runtime": 1102,
-      "main": 133968,
+      "main": 133416,
       "polyfills": 33957
     }
   },

packages/core/src/render3/errors_di.ts

@@ -48,5 +48,5 @@ export function throwProviderNotFoundError(token: any, injectorName?: string): n
   const injectorDetails = injectorName ? ` in ${injectorName}` : '';
   throw new RuntimeError(
       RuntimeErrorCode.PROVIDER_NOT_FOUND,
-      `No provider for ${stringifyForError(token)} found${injectorDetails}`);
+      ngDevMode && `No provider for ${stringifyForError(token)} found${injectorDetails}`);
 }

packages/core/test/bundling/animations/bundle.golden_symbols.json

@@ -1328,9 +1328,6 @@
   {
     "name": "stringifyCSSSelector"
   },
-  {
-    "name": "stringifyForError"
-  },
   {
     "name": "style"
   },

packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json

@@ -413,9 +413,6 @@
   {
     "name": "stringify"
   },
-  {
-    "name": "stringifyForError"
-  },
   {
     "name": "throwProviderNotFoundError"
   },

packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json

@@ -1487,9 +1487,6 @@
   {
     "name": "stringifyCSSSelector"
   },
-  {
-    "name": "stringifyForError"
-  },
   {
     "name": "subscribeTo"
   },

packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json

@@ -1466,9 +1466,6 @@
   {
     "name": "stringifyCSSSelector"
   },
-  {
-    "name": "stringifyForError"
-  },
   {
     "name": "subscribeTo"
   },

packages/core/test/bundling/hello_world/bundle.golden_symbols.json

@@ -314,9 +314,6 @@
   {
     "name": "stringify"
   },
-  {
-    "name": "stringifyForError"
-  },
   {
     "name": "throwProviderNotFoundError"
   },

packages/core/test/bundling/injection/bundle.golden_symbols.json

@@ -116,9 +116,6 @@
   {
     "name": "injectInjectorOnly"
   },
-  {
-    "name": "injectRootLimpMode"
-  },
   {
     "name": "injectableDefOrInjectorDefFactory"
   },

packages/core/test/bundling/router/bundle.golden_symbols.json

@@ -1862,9 +1862,6 @@
   {
     "name": "stringifyCSSSelector"
   },
-  {
-    "name": "stringifyForError"
-  },
   {
     "name": "stripTrailingSlash"
   },

packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json

@@ -836,9 +836,6 @@
   {
     "name": "stringifyCSSSelector"
   },
-  {
-    "name": "stringifyForError"
-  },
   {
     "name": "subscribeTo"
   },

packages/core/test/bundling/todo/bundle.golden_symbols.json

@@ -773,9 +773,6 @@
   {
     "name": "stringifyCSSSelector"
   },
-  {
-    "name": "stringifyForError"
-  },
   {
     "name": "throwProviderNotFoundError"
   },