skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): fixes test timer-based test flakiness in CI (#59674)

Browse Source 
This converts two tests that rely on timers to use fakeAsync. This resolves the flakiness.

PR Close #59674
This commit is contained in:
Jessica Janiuk
2025-01-22 15:50:16 -05:00
committed by Andrew Kushnir
parent 7dc5116f62
commit c2436702df
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/platform-server/test/incremental_hydration_spec.ts
+5 -5
View File
@@ -38,7 +38,7 @@ import {
withEventReplay,
withIncrementalHydration,
} from '@angular/platform-browser';
import {TestBed} from '@angular/core/testing';
import {fakeAsync, TestBed} from '@angular/core/testing';
import {PLATFORM_BROWSER_ID} from '@angular/common/src/platform_id';
import {DEHYDRATED_BLOCK_REGISTRY} from '@angular/core/src/defer/registry';
import {JSACTION_BLOCK_ELEMENT_MAP} from '@angular/core/src/hydration/tokens';
@@ -1329,7 +1329,7 @@ describe('platform-server partial hydration integration', () => {
});
describe('timer', () => {
it('top level timer', async () => {
it('top level timer', fakeAsync(async () => {
@Component({
selector: 'app',
template: `
@@ -1399,9 +1399,9 @@ describe('platform-server partial hydration integration', () => {
appRef.tick();
expect(appHostNode.outerHTML).toContain('<span id="test">end</span>');
});
}));
it('nested timer', async () => {
it('nested timer', fakeAsync(async () => {
@Component({
selector: 'app',
template: `
@@ -1487,7 +1487,7 @@ describe('platform-server partial hydration integration', () => {
appRef.tick();
expect(appHostNode.outerHTML).toContain('<span id="test">end</span>');
});
}));
});
it('when', async () => {