skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(menu): set animation origin based on overlay position (#5347)

Browse Source 
Uses the menu panel's overlay position to determine the animation origin, instead of the trigger. These changes make it easier to follow and avoid having to correct it explicitly based on the `overlapTrigger` flag, in addition to fixing some issues in nested menus.
This commit is contained in:
Kristiyan Kostadinov
2017-07-07 18:06:45 +02:00
committed by mmalerba
parent dd230a3090
commit b3957d8083
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/menu/menu-trigger.ts
+3 -7
View File
@@ -238,13 +238,9 @@ export class MdMenuTrigger implements AfterViewInit, OnDestroy {
* correct, even if a fallback position is used for the overlay.
*/
private _subscribeToPositions(position: ConnectedPositionStrategy): void {
this._positionSubscription = position.onPositionChange.subscribe((change) => {
const posX: MenuPositionX = change.connectionPair.originX === 'start' ? 'after' : 'before';
let posY: MenuPositionY = change.connectionPair.originY === 'top' ? 'below' : 'above';
if (!this.menu.overlapTrigger) {
posY = posY === 'below' ? 'above' : 'below';
}
this._positionSubscription = position.onPositionChange.subscribe(change => {
const posX: MenuPositionX = change.connectionPair.overlayX === 'start' ? 'after' : 'before';
const posY: MenuPositionY = change.connectionPair.overlayY === 'top' ? 'below' : 'above';
this.menu.setPositionClasses(posX, posY);
});