skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(language-service): account for strictTemplates being enabled by default

Browse Source 
We were raising the suggestion about enabling `strictTemplates` when `strictTemplates` is ommitted, however the option is now enabled by default.

Fixes #69905.

(cherry picked from commit e606a020e9)
This commit is contained in:
Kristiyan Kostadinov
2026-07-23 10:35:26 +02:00
committed by Alex Rickabaugh
parent da08a8fa59
commit a99fb915c0
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/language-service/src/language_service.ts
+1 -1
View File
@@ -899,7 +899,7 @@ export class LanguageService {
project.readFile(path),
);
if (!this.options.strictTemplates) {
if (this.options.strictTemplates === false) {
diagnostics.push({
messageText:
'Some language features are not available. ' +
packages/language-service/test/legacy/language_service_spec.ts
+14 -2
View File
@@ -107,9 +107,11 @@ describe('language service adapter', () => {
});
describe('compiler options diagnostics', () => {
it('suggests turning on strict flag', () => {
it('suggests turning on strict flag when strictTemplates is explicitly false', () => {
configFileFs.overwriteConfigFile(TSCONFIG, {
angularCompilerOptions: {},
angularCompilerOptions: {
strictTemplates: false,
},
});
const diags = ngLS.getCompilerOptionsDiagnostics();
const diag = diags.find(isSuggestStrictTemplatesDiag);
@@ -128,6 +130,16 @@ describe('language service adapter', () => {
const diag = diags.find(isSuggestStrictTemplatesDiag);
expect(diag).toBeUndefined();
});
it('does not suggest turning on strict mode is strictTemplates flag is ommitted', () => {
configFileFs.overwriteConfigFile(TSCONFIG, {
angularCompilerOptions: {},
});
const diags = ngLS.getCompilerOptionsDiagnostics();
const diag = diags.find(isSuggestStrictTemplatesDiag);
expect(diag).toBeUndefined();
});
function isSuggestStrictTemplatesDiag(diag: ts.Diagnostic) {
return diag.code === ngErrorCode(ErrorCode.SUGGEST_STRICT_TEMPLATES);
}