skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(devtools): fix reading resolutionPath (#60403)

Browse Source 
Sometimes `forest` can be empty if the provided roots are empty, and was leading to a "Cannot read `resolutionPath` of `undefined`" error. Now we check the forest has a tree in it before looking up `resolutionPath`.

There might be a separate issue with the fact that the backend script likely shouldn't be emitting an empty forest in the first place. However we already check that a resolution path exists at all, so I think it's fair to also check that a tree was provided. We can separately look into making sure the backend is emitting valid data.

PR Close #60403
This commit is contained in:
Doug Parker
2025-03-14 15:46:17 -07:00
committed by Pawel Kozlowski
parent 82fb14e600
commit 9dffdd744d
2 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
devtools/projects/ng-devtools-backend/src/lib/client-event-subscribers.ts
+8 -6
View File
@@ -222,13 +222,15 @@ const getRoutes = (messageBus: MessageBus<Events>) => {
initializeOrGetDirectiveForestHooks().getIndexedDirectiveForest(),
ngDebugDependencyInjectionApiIsSupported(),
);
if (forest.length === 0) return;
const rootInjector = (forest[0].resolutionPath ?? []).find((i) => i.name === 'Root');
if (rootInjector) {
const route = getRouterConfigFromRoot(rootInjector);
if (route) {
messageBus.emit('updateRouterTree', [[route]]);
}
}
if (!rootInjector) return;
const route = getRouterConfigFromRoot(rootInjector);
if (!route) return;
messageBus.emit('updateRouterTree', [[route]]);
};
const getSerializedProviderRecords = (injector: SerializedInjector) => {
devtools/projects/ng-devtools/src/lib/devtools-tabs/injector-tree/injector-tree.component.ts
+7 -5
View File
@@ -91,11 +91,13 @@ export class InjectorTreeComponent {
private init() {
this._messageBus.on('latestComponentExplorerView', (view: ComponentExplorerView) => {
if (view.forest[0].resolutionPath !== undefined) {
this.diDebugAPIsAvailable.set(true);
this.rawDirectiveForest = view.forest;
this.updateInjectorTreeVisualization(view.forest);
}
if (view.forest.length === 0) return;
if (!view.forest[0].resolutionPath) return;
this.diDebugAPIsAvailable.set(true);
this.rawDirectiveForest = view.forest;
this.updateInjectorTreeVisualization(view.forest);
});
this._messageBus.on(