mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
refactor(common): removed TODO no longer considered necessary (#43378)
The TODO comment suggesting to verify that the target element to scroll to needs to be an anchor does not longer seems under consideration so it can be removed resolves #43348 PR Close #43378
This commit is contained in:
committed by
Andrew Scott
parent
d647491679
commit
9c7d18e892
@@ -120,9 +120,7 @@ export class BrowserViewportScroller implements ViewportScroller {
|
||||
if (!this.supportsScrolling()) {
|
||||
return;
|
||||
}
|
||||
// TODO(atscott): The correct behavior for `getElementsByName` would be to also verify that the
|
||||
// element is an anchor. However, this could be considered a breaking change and should be
|
||||
// done in a major version.
|
||||
|
||||
const elSelected = findAnchorFromDocument(this.document, target);
|
||||
|
||||
if (elSelected) {
|
||||
|
||||
Reference in New Issue
Block a user