skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(button-toggle): setting blank aria-label attribute by default (#10605)

Browse Source 
Fixes the button toggle setting the `aria-label` of its underlying input to a blank value by default.
This commit is contained in:
Kristiyan Kostadinov
2018-04-05 17:05:30 +02:00
committed by Jeremy Elbourn
parent b38b966b92
commit 95dba5917e
2 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/button-toggle/button-toggle.spec.ts
+13 -7
View File
@@ -622,16 +622,22 @@ describe('MatButtonToggle without forms', () => {
});
describe('with provided aria-label ', () => {
let checkboxDebugElement: DebugElement;
let checkboxNativeElement: HTMLElement;
let inputElement: HTMLInputElement;
describe('aria-label handling ', () => {
it('should not set the aria-label attribute if none is provided', () => {
let fixture = TestBed.createComponent(StandaloneButtonToggle);
let checkboxDebugElement = fixture.debugElement.query(By.directive(MatButtonToggle));
let checkboxNativeElement = checkboxDebugElement.nativeElement;
let inputElement = checkboxNativeElement.querySelector('input') as HTMLInputElement;
fixture.detectChanges();
expect(inputElement.hasAttribute('aria-label')).toBe(false);
});
it('should use the provided aria-label', () => {
let fixture = TestBed.createComponent(ButtonToggleWithAriaLabel);
checkboxDebugElement = fixture.debugElement.query(By.directive(MatButtonToggle));
checkboxNativeElement = checkboxDebugElement.nativeElement;
inputElement = checkboxNativeElement.querySelector('input') as HTMLInputElement;
let checkboxDebugElement = fixture.debugElement.query(By.directive(MatButtonToggle));
let checkboxNativeElement = checkboxDebugElement.nativeElement;
let inputElement = checkboxNativeElement.querySelector('input') as HTMLInputElement;
fixture.detectChanges();
expect(inputElement.getAttribute('aria-label')).toBe('Super effective');
src/lib/button-toggle/button-toggle.ts
+1 -1
View File
@@ -340,7 +340,7 @@ export class MatButtonToggle extends _MatButtonToggleMixinBase implements OnInit
* Attached to the aria-label attribute of the host element. In most cases, arial-labelledby will
* take precedence so this may be omitted.
*/
@Input('aria-label') ariaLabel: string = '';
@Input('aria-label') ariaLabel: string;
/**
* Users can specify the `aria-labelledby` attribute which will be forwarded to the input element