skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(devtools): show not-angular popup for non-angular apps

Browse Source
This commit is contained in:
mgechev
2020-05-11 15:40:17 -07:00
committed by Minko Gechev
parent d9c3ca7b64
commit 815d697efe
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/shell-chrome/src/app/background.ts
+7 -5
View File
@@ -100,16 +100,18 @@ const getPopUpName = (ng: AngularDetection) => {
};
chrome.runtime.onMessage.addListener((req, sender) => {
if (sender.tab && req.isAngular) {
if (sender && sender.tab) {
chrome.browserAction.setPopup({
tabId: sender.tab.id,
popup: `popups/${getPopUpName(req)}`,
});
}
if (sender && sender.tab && req.isAngular) {
chrome.browserAction.setIcon({
tabId: sender.tab.id,
path: {
16: `assets/favicon.ico`,
},
});
chrome.browserAction.setPopup({
tabId: sender.tab.id,
popup: `popups/${getPopUpName(req)}`,
});
}
});