skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: bazel repository changes not cached on circleci (#14642)

Browse Source 
Currently if we update the Bazel `WORKSPACE` and some external repositories have changed, CircleCI won't be able to cache the bazel repositories because the cache-key has not changed and saving will be skipped. We should make sure that the Bazel repositories will be cached properly because otherwise this can cause a significant slow-down with Bazel managed deps.

Additionally we no longer store the cache based on the current `branch` because that means that caching does not always work for pull requests. Since the caching only depends on two inputs (yarn.lock and WORKSPACE), it's safe to just remove the branch from the cache key.
This commit is contained in:
Paul Gschwendtner
2019-01-11 23:43:23 +01:00
committed by Andrew Seguin
parent 77f568bb33
commit 7d7b50998a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.circleci/config.yml
+1 -1
View File
@@ -8,7 +8,7 @@
# http://yaml-online-parser.appspot.com/
var_1: &docker_image angular/ngcontainer:0.7.0
var_2: &cache_key v2-ng-mat-{{ .Branch }}-{{ checksum "yarn.lock" }}-0.7.0
var_2: &cache_key v2-ng-mat-{{ checksum "WORKSPACE" }}-{{ checksum "yarn.lock" }}-0.7.0
# Settings common to each job
var_3: &job_defaults