skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(docs-infra): only claim a search on the 404 page when results exist

Browse Source 
The "Page Not Found" page always rendered the sentence "We have
initiated a search for the term extracted from the URL", but the
NotFound component only runs a search when a term can be extracted,
and only renders results when there is at least one hit. On a 404
with no extractable term or no matching results, the page asserted
a search it never backed up.

Gate the sentence behind the same searchResults() check that guards
the results list, so the empty state simply reads "We couldn't find
what you were looking for."
This commit is contained in:
Kam
2026-07-18 21:57:49 +03:00
committed by Pawel Kozlowski
parent b8a0fa00c9
commit 79fe1c3a05
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
adev/src/app/features/not-found/not-found.html
+4 -2
View File
@@ -4,8 +4,10 @@
<div class="docs-not-found__bubble">
<h1 tabindex="-1">Page Not Found</h1>
<p>
We couldn't find what you were looking for. We have initiated a search for the term
extracted from the URL.
We couldn't find what you were looking for.
@if (searchResults().length > 0) {
We have initiated a search for the term extracted from the URL.
}
</p>
<p>
If you think this is a mistake, please