skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(common): use locale NaN symbol in number formatting

Browse Source 
Non-finite values all used NumberSymbol.Infinity, so formatNumber(NaN)
rendered as infinity. Locale data already defines NumberSymbol.NaN.
This commit is contained in:
Xia Chao
2026-08-25 15:50:22 +08:00
committed by Leon Senft
parent 3be5facf04
commit 7596548e9b
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/common/src/i18n/format_number.ts
+5 -1
View File
@@ -43,7 +43,11 @@ function formatNumberToLocaleString(
let isZero = false;
if (!isFinite(value)) {
formattedText = getLocaleNumberSymbol(locale, NumberSymbol.Infinity);
// `Number.isNaN` (not `!isFinite`) so NaN uses the locale NaN symbol, not Infinity.
formattedText = getLocaleNumberSymbol(
locale,
Number.isNaN(value) ? NumberSymbol.NaN : NumberSymbol.Infinity,
);
} else {
let parsedNumber = parseNumber(value);
packages/common/test/i18n/format_number_spec.ts
+10
View File
@@ -38,6 +38,16 @@ describe('Format number', () => {
expect(formatNumber(1e100, ɵDEFAULT_LOCALE_ID)).toEqual('1E+100');
});
it('should format NaN and Infinity with locale symbols', () => {
expect(formatNumber(NaN, ɵDEFAULT_LOCALE_ID)).toEqual('NaN');
expect(formatNumber(Infinity, ɵDEFAULT_LOCALE_ID)).toEqual('∞');
expect(formatNumber(-Infinity, ɵDEFAULT_LOCALE_ID)).toEqual('-∞');
expect(formatPercent(NaN, ɵDEFAULT_LOCALE_ID)).toEqual('NaN%');
expect(formatPercent(Infinity, ɵDEFAULT_LOCALE_ID)).toEqual('∞%');
expect(formatCurrency(NaN, ɵDEFAULT_LOCALE_ID, '$')).toEqual('$NaN');
expect(formatCurrency(Infinity, ɵDEFAULT_LOCALE_ID, '$')).toEqual('$∞');
});
it('should throw if minFractionDigits is explicitly higher than maxFractionDigits', () => {
expect(() => formatNumber(1.1, ɵDEFAULT_LOCALE_ID, '3.4-2')).toThrowError(
/is higher than the maximum/,