skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fixup! build: replace setup angular snapshots script with python script

Browse Source 
Add comment explaining why script needs to be in python
This commit is contained in:
Paul Gschwendtner
2019-06-20 20:38:32 +02:00
committed by Jeremy Elbourn
parent 21594d33e8
commit 6ee271f559
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/circleci/setup-angular-snapshots.py
+7
View File
@@ -12,6 +12,13 @@
to flatten **all** dependencies and could cause unexpected results. We **only** want to
explicitly flatten out all `@angular/*` dependencies. This can be achieved with resolutions.
Read more here: https://yarnpkg.com/lang/en/docs/package-json/#toc-resolutions
**Note** that this script has to be written in Python because the docker container which
is used for our CI does not come with NodeJS pre-installed. Since this script needs to run
before the Bazel analysis phase is started, we can only run this script only with tools that
are pre-installed in the image. Python is a pre-installed in the google/bazel official image
and therefore we use that for the "package.json" modification. Note that this script is only
running on CI and therefore there are no implications with writing this in python.
"""
import json