From 6ee271f55951e84bcd7934b974e08647c16e6ee0 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Thu, 20 Jun 2019 20:38:32 +0200 Subject: [PATCH] fixup! build: replace setup angular snapshots script with python script Add comment explaining why script needs to be in python --- scripts/circleci/setup-angular-snapshots.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/circleci/setup-angular-snapshots.py b/scripts/circleci/setup-angular-snapshots.py index 90e7f62d3bc..69d1c16c444 100644 --- a/scripts/circleci/setup-angular-snapshots.py +++ b/scripts/circleci/setup-angular-snapshots.py @@ -12,6 +12,13 @@ to flatten **all** dependencies and could cause unexpected results. We **only** want to explicitly flatten out all `@angular/*` dependencies. This can be achieved with resolutions. Read more here: https://yarnpkg.com/lang/en/docs/package-json/#toc-resolutions + + **Note** that this script has to be written in Python because the docker container which + is used for our CI does not come with NodeJS pre-installed. Since this script needs to run + before the Bazel analysis phase is started, we can only run this script only with tools that + are pre-installed in the image. Python is a pre-installed in the google/bazel official image + and therefore we use that for the "package.json" modification. Note that this script is only + running on CI and therefore there are no implications with writing this in python. """ import json