skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(service-worker): NPE if onActionClick is undefined (#43210)

Browse Source 
Previously, it leads to fail if notification.data.onActionClick is undefined

PR Close #43210
This commit is contained in:
shlasouski
2021-08-20 15:23:47 +03:00
committed by Alex Rickabaugh
parent b10d90bef6
commit 6e924313c3
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/service-worker/worker/src/driver.ts
+1 -1
View File
@@ -354,7 +354,7 @@ export class Driver implements Debuggable, UpdateSource {
const notificationAction = action === '' || action === undefined ? 'default' : action;
const onActionClick = notification?.data?.onActionClick[notificationAction];
const onActionClick = notification?.data?.onActionClick?.[notificationAction];
const urlToOpen = new URL(onActionClick?.url ?? '', this.scope.registration.scope).href;
packages/service-worker/worker/test/happy_spec.ts
+15
View File
@@ -1055,6 +1055,21 @@ describe('Driver', () => {
});
});
describe('no onActionClick field', () => {
it('has no client interaction', async () => {
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
spyOn(scope.clients, 'openWindow');
await driver.initialized;
await scope.handleClick(
{title: 'This is a test without action', body: 'Test body without action', data: {}});
await scope.handleClick(
{title: 'This is a test with an action', body: 'Test body with an action', data: {}},
'someAction');
expect(scope.clients.openWindow).not.toHaveBeenCalled();
});
});
describe('URL resolution', () => {
it('should resolve relative to service worker scope', async () => {
(scope.registration.scope as string) = 'http://localhost/foo/bar/';