skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(docs-infra): replace @Input with signal input for ignoredElementsIds in ClickOutside directive (#64302)

Browse Source 
replace @Input with signal input for ignoredElementsIds in ClickOutside directive

PR Close #64302
This commit is contained in:
SkyZeroZx
2025-10-08 21:51:35 -05:00
committed by Andrew Kushnir
parent 4bcbac121c
commit 6bc391c3d4
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
adev/shared-docs/directives/click-outside/click-outside.directive.ts
+4 -5
View File
@@ -7,7 +7,7 @@
*/
import {DOCUMENT} from '@angular/common';
import {Directive, ElementRef, Input, inject, output} from '@angular/core';
import {Directive, ElementRef, inject, input, output} from '@angular/core';
@Directive({
selector: '[docsClickOutside]',
@@ -16,8 +16,7 @@ import {Directive, ElementRef, Input, inject, output} from '@angular/core';
},
})
export class ClickOutside {
// TODO: Understand why replacing this @Input with a signal input breaks the tests
@Input('docsClickOutsideIgnore') public ignoredElementsIds: string[] = [];
readonly ignoredElementsIds = input<string[]>([], {alias: 'docsClickOutsideIgnore'});
public readonly clickOutside = output<void>({alias: 'docsClickOutside'});
private readonly document = inject(DOCUMENT);
@@ -33,11 +32,11 @@ export class ClickOutside {
}
private wasClickedOnIgnoredElement(event: MouseEvent): boolean {
if (this.ignoredElementsIds.length === 0) {
if (this.ignoredElementsIds().length === 0) {
return false;
}
return this.ignoredElementsIds.some((elementId) => {
return this.ignoredElementsIds().some((elementId) => {
const element = this.document.getElementById(elementId);
const target = event.target as Node;
const contains = element?.contains(target);